From: Tom Rix <trix@redhat.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static
Date: Fri, 14 Jul 2023 17:51:13 -0400 [thread overview]
Message-ID: <20230714215113.3919026-1-trix@redhat.com> (raw)
smatch reports
mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
was not declared. Should it be static?
mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
was not declared. Should it be static?
These variables are only used in their defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
mm/shmem_quota.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c
index e349c0901bce..062d1c1097ae 100644
--- a/mm/shmem_quota.c
+++ b/mm/shmem_quota.c
@@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot)
return 0;
}
-int shmem_mark_dquot_dirty(struct dquot *dquot)
+static int shmem_mark_dquot_dirty(struct dquot *dquot)
{
return 0;
}
-int shmem_dquot_write_info(struct super_block *sb, int type)
+static int shmem_dquot_write_info(struct super_block *sb, int type)
{
return 0;
}
--
2.27.0
next reply other threads:[~2023-07-14 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 21:51 Tom Rix [this message]
2023-07-15 3:14 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714215113.3919026-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox