From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47662C0015E for ; Fri, 14 Jul 2023 15:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8C8E8E000B; Fri, 14 Jul 2023 11:26:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D15D38E000A; Fri, 14 Jul 2023 11:26:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7418E000B; Fri, 14 Jul 2023 11:26:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A9A9D8E000A for ; Fri, 14 Jul 2023 11:26:23 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6EADD1C843D for ; Fri, 14 Jul 2023 15:26:23 +0000 (UTC) X-FDA: 81010593846.25.877A6D4 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf10.hostedemail.com (Postfix) with ESMTP id B3EB1C0009 for ; Fri, 14 Jul 2023 15:26:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ZCqnWZPY; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689348381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PW9O2dLBokh6X5owFYBB430L2RtltUnavOejKbrhHjw=; b=07krbJDsn/9kVoUxYx5Sj1QOi7U94D4aGsuGM3SCeiKxbIo8BFlSMSGOD+i9xBoG+XSX86 nQCFfW1ukA8yd6FOQvn4edVPIs+JwlYgCpl0Y5VGHelS3nqCfR4at3/SCsT7pbg9VmUuF2 raXGb7LrDi4sLHuVvwA38FkXuHrrems= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689348381; a=rsa-sha256; cv=none; b=cp/RMwVJi2HJzE9zkrtj+z3DX/8ELDWfP+J26yWvB+5OgHQgF6tonsweiI0ur5R4UdfglZ z+HHmYMhOpiIwUX1HMcHuvG1IZivpU0hgZzYPCjX8j9HNIP3w9qfPAqg/RZFrqq4+66luA HHwlHC8ist2boZOUdH8vzXE6rO6z8Po= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ZCqnWZPY; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PW9O2dLBokh6X5owFYBB430L2RtltUnavOejKbrhHjw=; b=ZCqnWZPYXmbMaF2DqtjhPvKQ16 J6Rf7d1jC7H8suBMEHYrmniHqFcRDiN81vJ+fM+fZ44fBnZoyWOon1gXoAYlnXdA/ECLmmxNuY4WV 62sOQXTtVigQ8wLY3D0NVG0xH4CVDxDfsCllPO3D3yGJtZJdlrniuicm0VKq4iyjDoK5D3RJOhElb VbnBr3WMk2arYGI937L8JNlvR/ykRURCEgX/HMQeZONb5WG5HVLzggQ9rQAC+qUXdKVB6IR61SH/h r2AgXVtnjROhAYpz23dCq/AWZzC/2MA3iEQeRhKGbhF9Sy+HCxb0oAQ5l0wP2YOF2irmmw/uTjpzF Scb8Pkkw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qKKgR-006JOI-2P; Fri, 14 Jul 2023 15:26:16 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5638A3001E7; Fri, 14 Jul 2023 17:26:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3EF2121372896; Fri, 14 Jul 2023 17:26:15 +0200 (CEST) Date: Fri, 14 Jul 2023 17:26:15 +0200 From: Peter Zijlstra To: Matthew Wilcox Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 05/10] mm: Add vmalloc_huge_node() Message-ID: <20230714152615.GE3261758@hirez.programming.kicks-ass.net> References: <20230714133859.305719029@infradead.org> <20230714141218.947137012@infradead.org> <20230714150948.GC3261758@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B3EB1C0009 X-Rspam-User: X-Stat-Signature: e1a5f8jp19hpnu9r5g3tmqs4ygi1s44i X-Rspamd-Server: rspam03 X-HE-Tag: 1689348381-743902 X-HE-Meta: U2FsdGVkX1/yoRUBh0XxvBwg+W1TSGXGz/bx6Kes749fScOGXx2HvGfvjdG6HOAPAyTA4EoDrVs+Nu43LS0F2CqB8LzCf5CqD4XU6hbmdWPnvQBZfF8xIyVyKhGphBkBLd3QQaI+oMwZXNrUYrM4X+9pul5RDxSJs+6uVCPy3HUo1ireTYKE1l6Mr+DXjSQ/ggrZTW8vqPYXUQ/jNFnmXR0cvpxfJK6uT0QjjoMIHyL9c3/vOiI7u/dad6bUElk9hnKL6TB0uCcaZUarYUbe4ZqlbcIlFJshk6jlfiXNYvYCtXKwjZE0zs02mBBVierlz1RdrWOcG1mTIrcq/oY+FhVnjVtCfOsLeDirBDXZFaSi1sTrBhQK7iPRKdPmH4WB9HKgzGtXjsWE5y2LwbUGLkU5V6Fxwv/4IH+LrJcr4er+JYjWgFN1jbpnSqEKdKdEeBbCLBqqt0Dto7BtH+debSTD15FbYtRLgXMuvXCA/b6ND5e2qslJvvDKAOBYPP9F4JW0n7iyuDNuK5M9WzN968+1LTNQY432sFtH6gkVmu8prpswDVObSL+w+xkRefc3tWICO/+RI+404FnMjnQp8AUjmhm2tfhG14x76IkazAQC+xTtdsiz3jDayvPMzyFF7FuGQDrVnChKZvxTtwwgS4E3/D320ff8rCIyW2TRWMnQE877Zc+X5TpcH+Au+Aw16l4jQfgm2RKKF9YR0aLUKpiZwOKD44gJH33/0mj0Ml4aIx1MyQmSlKbgZJxwYPhImrAU30KPI+pqZ/qCIHnAwMMcokJcSFnJhZ3AAjxPslExVnS9drf/n9kIzgwmx4uSnFhtGymEo5DBbyY7SMR7d50/T2mYuJuBf5+FC2bQsxnvhDs7G005JvTZwtLuepC6bpKza1HLc3g8KRqHELWLugrw24IqeNSI3ZaSj2bmta0qg6NV9I50wmTMGL5UG2Fb5lkTkVkFePd7n2dViOK wEkwWau9 +Byo6zKI2MUi4OFacJJj7gs7dGs6lWcskhJWiilK/0z/tT9FOEEW42+OH9SRrTxVW/Nvlt3Nop4mJgiOVtGoCU0uMNpFeV5SEVuXWuFVgIoG4r+0wkAIVJBJzsE72ygg2n+lhijNpfbRGZG1wlbBbSxj5cFAQvgEg/bMI6i6B40aQ3+E8ZZwCZhHpSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 04:11:39PM +0100, Matthew Wilcox wrote: > ... or just don't change vmalloc_huge()? Yeah, that, everything else just adds more lines without read benefit. I eneded up with the below. --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -152,6 +152,7 @@ extern void *__vmalloc_node_range(unsign void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, int node, const void *caller) __alloc_size(1); void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) __alloc_size(1); +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) __alloc_size(1); extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2); --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3416,6 +3416,13 @@ void *vmalloc(unsigned long size) } EXPORT_SYMBOL(vmalloc); +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) +{ + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, + node, __builtin_return_address(0)); +} + /** * vmalloc_huge - allocate virtually contiguous memory, allow huge pages * @size: allocation size