From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90341EB64DC for ; Fri, 14 Jul 2023 15:22:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A81518E0009; Fri, 14 Jul 2023 11:22:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A30568D0005; Fri, 14 Jul 2023 11:22:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F8458E0009; Fri, 14 Jul 2023 11:22:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7FC818D0005 for ; Fri, 14 Jul 2023 11:22:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B30D80290 for ; Fri, 14 Jul 2023 15:22:36 +0000 (UTC) X-FDA: 81010584312.27.6498C29 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf23.hostedemail.com (Postfix) with ESMTP id 2FBDA140013 for ; Fri, 14 Jul 2023 15:22:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=LfxgLtcS; dmarc=none; spf=none (imf23.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689348154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bBqAMyX2AHoHemD+tuHzcjsCRInWCFSES1FRbicuNyA=; b=VNYmJ0sSBXEuVCTfNdcN3jMm9YHrNnbdA6x0HSQZ2kNnhralGbP9LEZEUPTRp4aDJqO0hu jYp4kDPy6Wil/pkCqOMbjjslqhJtljORTA/bwl0o7sS8YgFp7aKZmYsK955rDwkXoRZfTX lw8EWZIKlCY8qWmzH+GoC4QPeQ4jvbc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=LfxgLtcS; dmarc=none; spf=none (imf23.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689348154; a=rsa-sha256; cv=none; b=IvVoYq7S7Qtf2JpkRDnKp57v319SqBktBJixp28V7t0q8r0qeVyf7u8IhAroFmCBgZheer eReAOgyQYLa8YUmGLSMhLY7Z9TXqz2f+qYITdZJcxBjWspuNQN4A4Qor3ITTHPqbJtfnkN x5SXj2B+IvbmBO+9rdEITZ9+7BwvGMY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bBqAMyX2AHoHemD+tuHzcjsCRInWCFSES1FRbicuNyA=; b=LfxgLtcS2gJ2h+UcRLdSWXsKqA i4ali0EFEsBwQnes/RyLBN3x2ouSfTyTsZf02qmM1q/hX/Wo6cDSWiSZLOK89K8uDXpDTVd4tomLX Mz0FoBPJRiEatUAfO2BoyZ2xXU27EWVO30lB6DZuL3T7Xy+eVToeUyjwcyy70MgeqLN+ycTZtV2HX YcVYiLXRfzwEotnj3Y9P4c7snBx+jkAsS7Poj5poZCHjUjeiVx1zqq3NjPVoJ8wUnTX2NxxdNsJ4P Fw81QGsT+P9nEUVRXMaCbx3OxZ0djVBtQb1I0j1JsTBYFZQ5UimcbyxTEq4g5DdSjLNENads3F+x8 1K+U2JMg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qKKci-006JMP-2n; Fri, 14 Jul 2023 15:22:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F04FE300274; Fri, 14 Jul 2023 17:22:22 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A7B9D21372883; Fri, 14 Jul 2023 17:22:22 +0200 (CEST) Date: Fri, 14 Jul 2023 17:22:22 +0200 From: Peter Zijlstra To: tglx@linutronix.de, axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 07/10] futex: Implement FUTEX2_NUMA Message-ID: <20230714152222.GD3261758@hirez.programming.kicks-ass.net> References: <20230714133859.305719029@infradead.org> <20230714141219.081639007@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714141219.081639007@infradead.org> X-Rspamd-Queue-Id: 2FBDA140013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: iotrbws6nbi8hkdqc77f34wrjn11trmu X-HE-Tag: 1689348153-963392 X-HE-Meta: U2FsdGVkX1/819Jp6w8XgEBWmqrbCGbTuzpTUSCJ7RAgPkjYrQAzWR12TZ7l1t7HnvWZfkMpru3A3uUiF5anASnUQP0kpN3PWaNy+MwxtJWyvDdimM71UrPRxBwrAu+0tchExNP+O+r+kckEx2YR4SQga16l1OTwSSLNxz81eq8iQnb/1PcIfCyXoytqbs7L5QzNhwzl70aPLs48jj3HZRHZRnko6OQwV81TB+LQG6Ni0DNyQJXCVT0RbnbpAxVPJM+xD7PMctss/0HqHAX8JlNHUUTNdUT6bhL5uQCqKgJZQ4nX9T9ynRAoHrFU+0JXak2jvhLGmTdwt5oFbvQO8DczftlYkPUnURnisRdofmCoZNNe9/4AlpmBks7kONxwQqPchxXZ1KPLvOq454sdfkBL+nACfw0QNYoQKdh8sxh2yXtAcqtgmSimeibMh+jdVM9t/RxTkAVKu0tD9S25Tf9+DtkOQERrJQvjKvwRoSH6Xp5ZaZRSK5QKJOcGWfxJ8i0Ckf6d3zPysQPTE+P7ErC1fr8id06T8wqF19/e34Pss9813QF2Vio7WFKtutvviF8hQGOE4XbLw2kLsabJlqCzTJhG6ya9/TGXTIuH4IVgWFFVmnVZ45ft1npl6E2PlybHsWIZP5EY4tDjYdqA/ljvfnPh6czz5D4YObj25O1LastVW81/rHJweFsHkuZPQhNPcUxL/M/4gD9kt6BZDRCQQre8K+oh6FPce+pBW+7+xMezZjyvDCtMZlPn19LOdLCK+OfCjAVWsshNRRUD/a9zOsdhEOq3TTB3pB0CrjC7EvRksj3BZXlrhU/YXQi0AYInybBxgJgPJhHtY7s36lg4QBRaNerdbark17/OPB76yOy4t0Y+2/Fdtu3de8dNX/h79yyXqqAwPvZpNfG6YlQYO+puFukxezLgdeL7CumbsjHnrqZgKiJEeawT+2tP7azSjEvD7Gzp4jeCuxY gxGVZWWI bQPSUc8DLCtP8tzohEKfdi86D0TBNVtOKbTriLt/4oAgbl3HdVVleJEPTmllKXmZVNXQSNC01l+b42k2N0RNb1ZRe77x+Tzr/gPPP/abHmbJLKnXCv75nqzy+2H0IG5KHw4yVQutSyXgwF4Vfvi9cQaZfCVYKLX7o44FEUCxl+yGYlReBZwUnSuTItA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 03:39:06PM +0200, Peter Zijlstra wrote: > + /* > + * Encode the futex size in the offset. This makes cross-size > + * wake-wait fail -- see futex_match(). > + * > + * NOTE that cross-size wake-wait is fundamentally broken wrt > + * FLAGS_NUMA but could possibly work for !NUMA. > + */ > + key->both.offset |= FUT_OFF_SIZE * (flags & FLAGS_SIZE_MASK); this wee bit should've gone in patch 9.