From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337C5EB64DC for ; Fri, 14 Jul 2023 15:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C33ED8E0007; Fri, 14 Jul 2023 11:10:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE39B8D0005; Fri, 14 Jul 2023 11:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAB248E0007; Fri, 14 Jul 2023 11:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99B128D0005 for ; Fri, 14 Jul 2023 11:10:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 55E718028F for ; Fri, 14 Jul 2023 15:10:00 +0000 (UTC) X-FDA: 81010552560.26.42FC5B4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 58B2510001D for ; Fri, 14 Jul 2023 15:09:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uTP4jZTQ; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689347397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gtOHiVU4MC1CWYa2sukSd0YzsCkfXWPduX4uiAi2UOQ=; b=mTKiMTQKwiz5eFaAEtfkKhGTSC7Pi7DoZ6uil7aGuYer4sl86IIrCPOmOshkn5HM1noYmZ z5kq0H9rgt1eDoZ0Q/BNr7RWlBtUCYA/5YYSaJKB/Ar7u4OUAMcdlihbPDmZSYvUb8lsmG yI2OdJFYUaWOhFtqHQm/XhjIhw5Mzbg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689347397; a=rsa-sha256; cv=none; b=yNwcn8cbvqHlYafc3YXKi/604wGJrzzxcDLRWcm1RA1hNAEbyAZOhgl9+h/CU1sfQP9aRZ zXQXiSopnxg6j+1LlEgrddU+xbWVz3OvxbzokkpeMvwnfgvbwdYy5EtGE9h2A58cncrEM5 +6K2INUnTuhxP3oGAQhaQDYrRdhRx4s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uTP4jZTQ; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gtOHiVU4MC1CWYa2sukSd0YzsCkfXWPduX4uiAi2UOQ=; b=uTP4jZTQmOWrVidF24KTuuVnua CFMjO/OR3oKBLtm81FmuxrP9w7NjbluwYP6YoVUnxAqTqTNJTzTQCXouHqGmcVgBaMvmC4NqvbFid yJSd4i8J+R5ZryZOH7mjHHnnnABU9Uk83/1wnAseadgJ6qVSzn1DPTYro4vJg1p0mmFybt2cQrrEb Bg+wENmWT4UgOrO3NWWXaTDivThenPExGKStEB34YUXnGaNmSVk4EKvkzL11QeSuBaaQXcRb/gJ6a 7/ax+cP8dfUZ3VSPfMpQpP9wLhzIgytCJVXV4h+oVA/Z9BY0Uh3NVQzGZdM52RBdGDaQ+dfr26YAY 831RyStg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKKQY-0019L5-An; Fri, 14 Jul 2023 15:09:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B4CAC3001E7; Fri, 14 Jul 2023 17:09:48 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A47292BD04925; Fri, 14 Jul 2023 17:09:48 +0200 (CEST) Date: Fri, 14 Jul 2023 17:09:48 +0200 From: Peter Zijlstra To: Matthew Wilcox Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 05/10] mm: Add vmalloc_huge_node() Message-ID: <20230714150948.GC3261758@hirez.programming.kicks-ass.net> References: <20230714133859.305719029@infradead.org> <20230714141218.947137012@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 58B2510001D X-Rspam-User: X-Stat-Signature: 7shpz779afaakrszhqiwjc3bzu6xhg35 X-Rspamd-Server: rspam03 X-HE-Tag: 1689347396-756574 X-HE-Meta: U2FsdGVkX18ae1C5J8o2CSrrbI4jgDOYP0/g0xsD+hBVt5T/epSfCA6n93ea/37+0lANa8KcbVcnQDStg7z1cl/vZVKYP7X48ycvV440FuWVQy2m+lIbkB9ZzemB4zyyxAA0JNzVSvAtP8onj7l8dunMDEvO0rSU9D9jCTrEV69ooe0wv2Fo9CPxfKYG7GgCYrBzsFasOrMrQh2OJUWXseGsAxQyaQcD7fG5f1M7lhtSl9UtZqmyQWV3wJHibTbkj/i3WUbrfEoVoOE8jYDCKBbeWPZBfQMndlwZqD4OLzo1OqYO8fBVxOFuhqH2+1LpXGs2NmEPNPEPrrYEXxPBfVupbxXaAEaa30BHsSnG0JOnpP9iJhtBw3eJSdg9C+/DDYro99cSO2F2TgpPy9Kxf49hPmxv01BHyTnqAWV75y+HEhZ3DU1rq1eL9ysSm1M2ynL4Cvx2sJK5kKo5mC+HJacDwwaOnVwDfHJGyR1LnVLoo2dTMb7Klb+dp9ghnXm5G2KgVK6Zf/89DXlbE2OjFkXAMKrvHpMDnDAN6zNI0czW1g3dtTD5YygNkCEA8Sd62xQUZJea6YYcZEzdSvGHfzZPvnVeOrHh+uMsok+Qyv500UYB1lkIg9pIGRHTqsUKd3HJCtnIkwHYJ/Hzy7LGkugoy6VLTSDD6tgyAo7dr0i5bxj4yPS+YgHLBPAOs1Oa8TD1eq9IfJoEitDyGZRhSLVaA5+DnYHaJU9UzpzpMS92k9wpTJC6robGsw/YrPfIYJL/EIuRNL2tgCmUqB6VrdbWkhm98fFIYwSjWsQ9pRoogz+8sWbJPCZy+XFVKPpk3igPlIy2W+XVqC+uR0U27C/706xeH6C2Omonj9zKGe47sIukGRrN2ONl1/GzH+eRDJdeUQRyqv7DSqJCN4mXyUVWewKi2kqKaaZT17IG0xP8jh5h6f2Ni3FSj1Q5Xuyb79Y/IkFUvTYzK+S+wf1 CAAyUCuX Et3Uzo3qWo91fAyVyO8ktdhqSWLcJDowWdO7QugCP92gH6jLITorSCL0vdTrt0drbaDnJkoCi28nGZuMh8qGufVMh/nCbqP7UaWjKRkELgIPWkkuFCXZfFWr9nsRLWAGQYbQuTFfmUhPLNHpgUPC1xi6FJM6JYON/wZDMknHe/n4b+E5hpB4rl6xWGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 03:37:38PM +0100, Matthew Wilcox wrote: > On Fri, Jul 14, 2023 at 03:39:04PM +0200, Peter Zijlstra wrote: > > +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) > > +{ > > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > + node, __builtin_return_address(0)); > > +} > > + > > /** > > * vmalloc_huge - allocate virtually contiguous memory, allow huge pages > > * @size: allocation size > > @@ -3430,9 +3437,7 @@ EXPORT_SYMBOL(vmalloc); > > */ > > void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) > > { > > - return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > > - gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > - NUMA_NO_NODE, __builtin_return_address(0)); > > + return vmalloc_huge_node(size, gfp_mask, NUMA_NO_NODE); > > } > > Isn't this going to result in the "caller" being always recorded as > vmalloc_huge() instead of the caller of vmalloc_huge()? Durr, I missed that, but it depends, not if the compiler inlines it. I'll make a common __always_inline helper to cure this.