From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58ADDEB64DC for ; Fri, 14 Jul 2023 14:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C14838D000D; Fri, 14 Jul 2023 10:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4378D0005; Fri, 14 Jul 2023 10:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5158D000D; Fri, 14 Jul 2023 10:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A037B8D0005 for ; Fri, 14 Jul 2023 10:47:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 368E71A028E for ; Fri, 14 Jul 2023 14:47:14 +0000 (UTC) X-FDA: 81010495188.07.98BBC4C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 4E25B20016 for ; Fri, 14 Jul 2023 14:47:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uV5iXkqt; spf=pass (imf03.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689346032; a=rsa-sha256; cv=none; b=jbhBozNr7TABOj3G/AZhSdfK4KB+RaaKLS+4qHUNwwSgB7jDjHvpMBD6N8EyBuL/P78igv bVP3vpl7vKM6IaDrvMByH4CN7/nzQmA9f61s01uMLnKXitF34QMA5NlcihoSjruQj+thYt R6+mHg+u5ApPRUhV7oBFEmp9V+xV8rY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uV5iXkqt; spf=pass (imf03.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689346032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wp5Zk5S61SxSKXRrEY+vTUUI7RIzpwA4bdH1AK+8eR4=; b=FfcWIH0v/OdYYolF7D1Ak1lf63VLg3SDesQ3ZPa/sqfEu6RrvHtm8zOew9C2M3ZvPgLTSu LdvGFCxRkl9aKgOoQQMU1m0jC6XFn2HiNw1vlhWdouZVak9XZIJeAuRqk+iR5VqKvyBheq f0/1XOhuC2bnHq00d5MXkyIxn/yyBMU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5448F61D0C; Fri, 14 Jul 2023 14:47:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F29DC433C7; Fri, 14 Jul 2023 14:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689346030; bh=EhD/bbD6rSZ0Rr8iRGRhHlJ1FD6NXZFUv8qieGqgkBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uV5iXkqt76fT7a1Ei5ERHdRaW3G6/ZV5i4erACo4ym+fMnDmNPPXxPJQjxyt5Siwm W8Xxzo2L89g0SahW5A3oAqrNoL9461fnugsSeJ/bkRgWEFnk1Z1js8EqsqmrYPoHmR VQuC8L+010VawgRmR0tcbFCqMXXFX4TD9F8o6JVAZniy1Pf+NWa/jjsTUCnKwae/ZT CFE+I18s41kTMozQx9C79Tu7gVp5/wmrL5I14t8lJLq2u50WdfRBuPUDT5jg/txVzG hApAU3L2A4Q7+NNOHbCr6DQ+6snf6UwfXwi1reDBAQsBKxlmNqGCsWVMtN3iMiNCvf oDIKb5hYrPNcA== Date: Fri, 14 Jul 2023 16:47:05 +0200 From: Carlos Maiolino To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-mm@kvack.org, djwong@kernel.org, hughd@google.com, mcgrof@kernel.org Subject: Re: [PATCH 5/6] shmem: quota support Message-ID: <20230714144705.hajnvnu72vokubri@andromeda> References: <20230713134848.249779-1-cem@kernel.org> <20230713134848.249779-6-cem@kernel.org> <20230714-messtechnik-knieprobleme-5d0a3abb4413@brauner> <20230714122644.l6g4wr3jb7fmkf7x@andromeda> <20230714-beklagen-betrieben-6e0604c8c05c@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714-beklagen-betrieben-6e0604c8c05c@brauner> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4E25B20016 X-Stat-Signature: rtrm9hzzzf7tj9nc81nsdi34j7ca195e X-Rspam-User: X-HE-Tag: 1689346031-988760 X-HE-Meta: U2FsdGVkX18zG2RxBe2v1TqJ3/QPSAc8UX9122u6N7YNb5mPAWzw5oYL0ISPK7p4xzKZ+L3FzRq7WWn9VOXaMd0a3iUjpIMfDI+qZ5qjPbZwkaRtltqSAOCvreKHvm96Dq6b7mUBb3cbbfxW9irsxzGobvV7DphYMIq2btPWQ0imQw3uA9Vp7Ocn1hPciPR7e6VdmRWoPn4+WY+JDW2twBm3tDU5OT/0ew6sH2vDmeiJfvxQYQQNPe/BXO+8dIPRSIcINPMkpxw6I6YsqiCyvE4eqlwwKo2JkslHVdc3TBwZAlmoVEjB68+D+VRmI1sg4mfrS9mo4cleyB6iZtHSd+zvLCz6ZC5DO0R1Syn4Dm2g40keUVfqaOrw6qriLa7bL89LWyfyJ7Xc0K/2kjmI5wsHKwX6goTD168zCBfRYc1649wN1EXLw6H1iXQX/UeTw5vUR64hjoU1GxeSU/GXWx1QGKHg7cSw7gvxtLvukPWZ1fnvNU82ufGd91/TAGUx1BVq/iZe7hY7YarXJOOcXAP4CzI0Q97t3mOrXzkEVwOURkmVNZ2elVohbUjiONZcxaMpPwbD32QN91XPnNkoN6vmAL1pHKkxxleFu2CngddsqT3BTo+FZeK2FuIoWnBR7RWx5HJuWz4LCpf9CzUUM0NtlXwA8bxXPXByymxrkM94WiZXyRV++GLzUQfMpX2eM5PV3z6g6/0nAWhNSlb90utVrkkSOVDMPkB5ABU4ahMiPjWY/yuZGrT9e6SZheYV6IR8d8xNmhU7PeawispS4c9gO5Gf5VHP+3a7UkToPY5n0jGM+EQ6AgnDb1Eb0JSvbuN3jrmdCwiNc97t4a7tPuHZ4IGwihpbhVgKWymZhkYMeb01JZqat3hjsFaPjAJkIa1WF80J8yNfOo/zh0crXYHH6wpMO9/LG94Q4RGIzREYhamKW/6cc++kOU2OFRPny0ZPckM4KTmm2t4tT10 tV9zPdiF 02UGDImzKDyQwpks7nzO/08CMnsHyyeWqLus4K1S/6xoIRKNVo3ObOSMaH7zAOrsBkxGqZD3XcePdO7/TcLedXaLKcT8qzLeyJz6UQSBwBBEgDiEaEMRREZvgb8wWvQ/e621oftdOCe96zKYMtdxMHUrU91YY6xLYKiyNWzprSZmp6hUHLiC4q6KggjqGGaH+4pp53J9MYGkQZJ8pen+sEondq2RCE4FRFulFU8Ei1vEu+YCeZdef7O6cz3yKYKJFqw5oEYtdKAtG4dAdAbO1c8Kz1r7sBiLEZj+l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000591, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 03:48:12PM +0200, Christian Brauner wrote: > On Fri, Jul 14, 2023 at 02:26:44PM +0200, Carlos Maiolino wrote: > > > > > > > > @@ -3736,6 +3853,18 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param) > > > > ctx->noswap = true; > > > > ctx->seen |= SHMEM_SEEN_NOSWAP; > > > > break; > > > > + case Opt_quota: > > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > > + ctx->quota_types |= (QTYPE_MASK_USR | QTYPE_MASK_GRP); > > > > + break; > > > > + case Opt_usrquota: > > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > > + ctx->quota_types |= QTYPE_MASK_USR; > > > > + break; > > > > + case Opt_grpquota: > > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > > + ctx->quota_types |= QTYPE_MASK_GRP; > > > > + break; > > > > } > > > > return 0; > > > > > > I mentioned this in an earlier review; following the sequence: > > > > > > if (ctx->seen & SHMEM_SEEN_QUOTA) > > > -> shmem_enable_quotas() > > > -> dquot_load_quota_sb() > > > > > > to then figure out that in dquot_load_quota_sb() we fail if > > > sb->s_user_ns != &init_user_ns is too subtle for a filesystem that's > > > mountable by unprivileged users. Every few months someone will end up > > > stumbling upon this code and wonder where it's blocked. There isn't even > > > a comment in the code. > > > > I was just going to rebase these updated changes on top of linux-next, and I > > realized the patches are already there. Wouldn't it be better if I send a > > follow-up patch on top of linux-next, applying these changes, as a Fixes: tag? > > I would just resend and fold the fix into the patch. There's no good > reason to make this a separate patch imho. sounds good. Thanks