From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C907EB64DC for ; Fri, 14 Jul 2023 15:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93BC78E000E; Fri, 14 Jul 2023 11:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EBFB8E000A; Fri, 14 Jul 2023 11:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B3728E000E; Fri, 14 Jul 2023 11:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 68A848E000A for ; Fri, 14 Jul 2023 11:57:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28D711602C0 for ; Fri, 14 Jul 2023 15:57:31 +0000 (UTC) X-FDA: 81010672302.10.3D53927 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 59EA740014 for ; Fri, 14 Jul 2023 15:57:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KLbopqqH; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689350249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=De+i/fCpRCuXDkXt+y5KyKe32OHMyHDlQnjdsKLwczw=; b=PRceHGT50TrMQqw1ttK1qVn7qq84BBoUTHYkMEY55ZthiwJmTna6eAqubam/71zKdt+LnI RMBZ/HldQPohCXoisULkiyi4m83fUYEG/bKfVvVQaiVSXcNgCGtsup8jrvXefPU5fEiO/Q +jpDx/4PpyfjhVyKHXLjEfu6tyfiGC0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689350249; a=rsa-sha256; cv=none; b=bOsExSgwPTiYGoTAbIqNkiaVbAPBVbRXzCAlRnaWValvUyhLFx6uWaWp4WyVP/HBX5SCeh jMJrKS0t2eCWKVbHDtgfonVfpUmQwF4M+P9UVx6sgQe3FhyMfGWZmXm3LZlw0auYrPdrm+ 4Bz2AIIO+N56yCUwYl0bSgSMNtX15bI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KLbopqqH; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66E3A61D30; Fri, 14 Jul 2023 15:57:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84F4BC433C7; Fri, 14 Jul 2023 15:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689350247; bh=lwc2mqtMamKbQhuz7C+HFzR/YjxrhWRQte11nnNxhgg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KLbopqqHwf7VLeiIZrQB/ZCljR0ODPzFrSOjaQtfHAumIDfVbBsWu7HipSsaCmdvM KjA+Tp9Eiwro5yj8zQmkWFnuT28AplKPWV+Pjy+UixKC0PaoPNccd8ljmePwqjXrYA cIlvyQKUsh2n/HCABEEKP2cd3t0u2OJ39vovfJG8= Date: Fri, 14 Jul 2023 08:57:26 -0700 From: Andrew Morton To: kernel test robot Cc: Carlos Maiolino , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Lukas Czerner , Jan Kara Subject: Re: [akpm-mm:mm-unstable 161/178] mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty' Message-Id: <20230714085726.4b015152cd5b5182250b2a66@linux-foundation.org> In-Reply-To: <202307141341.R961dyMt-lkp@intel.com> References: <202307141341.R961dyMt-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 59EA740014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nmfo35cufggdaxychh7az8ti39tdrosc X-HE-Tag: 1689350249-993796 X-HE-Meta: U2FsdGVkX18edvHk22cMMt8eiHEkEKukFTaxW3NEXXaEjGIG+/ic2YtiMN4jUirlxHrKFmDeD5ka9pxyA8MaRdo1T6P/WZyQHt8lqVVY33iOFsK6trhE+AX4BGa4EOaa6RlFw1imgxe5iYqYw890Wi3W5XmGgLoX9NMbwDRJcojq0Al9P3GnmvZKiVF44HaKy1kF7WeDiwHDpEHFsA9nOe3yTapd4hxx5WjyHKstvxjD7Du8cAKP1Y6wF/VYZO8FzhQx5qrkWHT1Jhl7P+Jbgfpk+14LHfQDUd7+/07chhNtv3w9IrjQAHxA0M/jsk8dICZ/rYvMV+a17n/xgr2FTOEm2w3V5vga4+p0L3z72uWttpEmLtj/IuXUi1z+HYMQYKuKRIT7OsgbfyI/LNnGCDIb7A+GfpQs90lqBrzzCKSCIwSU9DRoLtpDD87Yh6xv2jz7iXvVTcQMSwXtareGtivvkmksKqx5pF+Mv+DI5tRxQzNygnFlqALSbqboIAj6QLFimGd/rKYgR8OGIpQSxQnxHJ1DKjFk/qWwjeu3URzi0BcOoOwmAziZPMYlax8d1pVPFtzXqSwTFvngJsTgMy/7B9i40iYY5rkEq3eGR98kOoBt0633B0qFYkao76ARHr87LXUwD3qzgpDHkJXzXKaZ+aI3yOaUSMxn7/J0qFVWJSFLy1V3g1QID0rvNnOeO4IArYfC0sWJhww4SLgSUG9GqZ+1IEKBcfM7rCmNbN6oz28ciAN1RwW90tvUdlVI/7Km1GxeiVVvs5FcS9JTD5JdqEy6fIcYshmDYQikBsqN7mBc9CM2IiG6JwWXkfF2FwKb3Ati7ejc7PQIinK44s/SRsjfF4dfArLKDKttPailrISyTfIn3kmqCsnSRqf2OJCOygb9fLYwW/suaadLQyVhRqpa5wXpoA0pn9hee8h4ZmdenROjcjcQQZf+5tVFOWaO6dQWHRNvqSRsoLr yg2volnK 87EYw+WIxllhSoZVTh3v+63ahbXe7d039u4XUwVUggSZ8JFbo62v3VDqjufuE+hTFqHoq/I2XV8CuOkcN4YXUx5udcIwoVS7R6gdm3Y1V11Z7SgPjixC9/YnjeumHhXNef83a79M6HaMqYA6nBDoHwWywntpa+0MfhDVIn15HVf5m3b8SD3sKXm0+c6Sh8dj34b+s5MWgT1eJbT7CtMyB4BKrH6jh/66IvMcvqzS+M4YifaIVDeshyfJkE6I7peu+OhiuTuYmzdDzka6I0CgYSh9k+8Ga3VWFAQDnIgga8CdjYPjQzLXrFOgm0AXE5mpyBw7UI3LZN8okpWFKpotRY3mucThUm7698P4O6HuHszOvkhONqzYoMAlz5LxoLTANX+BjwmQ/I+uIlmSbA7varKv+gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 14 Jul 2023 13:10:19 +0800 kernel test robot wrote: > >> mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty' [-Wmissing-prototypes] > 286 | int shmem_mark_dquot_dirty(struct dquot *dquot) > | ^ > mm/shmem_quota.c:286:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > 286 | int shmem_mark_dquot_dirty(struct dquot *dquot) > | ^ > | static > >> mm/shmem_quota.c:291:5: warning: no previous prototype for function 'shmem_dquot_write_info' [-Wmissing-prototypes] > 291 | int shmem_dquot_write_info(struct super_block *sb, int type) > | ^ > mm/shmem_quota.c:291:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > 291 | int shmem_dquot_write_info(struct super_block *sb, int type) Thanks. --- a/mm/shmem_quota.c~shmem-prepare-shmem-quota-infrastructure-fix +++ a/mm/shmem_quota.c @@ -283,12 +283,12 @@ out_dqlock: return 0; } -int shmem_mark_dquot_dirty(struct dquot *dquot) +static int shmem_mark_dquot_dirty(struct dquot *dquot) { return 0; } -int shmem_dquot_write_info(struct super_block *sb, int type) +static int shmem_dquot_write_info(struct super_block *sb, int type) { return 0; } _