[akpm-mm:mm-unstable 161/178] mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty'

[akpm-mm:mm-unstable 161/178] mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head:   6936d35dc558257b576113c74b586074dd942e9a
commit: 1eadb10f211346c9baf6daff1be3890f072ffd82 [161/178] shmem: prepare shmem quota infrastructure
config: s390-randconfig-r012-20230714 (https://download.01.org/0day-ci/archive/20230714/202307141341.R961dyMt-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230714/202307141341.R961dyMt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307141341.R961dyMt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty' [-Wmissing-prototypes]
     286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
         |     ^
   mm/shmem_quota.c:286:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
         | ^
         | static 
>> mm/shmem_quota.c:291:5: warning: no previous prototype for function 'shmem_dquot_write_info' [-Wmissing-prototypes]
     291 | int shmem_dquot_write_info(struct super_block *sb, int type)
         |     ^
   mm/shmem_quota.c:291:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     291 | int shmem_dquot_write_info(struct super_block *sb, int type)
         | ^
         | static 
   2 warnings generated.


vim +/shmem_mark_dquot_dirty +286 mm/shmem_quota.c

   285	
 > 286	int shmem_mark_dquot_dirty(struct dquot *dquot)
   287	{
   288		return 0;
   289	}
   290	
 > 291	int shmem_dquot_write_info(struct super_block *sb, int type)
   292	{
   293		return 0;
   294	}
   295	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-unstable 161/178] mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty'

[Andrew Morton]

On Fri, 14 Jul 2023 13:10:19 +0800 kernel test robot <lkp@intel.com> wrote:

> >> mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty' [-Wmissing-prototypes]
>      286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
>          |     ^
>    mm/shmem_quota.c:286:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>      286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
>          | ^
>          | static 
> >> mm/shmem_quota.c:291:5: warning: no previous prototype for function 'shmem_dquot_write_info' [-Wmissing-prototypes]
>      291 | int shmem_dquot_write_info(struct super_block *sb, int type)
>          |     ^
>    mm/shmem_quota.c:291:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>      291 | int shmem_dquot_write_info(struct super_block *sb, int type)

Thanks.

--- a/mm/shmem_quota.c~shmem-prepare-shmem-quota-infrastructure-fix
+++ a/mm/shmem_quota.c
@@ -283,12 +283,12 @@ out_dqlock:
 	return 0;
 }
 
-int shmem_mark_dquot_dirty(struct dquot *dquot)
+static int shmem_mark_dquot_dirty(struct dquot *dquot)
 {
 	return 0;
 }
 
-int shmem_dquot_write_info(struct super_block *sb, int type)
+static int shmem_dquot_write_info(struct super_block *sb, int type)
 {
 	return 0;
 }
_