Re: [akpm-mm:mm-unstable 161/178] mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty'

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 14 Jul 2023 13:10:19 +0800 kernel test robot <lkp@intel.com> wrote:

> >> mm/shmem_quota.c:286:5: warning: no previous prototype for function 'shmem_mark_dquot_dirty' [-Wmissing-prototypes]
>      286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
>          |     ^
>    mm/shmem_quota.c:286:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>      286 | int shmem_mark_dquot_dirty(struct dquot *dquot)
>          | ^
>          | static 
> >> mm/shmem_quota.c:291:5: warning: no previous prototype for function 'shmem_dquot_write_info' [-Wmissing-prototypes]
>      291 | int shmem_dquot_write_info(struct super_block *sb, int type)
>          |     ^
>    mm/shmem_quota.c:291:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>      291 | int shmem_dquot_write_info(struct super_block *sb, int type)

Thanks.

--- a/mm/shmem_quota.c~shmem-prepare-shmem-quota-infrastructure-fix
+++ a/mm/shmem_quota.c
@@ -283,12 +283,12 @@ out_dqlock:
 	return 0;
 }
 
-int shmem_mark_dquot_dirty(struct dquot *dquot)
+static int shmem_mark_dquot_dirty(struct dquot *dquot)
 {
 	return 0;
 }
 
-int shmem_dquot_write_info(struct super_block *sb, int type)
+static int shmem_dquot_write_info(struct super_block *sb, int type)
 {
 	return 0;
 }
_