From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF007C001DD for ; Fri, 14 Jul 2023 13:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1AB46B0072; Fri, 14 Jul 2023 09:48:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC6316B0074; Fri, 14 Jul 2023 09:48:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B66AF6B0075; Fri, 14 Jul 2023 09:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A17CF6B0072 for ; Fri, 14 Jul 2023 09:48:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5C54F14028A for ; Fri, 14 Jul 2023 13:48:21 +0000 (UTC) X-FDA: 81010346802.05.0448660 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 9022620007 for ; Fri, 14 Jul 2023 13:48:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kcFsybz4; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689342499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BjECjXUIPK9ERcVmMb05g9DmbsJMYDrtZ8KuPXJNgZM=; b=E3PAJczbRZcpkbveORJ/uSNPGJobGErXyiRHIr1pG+ZWHfZsEgzq30vQbgvjnJrawCItTQ KDNsBA3TPT5Ko46QD/Z+7QvCrjfrGPZB8ac+nFYvSf2hEI+z6ydoJH0YxbemqwWC5rSZvA KOIlvrjTzzDBwjwzt3lJp/XIbPAW8mk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689342499; a=rsa-sha256; cv=none; b=IuzISWU/6f0dfGLHTG6MFhW2apJeaonVbZDBpVBf7UokFq8pWoEdkg9bY2e++T4xEBeBCP Y1sshKV6TU9VBrIxSF+onA4b3B+k8Sst7dDHGphnW8VGzQJowc1AUVlW2eLOksEKf7M68z MkaXtsFpfU0Ay0O5r39+hJu4SzGHsMU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kcFsybz4; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C3FD61D2D; Fri, 14 Jul 2023 13:48:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3EF0C433C8; Fri, 14 Jul 2023 13:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689342497; bh=VaLLECC2MakW9vk9LxBIZ/hwDNBRooWwJVGfNHyf2XQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kcFsybz4iussO/zOBC82QoGpXSIelUgA6mZhTehKezzA5HJc4dWTcJFQxBJLEcrHF fCYSjKoPOzgIi/jbFKcdPAq1hGte4FwgqPUHqwmjSQBJvn4a0K1nBO+fabwAM0fXlG O0T1SHCbMsJbvvmC3oKctn74VBH2XxCUujQekgIqWWJbhZGaV2CLk3NSaTZvuSoWAH 1yU1hyGQzjISNQUY+0JeFKxT8RO7KaJWPMb8mAtpyvqdI6lA68JYKbxAhZij/JVjvx kxJCmPyR8zDkB9nDQz5pHNFhfI48HLRERBf9csl5pm6KplcWZr7hu3Ol4+/ly7BuNZ mE9NItZ1GP+LQ== Date: Fri, 14 Jul 2023 15:48:12 +0200 From: Christian Brauner To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-mm@kvack.org, djwong@kernel.org, hughd@google.com, mcgrof@kernel.org Subject: Re: [PATCH 5/6] shmem: quota support Message-ID: <20230714-beklagen-betrieben-6e0604c8c05c@brauner> References: <20230713134848.249779-1-cem@kernel.org> <20230713134848.249779-6-cem@kernel.org> <20230714-messtechnik-knieprobleme-5d0a3abb4413@brauner> <20230714122644.l6g4wr3jb7fmkf7x@andromeda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230714122644.l6g4wr3jb7fmkf7x@andromeda> X-Stat-Signature: jept869w7x46uqkhgtkmf114stms8tit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9022620007 X-Rspam-User: X-HE-Tag: 1689342499-295770 X-HE-Meta: U2FsdGVkX1+Is7a7ux/SYtXFUWGGg3bgy8RBx3Xh+wQAGxB/0QyEQooZlewV6b2rfhcBnruadXeGGDb7ixJbNCBOc4nlmCJRCDOBn9TfOHP9+mi0h7NtBb3tYaoDDICMMkA9fDA+oxNthqvgeHYIrs1AeLL1Z7hC8u0iwAzz23PJmVh/BRUmimgdtaYUIrzOqleU6R/9rAGD1+cxuZIty4IFfyChQr8T69bju2EnZEJgausAgvbnT3anbF/ws6e9WR3VxKRthpnaiXM+caOUSqBeED1YdfmDRxERTwc8zbb8YX/n1unNlabirw39XtYFfjFqj9MdIo1XyPK1VvX2zAXeUCnznhXdgJ2fnusQNdJqmnAg59Hut+WUshb1I5hP6O8xBL5X93KdflNAz4mZwWEsVWD2+Ll+V6HeG/szx2p4Ms7C+/nakXYCjG6e7HrJTUPx1e2mjmpCpS0bGs9C8T/ODKhYp7e12dj0wY95oSDQS49XTFLJI19ZewBsyjRO51r0IqIjkVXRG0ldt3/keUlm/eNt8DYVlvS+1xpdRVjqfWLhhkp1r5rTtpU+CrkzayrAbKCk40jnYPd9PbOUX5t6qzRVKfBV85PSpJZzbJlR70evxDoPinEEWMZzIh6Mla2vrwWT9kHvv5ZnagbD9ALLKMMXXiukavdj3GIHG9IFp6eqkRWVe0alxPpkfSgVmeOuAkVGKnlD3G97cTU1nbYDRWbXIprg0mPANV52GVbZ/uO/qLWsNnGAzgoPcvbLMx8l2vdTZ3ryd5fjauZu4Pg7rLHFMAbLIh7l72VqnYwpBKnfhr1iclIypahbymFvwhaGKNe0yqrgIyjVjuVv9XdWiS6yMOnrNVq//sHjfFIRhJogg7W6OF75rohc016XreP8aFZgaPcsd9FRlqw9bYKGDFyodW3v4WASvHqsnywpkZfWNRjstC9t+/DmIrPZ7sWeQQmBwrRaWmtwPJA Bfiq3kHx 7wquXPLUjmeEIzupJFMeHc+p1sRs7k5FF5QIspF4tklKeXtNCCTlbDC+ws+A5bgirRK9mBCFvvPy0d29GY6QxBZl0OVpcXzzdETgHixPddgH3whuGNoZIZayw+FBFLvO1PiQiQEgcaT0c0VQodFn2OO1QB3SOaYfTe3wZi90/THBRV6eoVTJpDj8vhb/DtnmLw1DZdtzfYamn3iPWeQE3m1d++T7IoKJXlnf8ZL+1hqGmf7g7ofpoKo6+RWog8zJLPsJGAp1cr0BB63C5ADxORIFhSv2s3KtMQl60 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 02:26:44PM +0200, Carlos Maiolino wrote: > > > > > > @@ -3736,6 +3853,18 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param) > > > ctx->noswap = true; > > > ctx->seen |= SHMEM_SEEN_NOSWAP; > > > break; > > > + case Opt_quota: > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > + ctx->quota_types |= (QTYPE_MASK_USR | QTYPE_MASK_GRP); > > > + break; > > > + case Opt_usrquota: > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > + ctx->quota_types |= QTYPE_MASK_USR; > > > + break; > > > + case Opt_grpquota: > > > + ctx->seen |= SHMEM_SEEN_QUOTA; > > > + ctx->quota_types |= QTYPE_MASK_GRP; > > > + break; > > > } > > > return 0; > > > > I mentioned this in an earlier review; following the sequence: > > > > if (ctx->seen & SHMEM_SEEN_QUOTA) > > -> shmem_enable_quotas() > > -> dquot_load_quota_sb() > > > > to then figure out that in dquot_load_quota_sb() we fail if > > sb->s_user_ns != &init_user_ns is too subtle for a filesystem that's > > mountable by unprivileged users. Every few months someone will end up > > stumbling upon this code and wonder where it's blocked. There isn't even > > a comment in the code. > > I was just going to rebase these updated changes on top of linux-next, and I > realized the patches are already there. Wouldn't it be better if I send a > follow-up patch on top of linux-next, applying these changes, as a Fixes: tag? I would just resend and fold the fix into the patch. There's no good reason to make this a separate patch imho.