From: Kemeng Shi <shikemeng@huaweicloud.com>
To: pasha.tatashin@soleen.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 5/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear
Date: Fri, 14 Jul 2023 01:26:33 +0800 [thread overview]
Message-ID: <20230713172636.1705415-6-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230713172636.1705415-1-shikemeng@huaweicloud.com>
Remove unused addr in __page_table_check_pud_clear and
page_table_check_pud_clear.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
arch/x86/include/asm/pgtable.h | 2 +-
include/linux/page_table_check.h | 11 ++++-------
include/linux/pgtable.h | 2 +-
mm/page_table_check.c | 5 ++---
4 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
index 5d71f933d933..f07c610c3458 100644
--- a/arch/x86/include/asm/pgtable.h
+++ b/arch/x86/include/asm/pgtable.h
@@ -1144,7 +1144,7 @@ static inline pud_t pudp_huge_get_and_clear(struct mm_struct *mm,
{
pud_t pud = native_pudp_get_and_clear(pudp);
- page_table_check_pud_clear(mm, addr, pud);
+ page_table_check_pud_clear(mm, pud);
return pud;
}
diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h
index 0f777bca5283..5c9dc848a1bc 100644
--- a/include/linux/page_table_check.h
+++ b/include/linux/page_table_check.h
@@ -16,8 +16,7 @@ extern struct page_ext_operations page_table_check_ops;
void __page_table_check_zero(struct page *page, unsigned int order);
void __page_table_check_pte_clear(struct mm_struct *mm, pte_t pte);
void __page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd);
-void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
- pud_t pud);
+void __page_table_check_pud_clear(struct mm_struct *mm, pud_t pud);
void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,
pte_t *ptep, pte_t pte);
void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
@@ -60,13 +59,12 @@ static inline void page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd)
__page_table_check_pmd_clear(mm, pmd);
}
-static inline void page_table_check_pud_clear(struct mm_struct *mm,
- unsigned long addr, pud_t pud)
+static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)
{
if (static_branch_likely(&page_table_check_disabled))
return;
- __page_table_check_pud_clear(mm, addr, pud);
+ __page_table_check_pud_clear(mm, pud);
}
static inline void page_table_check_pte_set(struct mm_struct *mm,
@@ -127,8 +125,7 @@ static inline void page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd)
{
}
-static inline void page_table_check_pud_clear(struct mm_struct *mm,
- unsigned long addr, pud_t pud)
+static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)
{
}
diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
index 3edef5ed008f..5f36c055794b 100644
--- a/include/linux/pgtable.h
+++ b/include/linux/pgtable.h
@@ -438,7 +438,7 @@ static inline pud_t pudp_huge_get_and_clear(struct mm_struct *mm,
pud_t pud = *pudp;
pud_clear(pudp);
- page_table_check_pud_clear(mm, address, pud);
+ page_table_check_pud_clear(mm, pud);
return pud;
}
diff --git a/mm/page_table_check.c b/mm/page_table_check.c
index 51f2274c0a20..2643135bf45c 100644
--- a/mm/page_table_check.c
+++ b/mm/page_table_check.c
@@ -171,8 +171,7 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd)
}
EXPORT_SYMBOL(__page_table_check_pmd_clear);
-void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
- pud_t pud)
+void __page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)
{
if (&init_mm == mm)
return;
@@ -217,7 +216,7 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
if (&init_mm == mm)
return;
- __page_table_check_pud_clear(mm, addr, *pudp);
+ __page_table_check_pud_clear(mm, *pudp);
if (pud_user_accessible_page(pud)) {
page_table_check_set(pud_pfn(pud), PUD_SIZE >> PAGE_SHIFT,
pud_write(pud));
--
2.30.0
next prev parent reply other threads:[~2023-07-13 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 17:26 [PATCH 0/8] Remove unused parameters in page_table_check Kemeng Shi
2023-07-13 17:26 ` [PATCH 1/8] mm/page_table_check: remove unused parameters in page_table_check_clear() Kemeng Shi
2023-07-13 17:26 ` [PATCH 2/8] mm/page_table_check: remove unused parameters in page_table_check_set() Kemeng Shi
2023-07-13 17:26 ` [PATCH 3/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear Kemeng Shi
2023-07-13 17:26 ` [PATCH 4/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear Kemeng Shi
2023-07-13 17:26 ` Kemeng Shi [this message]
2023-07-13 17:26 ` [PATCH 6/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pte_set Kemeng Shi
2023-07-13 17:26 ` [PATCH 7/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set Kemeng Shi
2023-07-13 17:26 ` [PATCH 8/8] mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set Kemeng Shi
2023-07-22 21:48 ` [PATCH 0/8] Remove unused parameters in page_table_check Pasha Tatashin
2023-07-24 17:02 ` Andrew Morton
2023-07-24 17:17 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713172636.1705415-6-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox