From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322C5EB64DA for ; Wed, 12 Jul 2023 23:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45B548E000A; Wed, 12 Jul 2023 19:54:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4928E0002; Wed, 12 Jul 2023 19:54:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2852B8E000A; Wed, 12 Jul 2023 19:54:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1501A8E0002 for ; Wed, 12 Jul 2023 19:54:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D0C90160406 for ; Wed, 12 Jul 2023 23:54:57 +0000 (UTC) X-FDA: 81004617834.21.68545D7 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf10.hostedemail.com (Postfix) with ESMTP id 06363C0006 for ; Wed, 12 Jul 2023 23:54:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jmbu3E9Y; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689206096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Se+J8BMBlZ7z7N8IwDTVCsMWBFzaqhftgKoOtqAN2Vw=; b=abtrspfr6zl3I0lFUssk67zE3SGFQEJXMQN+S3EU5w4dnk610/VrM5AwLo1EeDoIgdNb5Q WRWcKEAF/FBlPFT5GclLLM/q43D29a8sHCUiLog2uvyuSaSCetg8B1JjhNlb/3OPoPcTy2 xPqX7gzq9cGGvqRVfgcrwM0J9BF/N30= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jmbu3E9Y; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689206096; a=rsa-sha256; cv=none; b=0PYKjH7FjWvNoEyOBu/iZ1e+tkhSq8gu9BKlFlVZgvvwsNpSfpNiUgBNNDima9QTb21WC/ JZrwfYAF7R+pHErmg18kspsgBxM/ICpBXNboyCfLmmCFt4jYjRxVFkX5lu55dzmx/Mws7x UocgQn4+ZUNgTTpH986P4EGYZHzbAo8= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-668711086f4so45544b3a.1 for ; Wed, 12 Jul 2023 16:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689206094; x=1691798094; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Se+J8BMBlZ7z7N8IwDTVCsMWBFzaqhftgKoOtqAN2Vw=; b=jmbu3E9YYfWknUGb/cwYyFHkWhFyLsINERbOh19iOI27YCJ0rFJOanRa+GlZ3FzNOu 5LHgII8Xw19t8JhIaJgwJx44SOGDiNDgayxWodP8LNjgonKA9+xyDwr/cAeRG+M4tG4E PurMSQV2w2utcEtv8GySBO6M73oYB1FmVF8No= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689206094; x=1691798094; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Se+J8BMBlZ7z7N8IwDTVCsMWBFzaqhftgKoOtqAN2Vw=; b=JFKyySWf7GTZA7DEMNpdGuxKPA/dJDHBxy/hKvGxQhyHbpYOrbtgmE/aMzkv6zykCo 5h7l7ZHeR5/93oGj8sI1w4i2G5S56baZL6/AlprDluG3/8vPZJTrgNrQRAaP4OTYJ6z9 WUwYgfUEaVp1na4Ql7v1VFY8PPM78Sxu0zFIpeQAbK/fYM3cehzg2a2mPwZ8Pm8l2U3p OdmiCbzimax4WyqiHMQJIfk6XN473QZB4NQJ4nWNfl41vknm3llQNjykXDMQPcnXiFUN Dfwp0cSaE4zyeZSeDErPeRaVfCDyTJrlyaj+mNlBAAp1LlBGvu4l+dfaS0gewLD86I1k ZgGQ== X-Gm-Message-State: ABy/qLbGFpmbyzC55YkOzUn7uwZi4cnbR2M9em/LKP/rR3O7ktszemVh XPLxmHkfcOzuFjw06qXC5H11jA== X-Google-Smtp-Source: APBJJlHlNCamcVbfB5M6HLYNdZMLF6qk04LaC58OxarzNI2yzUPi6NLd/bcgqWvxJjN9YJIHYNvlnA== X-Received: by 2002:a05:6a20:1614:b0:106:9266:4448 with SMTP id l20-20020a056a20161400b0010692664448mr417583pzj.16.1689206094633; Wed, 12 Jul 2023 16:54:54 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i12-20020a633c4c000000b0050f85ef50d1sm4163719pgn.26.2023.07.12.16.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 16:54:54 -0700 (PDT) Date: Wed, 12 Jul 2023 16:54:53 -0700 From: Kees Cook To: Azeem Shaikh Cc: Andrew Morton , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] EISA: Replace all non-returning strlcpy with strscpy Message-ID: <202307121654.5F8D4C6302@keescook> References: <20230706175804.2249018-1-azeemshaikh38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706175804.2249018-1-azeemshaikh38@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 06363C0006 X-Stat-Signature: zetz5gzto6hf1nu1newdomtipbxmqci9 X-HE-Tag: 1689206095-368944 X-HE-Meta: U2FsdGVkX198huCtNGOYjPA+uEA17PknGsQmHlnjaI+dE+4ZnIQFJPEvzDCCfFnnAZwI+fRGx281ghnwN8qFsVK3xw/K17pJAatQLwPVrQryt+FTuv/wBk7MttGerT0IRf/i9khCpz6HXw6dP92ajYky5vRSb+8cur/4dvcUoFWn+DF2kN45G+LWQD8jSZ1yJuERFyASIDAAKc/2lR6QLjAomSrkkbUFtHhR+IRaD7QB1wZYB7Wog3EXZPrgszkJXH4ftarW1W/Oe+HOOXehlFkfyW1TyoVhPpClgli1CqeEtm1OVye+i6X9gsHgYYIzqL4UAZOIVLdkh9Q+Zr8GgStW9ovgSVDzhM0OK+iTzKJfGH1gl/YP9NVXu7Z+zb12/bm2Pjiqo/mzdMjYzFOoMvRuD+e8z9vlNlm9gjoVoWy+bU33zTkZ6abRvvkq7MnHHq3fkGySsJrIkg4GG0lhPGm6rrs1KaeywUExO0YnQgnwuS0VcbIj9E4cxV/7fq8zgknKO7bc6NxlfzabKdri658anDs6itFTQat6viKVbdA//9tqvBUTrdAZsrUV7S9rO8mlo3VQbXJ99aLH1bqadodooaJg5LOxa5ZE5OWK5ART5RkRi2RNpkh8/0m7OkxM3z5c3zkToTUbe78l1v+rdxr2iTkq3x0afwDStaFYZqo/8WlFKDWYGczPvYcdNGfAv8S+WXPUUbpge22B4MvR061iuq9rVvWBf1a4Yi2/NTEuCgVQSe6F+y99ZMFBVGD8udpM5UFWoZyYqG2SSvE1kzXKz3O0pfmvD4H8VrJeiYVUoIzFGAZ/KnfGpBH8bR7gspsExUYzZFUUhCoaUWC7iYpUiEM1x65Z98aVszOn9pSHW/71RYDS2swkK/0o26e9Ly7S9HO4Qs6ElhV8IH934FAnS28bpkK0U2OyilZ3Po1wMH0Hfx/b7rpcUgA+NmT7lQMQ5pnJ6gv5ihA1uzu l9ofmKli jMbTYw0NCFJ6+EiD0kNO1/rVP6bvVRqMeYBg6UcclNf+w1jyuWyC+OAOhXKsAJww1dJ2EOM0jjh2ARFwYSaZCVst0zRBX13MWpzLo0RSp0qs7xAYvvCMrR0txZc30GyecWSjblN9Q2Cd4FaL8FDDyBXbNaJzeWp0mXlgiZjVH6OSv0FL57NsoQ7BbvQ/tWXsqYqmkJHiQfhFVeNJM+uPENvUGMHoEGJ5g9G5T+n0bpMKezICR/0h9NeZswft0fo9t+mzJXea0ud5NcBHMezLeZZGUBzu46XLLoCQ/HAspgmFu17XnKbBe8lIqNePSYWYgseWlnatR6zypWFSRNSiaqHtBQRdScxFofChsqW/farX5ugnhmD17Cq0RQo8c7Me1V9idKQ6ZXd+KVu0NbNXveqtBK0+cZjb0KSV8EECO49QQDV+JngyF0obXJHEnxp6ttMoaV6a/hPj5t26K6/Dsx8JGR4dYypSOlhPeUDOt+M7k01vDV3L8Mjifp35vNAPMbHYPxEZmoHjrhQr0mctoR9xGNP/dUYUeW7fB00SqT6/wbisSy9Vf+9SaoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.125890, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 05:58:04PM +0000, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > [2] https://github.com/KSPP/linux/issues/89 > > Signed-off-by: Azeem Shaikh Reviewed-by: Kees Cook -- Kees Cook