From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3C2C0015E for ; Tue, 11 Jul 2023 22:29:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF1A56B0071; Tue, 11 Jul 2023 18:29:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA27A6B0072; Tue, 11 Jul 2023 18:29:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A69956B0075; Tue, 11 Jul 2023 18:29:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9813A6B0071 for ; Tue, 11 Jul 2023 18:29:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F2B21C82C3 for ; Tue, 11 Jul 2023 22:29:32 +0000 (UTC) X-FDA: 81000773784.01.AAE0C0D Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf04.hostedemail.com (Postfix) with ESMTP id 808BC40014 for ; Tue, 11 Jul 2023 22:29:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hqJ8UpcD; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689114570; a=rsa-sha256; cv=none; b=Ye/cKD8NXOdEvxouD64xul647M+ob4LvoT5u1HAUqT8apkBm3GtQOrWSXFxx8NSdV6WgaX DUjzR5zYSU/Tt8kQR9S/wjaee1UZCs/jW448GyE+slZZTkT4TasinFP1MV+TEl/r/QS3fe DLr9WL+4KlIbYJSTgCLBgh8aJTR8gQ4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hqJ8UpcD; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689114570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0CeRWKhdgFGhyCnOTZPbRqGvhDegtQ7RaAzKlQyWgYE=; b=lviELe6LGFZUGyCWd/Xdx1FLh0OmwXNqxMEQaIL55F/B8V5/jeFx5ifwfbawouL+ZWWNSb 9AFtDFXo84qSBWOgCwKdo04q7rIF3Obf4LQDHGLrbQET568acB8eMZI9Q9r9X/ilO74dTY m023LpXYE7prutMalDzFuXseYxULhWs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689114569; x=1720650569; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MF0/oGx5uxSt1HWGanh/IFZ/ftm5LhHIhZxGiK2UjMQ=; b=hqJ8UpcDvns87wrZExf5auA6CLv/iK/qTfzZs2uHsttQt1B67nunpODX taS3dqr8BWXh9u0t3QVmdTXtT2lSK/NAK7/CfgdJvTcaX31bFb8Za+Qwc dZwvzKgaitPEVlWQsdEcRBwKVawU1yxI/ugWdfDjEgucvU7C5tiznCqQi adjnHY6IPvsjtcVk6h2LeITDwAqWGUXvZLl3bz5789IMsZha6/9CN45aA NkV4XNp2Cmpj7K9TiYFCPNEDWTGsLPUhBGEZRwvMT3+Rl2fRFHsapyZoK PaQ8bb7F1IoQSN4Oo8D5Qjws3CyVlG6x1tUDm+N06ccOZQwjoKIHozVeQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="344351877" X-IronPort-AV: E=Sophos;i="6.01,197,1684825200"; d="scan'208";a="344351877" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 15:29:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="834883015" X-IronPort-AV: E=Sophos;i="6.01,197,1684825200"; d="scan'208";a="834883015" Received: from lkp-server01.sh.intel.com (HELO c544d7fc5005) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2023 15:29:24 -0700 Received: from kbuild by c544d7fc5005 with local (Exim 4.96) (envelope-from ) id 1qJLrH-00059p-1b; Tue, 11 Jul 2023 22:29:23 +0000 Date: Wed, 12 Jul 2023 06:28:37 +0800 From: kernel test robot To: Nico Pache , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, aquini@redhat.com, Andrew Morton , Linux Memory Management List , Anshuman Khandual , Catalin Marinas , David Hildenbrand , Gerald Schaefer , Liu Shixin , Will Deacon , Yu Zhao Subject: Re: [PATCH V2] arm64: properly define SOFT_DIRTY functionality Message-ID: <202307120618.qcxXw9mm-lkp@intel.com> References: <20230704133633.1918147-1-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704133633.1918147-1-npache@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 808BC40014 X-Stat-Signature: ks4tjkm8rcrq84e8pgbc69gkiccat5pq X-Rspam-User: X-HE-Tag: 1689114569-303778 X-HE-Meta: U2FsdGVkX19P4MU4pt1Fc9URCfQpnXPszl+cvHi3qM1CJJvTHJ6TuL3MJWVZ9smeiu7FDYD2UbdtPFBhq6fo2R5l2+VIM4Nv0fVItHdodpo339faAJdl4gZzs8zGPuajcnK7vZ7UGvjzmBCZ2IYEcvZJVT7/rn2WGAb+4Q9b/qeytIX919wPwM0p3aDl1IvZGQJBaf49LuYnyu37ulijtnlbv3X65+ahpuB7HSCQRAIN1b25zFVcMqYuCVK9npw/v9ZwRgcVauzXWVyM72C0adnGDPArr5N3PXIUBOI0YDIfyu7aj4bCdXuvhVg95ciJqy56xzOQGlKDpjjZBSwX/kDmgMGZFqXOp2LzrtLiS/ULC77WdfAdtloi9pgQYmuOng9GCqXO4rmO39aGlfc8SCpxhsnl5wkD9kZkBbp3NTSEDjjXjo6DrzDhPZAk3qUKJOqJhCxRPiqalXEyOJDvSGnjlUICiBXoghewOvmxhu5rsc81//b1s4vQ0SGV8lJ0moL28Mx/CJPPJss0TDSADu9ATrn8b6rXb1vUidrYbXK6OlLxn8Xdk7QMpi+x4/E71JVs8dhAFm7Aqd/i7n9Ip36XPTOFJDaY/LQhuHvCjWCxqrkOEJb1Tz/jPNdKkib/H8CPNw4IDb7VKpiR7QTgIS8pHTFFPi7t9jG12piT5c3d7SVEsHFYaWwLA8DYcZ1ScwMScttp+HLV9HLI+lkPsiKCsR2XZuM4C1b2BprYe1T9Hntfo22X/ydCReimtz0Cn91bjwfSk7S1uxLHIaHYjUeFu1PDFnfarBP+pUB817dMdXQ9RK5fywF2r25Bftu0ZY23jPC5ckPwnzplG4ODLYTTNWspEfAkm4j+Y66vTBFtyb677HOuNuJQScisYh5PwuTcdIlubAQ6c4+cpWGCKWTOC+QXEqT4mTvGYYpdUdyro62dXmRczNQw3MpS68O66GdZkYH34cll1iCpvw/ MrczBmL5 2L2mtXr8Kp2C6P0OG6ddeFfizDU2EG0d2XBdRQArFFA9ZLbc4xZ2VBe/POiX6iueZbTOlJcwDInZTGmaVYVxBNX2CYq1WcJ+dLFoPaPTVDYKfX58lmoBnd0qovX4unENvucKv0Sqm89rU9Z7tvByv/eRLPsZy8HxpknjzzdvOjpe58xleplBX44o9cqKy8DvAb/u05sFk5URYWKn/WN0DoGHbVklXvswNieW9IrNGUhNOWgllu4yLAjNt9lsT1wQaingoGv+8nrx6YR03tVTPnrEHC4/nDXfCvR1VfUC3mHrWTwDnU5Fsdm7uQmeF+ZlHn39Lh/mRR6Ol/1cx/RlHYSYFjy5+BJyE4lFhczE+p6tUdyfscZU24n34Jazbow4e46Z9JaVhx+REVhp7OS3tILxdQULZiTi2luo/g58Xnu8bF5caigEOP+rWJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nico, kernel test robot noticed the following build errors: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on arm/for-next arm/fixes kvmarm/next soc/for-next linus/master v6.5-rc1 next-20230711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nico-Pache/arm64-properly-define-SOFT_DIRTY-functionality/20230704-213758 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core patch link: https://lore.kernel.org/r/20230704133633.1918147-1-npache%40redhat.com patch subject: [PATCH V2] arm64: properly define SOFT_DIRTY functionality config: arm64-randconfig-r001-20230712 (https://download.01.org/0day-ci/archive/20230712/202307120618.qcxXw9mm-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230712/202307120618.qcxXw9mm-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307120618.qcxXw9mm-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/mm_inline.h:10, from fs/proc/task_mmu.c:3: include/linux/swapops.h: In function 'pte_swp_clear_flags': include/linux/swapops.h:77:23: error: implicit declaration of function 'pte_swp_clear_soft_dirty'; did you mean 'pte_swp_soft_dirty'? [-Werror=implicit-function-declaration] 77 | pte = pte_swp_clear_soft_dirty(pte); | ^~~~~~~~~~~~~~~~~~~~~~~~ | pte_swp_soft_dirty include/linux/swapops.h:77:23: error: incompatible types when assigning to type 'pte_t' from type 'int' include/linux/swapops.h: In function 'pmd_to_swp_entry': include/linux/swapops.h:506:13: error: implicit declaration of function 'pmd_swp_soft_dirty'; did you mean 'pte_swp_soft_dirty'? [-Werror=implicit-function-declaration] 506 | if (pmd_swp_soft_dirty(pmd)) | ^~~~~~~~~~~~~~~~~~ | pte_swp_soft_dirty include/linux/swapops.h:507:23: error: implicit declaration of function 'pmd_swp_clear_soft_dirty'; did you mean 'pmd_swp_clear_uffd_wp'? [-Werror=implicit-function-declaration] 507 | pmd = pmd_swp_clear_soft_dirty(pmd); | ^~~~~~~~~~~~~~~~~~~~~~~~ | pmd_swp_clear_uffd_wp include/linux/swapops.h:507:23: error: incompatible types when assigning to type 'pmd_t' from type 'int' fs/proc/task_mmu.c: In function 'pagemap_pmd_range': >> fs/proc/task_mmu.c:1488:29: error: implicit declaration of function 'pmd_soft_dirty'; did you mean 'pte_soft_dirty'? [-Werror=implicit-function-declaration] 1488 | if (pmd_soft_dirty(pmd)) | ^~~~~~~~~~~~~~ | pte_soft_dirty cc1: some warnings being treated as errors vim +1488 fs/proc/task_mmu.c bcf8039ed45f56 Dave Hansen 2008-06-12 1463 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1464 static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, 2165009bdf63f7 Dave Hansen 2008-06-12 1465 struct mm_walk *walk) 85863e475e59af Matt Mackall 2008-02-04 1466 { f995ece24dfecb Naoya Horiguchi 2015-02-11 1467 struct vm_area_struct *vma = walk->vma; 2165009bdf63f7 Dave Hansen 2008-06-12 1468 struct pagemapread *pm = walk->private; bf929152e9f6c4 Kirill A. Shutemov 2013-11-14 1469 spinlock_t *ptl; 05fbf357d94152 Konstantin Khlebnikov 2015-02-11 1470 pte_t *pte, *orig_pte; 85863e475e59af Matt Mackall 2008-02-04 1471 int err = 0; 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1472 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 24d7275ce27918 Yang Shi 2022-02-11 1473 bool migration = false; 24d7275ce27918 Yang Shi 2022-02-11 1474 b6ec57f4b92e9b Kirill A. Shutemov 2016-01-21 1475 ptl = pmd_trans_huge_lock(pmdp, vma); b6ec57f4b92e9b Kirill A. Shutemov 2016-01-21 1476 if (ptl) { 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1477 u64 flags = 0, frame = 0; 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1478 pmd_t pmd = *pmdp; 84c3fc4e9c563d Zi Yan 2017-09-08 1479 struct page *page = NULL; 0f8975ec4db2c8 Pavel Emelyanov 2013-07-03 1480 b83d7e432399d4 Huang Ying 2017-11-02 1481 if (vma->vm_flags & VM_SOFTDIRTY) deb945441b9408 Konstantin Khlebnikov 2015-09-08 1482 flags |= PM_SOFT_DIRTY; d9104d1ca96624 Cyrill Gorcunov 2013-09-11 1483 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1484 if (pmd_present(pmd)) { 84c3fc4e9c563d Zi Yan 2017-09-08 1485 page = pmd_page(pmd); 77bb499bb60f4b Konstantin Khlebnikov 2015-09-08 1486 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1487 flags |= PM_PRESENT; b83d7e432399d4 Huang Ying 2017-11-02 @1488 if (pmd_soft_dirty(pmd)) b83d7e432399d4 Huang Ying 2017-11-02 1489 flags |= PM_SOFT_DIRTY; fb8e37f35a2fe1 Peter Xu 2021-06-30 1490 if (pmd_uffd_wp(pmd)) fb8e37f35a2fe1 Peter Xu 2021-06-30 1491 flags |= PM_UFFD_WP; 1c90308e7a77af Konstantin Khlebnikov 2015-09-08 1492 if (pm->show_pfn) 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1493 frame = pmd_pfn(pmd) + 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1494 ((addr & ~PMD_MASK) >> PAGE_SHIFT); 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1495 } 84c3fc4e9c563d Zi Yan 2017-09-08 1496 #ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION 84c3fc4e9c563d Zi Yan 2017-09-08 1497 else if (is_swap_pmd(pmd)) { 84c3fc4e9c563d Zi Yan 2017-09-08 1498 swp_entry_t entry = pmd_to_swp_entry(pmd); ab6ecf247a9321 Huang Ying 2018-06-07 1499 unsigned long offset; 84c3fc4e9c563d Zi Yan 2017-09-08 1500 ab6ecf247a9321 Huang Ying 2018-06-07 1501 if (pm->show_pfn) { 0d206b5d2e0d7d Peter Xu 2022-08-11 1502 if (is_pfn_swap_entry(entry)) 0d206b5d2e0d7d Peter Xu 2022-08-11 1503 offset = swp_offset_pfn(entry); 0d206b5d2e0d7d Peter Xu 2022-08-11 1504 else 0d206b5d2e0d7d Peter Xu 2022-08-11 1505 offset = swp_offset(entry); 0d206b5d2e0d7d Peter Xu 2022-08-11 1506 offset = offset + ab6ecf247a9321 Huang Ying 2018-06-07 1507 ((addr & ~PMD_MASK) >> PAGE_SHIFT); 84c3fc4e9c563d Zi Yan 2017-09-08 1508 frame = swp_type(entry) | 88c28f2469151b Huang Ying 2018-04-20 1509 (offset << MAX_SWAPFILES_SHIFT); ab6ecf247a9321 Huang Ying 2018-06-07 1510 } 84c3fc4e9c563d Zi Yan 2017-09-08 1511 flags |= PM_SWAP; b83d7e432399d4 Huang Ying 2017-11-02 1512 if (pmd_swp_soft_dirty(pmd)) b83d7e432399d4 Huang Ying 2017-11-02 1513 flags |= PM_SOFT_DIRTY; fb8e37f35a2fe1 Peter Xu 2021-06-30 1514 if (pmd_swp_uffd_wp(pmd)) fb8e37f35a2fe1 Peter Xu 2021-06-30 1515 flags |= PM_UFFD_WP; 84c3fc4e9c563d Zi Yan 2017-09-08 1516 VM_BUG_ON(!is_pmd_migration_entry(pmd)); 24d7275ce27918 Yang Shi 2022-02-11 1517 migration = is_migration_entry(entry); af5cdaf82238fb Alistair Popple 2021-06-30 1518 page = pfn_swap_entry_to_page(entry); 84c3fc4e9c563d Zi Yan 2017-09-08 1519 } 84c3fc4e9c563d Zi Yan 2017-09-08 1520 #endif 84c3fc4e9c563d Zi Yan 2017-09-08 1521 24d7275ce27918 Yang Shi 2022-02-11 1522 if (page && !migration && page_mapcount(page) == 1) 84c3fc4e9c563d Zi Yan 2017-09-08 1523 flags |= PM_MMAP_EXCLUSIVE; 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1524 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1525 for (; addr != end; addr += PAGE_SIZE) { 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1526 pagemap_entry_t pme = make_pme(frame, flags); 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1527 092b50bacd1cdb Naoya Horiguchi 2012-03-21 1528 err = add_to_pagemap(addr, &pme, pm); 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1529 if (err) 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1530 break; ab6ecf247a9321 Huang Ying 2018-06-07 1531 if (pm->show_pfn) { ab6ecf247a9321 Huang Ying 2018-06-07 1532 if (flags & PM_PRESENT) 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1533 frame++; 88c28f2469151b Huang Ying 2018-04-20 1534 else if (flags & PM_SWAP) 88c28f2469151b Huang Ying 2018-04-20 1535 frame += (1 << MAX_SWAPFILES_SHIFT); 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1536 } ab6ecf247a9321 Huang Ying 2018-06-07 1537 } bf929152e9f6c4 Kirill A. Shutemov 2013-11-14 1538 spin_unlock(ptl); 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1539 return err; 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1540 } 5aaabe831eb527 Naoya Horiguchi 2012-03-21 1541 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1542 if (pmd_trans_unstable(pmdp)) 45f83cefe3a5f0 Andrea Arcangeli 2012-03-28 1543 return 0; 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1544 #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ bcf8039ed45f56 Dave Hansen 2008-06-12 1545 81d0fa623c5b8d Peter Feiner 2014-10-09 1546 /* f995ece24dfecb Naoya Horiguchi 2015-02-11 1547 * We can assume that @vma always points to a valid one and @end never f995ece24dfecb Naoya Horiguchi 2015-02-11 1548 * goes beyond vma->vm_end. 81d0fa623c5b8d Peter Feiner 2014-10-09 1549 */ 356515e7b64c26 Konstantin Khlebnikov 2015-09-08 1550 orig_pte = pte = pte_offset_map_lock(walk->mm, pmdp, addr, &ptl); f995ece24dfecb Naoya Horiguchi 2015-02-11 1551 for (; addr < end; pte++, addr += PAGE_SIZE) { 81d0fa623c5b8d Peter Feiner 2014-10-09 1552 pagemap_entry_t pme; 05fbf357d94152 Konstantin Khlebnikov 2015-02-11 1553 deb945441b9408 Konstantin Khlebnikov 2015-09-08 1554 pme = pte_to_pagemap_entry(pm, vma, addr, *pte); 092b50bacd1cdb Naoya Horiguchi 2012-03-21 1555 err = add_to_pagemap(addr, &pme, pm); 85863e475e59af Matt Mackall 2008-02-04 1556 if (err) 05fbf357d94152 Konstantin Khlebnikov 2015-02-11 1557 break; 85863e475e59af Matt Mackall 2008-02-04 1558 } 05fbf357d94152 Konstantin Khlebnikov 2015-02-11 1559 pte_unmap_unlock(orig_pte, ptl); 05fbf357d94152 Konstantin Khlebnikov 2015-02-11 1560 85863e475e59af Matt Mackall 2008-02-04 1561 cond_resched(); 85863e475e59af Matt Mackall 2008-02-04 1562 85863e475e59af Matt Mackall 2008-02-04 1563 return err; 85863e475e59af Matt Mackall 2008-02-04 1564 } 85863e475e59af Matt Mackall 2008-02-04 1565 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki