From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DCBEB64DA for ; Wed, 12 Jul 2023 07:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA896B0071; Wed, 12 Jul 2023 03:09:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86B666B0072; Wed, 12 Jul 2023 03:09:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 732766B0075; Wed, 12 Jul 2023 03:09:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5EB136B0071 for ; Wed, 12 Jul 2023 03:09:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2E02F160120 for ; Wed, 12 Jul 2023 07:09:22 +0000 (UTC) X-FDA: 81002083764.14.72D2FFC Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by imf06.hostedemail.com (Postfix) with ESMTP id 04D1518000F for ; Wed, 12 Jul 2023 07:09:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=pgNIylGm; dmarc=pass (policy=quarantine) header.from=microchip.com; spf=pass (imf06.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689145760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vh4ZijMfyCiE7ryghMf74nrXN1cnyfe5IMXVQ+yZOm0=; b=NTpMl0XJLNrwSMD1RYnTBjt8s8A8MsQRVaN+9Hn2DM3b6lxTwpgXls8lFboV7ymzYfHk7O +i7c3c8NpnTcwsgk+49dF6IWDdhrTmyZ/zXH2HA4rgXy4uLNt57FvlI3UhU1cvneDZ3qnX CWLI66hIRdt/wYP/42JVo6nzGMMqQgw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b=pgNIylGm; dmarc=pass (policy=quarantine) header.from=microchip.com; spf=pass (imf06.hostedemail.com: domain of Conor.Dooley@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Conor.Dooley@microchip.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689145760; a=rsa-sha256; cv=none; b=Y8MYOdQfwPJPdSCF8rr7XuhGLukiuK6P40e2C1B37sukCSFkwmy6+zzZy2XaI5pkSuGC0V vnL3eUnFlQRaTC45Sz1XssPiTVlyVFowi4ormOsz7C159BT8ae1n5WINrxI988WLOds/78 6xQYaeewTaPHg16eDD/XFbdrJiqHq9k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1689145759; x=1720681759; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=duZW+sLs6ycl8qwh4wlYhASDZojoec/KJOE3c/Wl/kA=; b=pgNIylGmbn8MSRLFVodqKZcOtLntAZXHgRPN4FojkOghBUAgW9fZw6Mt kSnWsZmcad77vDcdg+L73n3EGULfxIAWuNu64Tl6iE9Ce5lHRV/QfzZrt KVx1qEPSmB0FvpOVTtUp7aiUmJe6qjGb/qwg18QSbbpoTSJ3t0LRtXv73 PzAPFcESm2YdMvIiBFTkTmXhq+uoSnub09hSHKReRCDU5EdMMKodgLsIY 3LDKiQJktAzQ7Y3caOnpr0MPZb+KokzrJIMTs0tDCwAgXHEWVEI6jd5Qn gqtQc/1teTrpNJU8Z0+BwfJXQ2VAUjchDzjEn4NCHOKxXLJE3rgZRN1wM A==; X-IronPort-AV: E=Sophos;i="6.01,199,1684825200"; d="asc'?scan'208";a="222553164" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 12 Jul 2023 00:09:17 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 12 Jul 2023 00:09:16 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 12 Jul 2023 00:09:14 -0700 Date: Wed, 12 Jul 2023 08:08:42 +0100 From: Conor Dooley To: Alexandre Ghiti CC: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , , , , Subject: Re: [PATCH 0/4] riscv: tlb flush improvements Message-ID: <20230712-void-sniff-ca1abcbc7783@wendy> References: <20230711075434.10936-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dahEnerN+wZuERnx" Content-Disposition: inline In-Reply-To: <20230711075434.10936-1-alexghiti@rivosinc.com> X-Rspamd-Queue-Id: 04D1518000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 159jsjj8he3u3u35nauny1pasd19zxfu X-HE-Tag: 1689145759-497660 X-HE-Meta: U2FsdGVkX1/N++/n9wIjgVKvIxVDb3GHJYf/QYOF6TTXpWGL+6IFz0fEGN5Y+a4B2f2d7m1dmKPitQhz7JhfO0HgPzPaPxd3i/LhbqOMeMOj4w5tq4ccD+GZM1rQ2ZE+Wueh5kI0qh2U67S87Hh2o2fZNH3olH0nKK2Iszqzay0/x0LkmGFZSswFvF5V3twWGAtX3oMWu1WRr0KQb5/73BJqzO7S/XZP35W7wYeqL3ARxsCOuNmHLQsRe09nYQ6sR1DKqajDkkdWe0v7niDfjUA2SsPlwlUykC0Af3EpTnPl5UXMTcSThUimlenmknzXVrBj9lyW9EMiIBKKpD/9yyPs0B+MO8G7KpHPlmIpleriH6r8v1ZpVTKLFZPrj2QydohADkC1/lYpeyVrPbZFak9XPXWVsPQ7mj7HoBVfv9/cvB09v/p5ZQAULkMxRDUOKI/LjMJJe+BGtjWvAK9VXJcbWtQ/ta2BasvbxJIIeSB7/YzyjL1Pae4+luB75S5hVSLiYtxjcQIlVSYAALfQf0frM8I09fncWszakeJ5zbas7ufT/6aFJts89uRYrorDpvQn8IKe2dSzZ9Fo1m/XwnjW67TLpzynETBlXeL1PytrYibrrW0fNDkzwarnFsBfYN2XqGPMor10UcIY+o7yEPNk2aXyi7C0b5guavT+beBONgMRfe89vWDbCly3P9Q6h9Z+8ClKOBf6mZsvwsfmdgmaPU8bgmqI6dF+I71qygCD6/FDhlNwQNQinSFKbYFiLWnQl5tb3L4/qIzhb7uePMsAhRMxuP10XQPKYzm9H2ZSVJ0vfSGFZCNVZTl82t9Z1OIwjWXn1xlzyiad3OBDyeRMzGsDnepGcy/WKvUI/RpDxQ22dmdyFx+lMfaEyY0+I1BD0NaCzs2/yhimcRrdIT9IYO7DXLlm/F3jo/vaiboSn43xTxHN/Y87FN6lQcOh9WXEsJXYmJH3q4fa70r 7E9XJ3yM DD28uN1Zjrag4zmFqqpMPP5AfthySae17u6SgJrXzNi2D5fXbD3w0h67M1AhCDpGu3LgcdyDOhFuzv8e0qdW/egEkP0FHvkzV+ktVhLHHrQlmb5fR8XfcDj3x4r1WyEr5GwW5uAp6qLAArEVARAlImqLTfCmU9JUNy9Le6CO+MLBDF7Va5tGsrgDFXmipUGv+nZaKQyuCjL5aXibFQs3x0mtJSmkNUrjT81BlHd69U6zd97/X+ZEdisrcefZ/6daUOLplO+/9qIL8dGkuLOcxQQFAbBxkW0AcTQ3rxZTk1MRmQAZgpTubtYcyF611ytB5quwQzMpycCpILzEQ/eWgBY38QJlSsOo8qG69dyMKHD2h9Cx+jKARg+uFCQFEhsOqR2s/rVyjh58HTAcqeaJYXab+2hLMyR0jfVoCSpQoO++6RlbhGUcOhqlfGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --dahEnerN+wZuERnx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Alex, On Tue, Jul 11, 2023 at 09:54:30AM +0200, Alexandre Ghiti wrote: > This series optimizes the tlb flushes on riscv which used to simply > flush the whole tlb whatever the size of the range to flush or the size > of the stride. >=20 > Patch 3 introduces a threshold that is microarchitecture specific and > will very likely be modified by vendors, not sure though which mechanism > we'll use to do that (dt? alternatives? vendor initialization code?). >=20 > Next steps would be to implement: > - svinval extension as Mayuresh did here [1] > - BATCHED_UNMAP_TLB_FLUSH (I'll wait for arm64 patchset to land) > - MMU_GATHER_RCU_TABLE_FREE > - MMU_GATHER_MERGE_VMAS >=20 > Any other idea welcome. >=20 > [1] https://lore.kernel.org/linux-riscv/20230623123849.1425805-1-mchitale= @ventanamicro.com/ >=20 > Alexandre Ghiti (4): > riscv: Improve flush_tlb() > riscv: Improve flush_tlb_range() for hugetlb pages > riscv: Make __flush_tlb_range() loop over pte instead of flushing the > whole tlb The whole series does not build on nommu & this one adds a build warning for regular builds: + 1 ../arch/riscv/mm/tlbflush.c:32:15: warning: symbol 'tlb_flush_all_= threshold' was not declared. Should it be static? Cheers, Conor. --dahEnerN+wZuERnx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZK5RegAKCRB4tDGHoIJi 0m6sAQCD5bKPD2l+jsEwxjIzFU/98p6cICiV9t7nlfZ8sb8mXAD/UPM/OYJdjWyb I2qZkkSuaIMYtFOVwZy/StTB2tnmngQ= =UB9i -----END PGP SIGNATURE----- --dahEnerN+wZuERnx--