From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 638C9C001DF for ; Tue, 11 Jul 2023 17:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEBAB6B0074; Tue, 11 Jul 2023 13:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9B186B0075; Tue, 11 Jul 2023 13:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C63BE6B0078; Tue, 11 Jul 2023 13:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B8AAC6B0074 for ; Tue, 11 Jul 2023 13:20:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 69E1CC0278 for ; Tue, 11 Jul 2023 17:20:15 +0000 (UTC) X-FDA: 80999994390.30.7C444C3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 9AC8840002 for ; Tue, 11 Jul 2023 17:20:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Jpr/isp/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689096012; a=rsa-sha256; cv=none; b=gfs8TlGeFMeKsO8GeVqSsm43duvbhbbgecAY1mtqlfViGUOqZFhj82jbJSuvH4au+pLJWp vsf09bjekdE1+87Q/qN8G/0JD9IoC1c3DJl0AAcAFU4PH4Jtpd4UbV9S8elxHFwO9FtS/t QbqzeiwT8MQo4acQxIWe3TBzgwD4WD4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Jpr/isp/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689096012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxEXu5qn2UdkEU1tUJY6YcZihiVuAOzklRzc7UeoYCE=; b=V8vz+diVon8K+K+Qh0raYPVL66IrT8f/j07Nz9bXDjCFTC7ObfuHYAlQgw9fuOho2bW22z KrTQvTSF1Wr65PilSbMGMDg/xvCPjY0MkNppoWOGpWpQG792pW+TX9/RkBhGWfxO9amaDu hiCwF37fZYhEbvSXOaa9rl6oUq/M6f4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93E1161590; Tue, 11 Jul 2023 17:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B76AFC433CA; Tue, 11 Jul 2023 17:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689096011; bh=0x7thVqvoMJLS+jYevpe76UFSqxecS9xef82lMrGa00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jpr/isp/keQPzKORZrnZW0bPMU7W6AgKLRgyA/rP0dBC6J40H4eTC4CnRKae25NEz V9BMwz1gjYE3E7hm61usKMdGg1rhsxRvy1NrfOFi9pNBuipooot8gWGjWnPHpgBKOn 3+IHiZ32k+bQigDguA66VECb6YwYOiDgA+0+qK2gyvJrVVRZyv9vwq2WaGcDDFEe0W bQbTPJoMiyok5wkfLSMFyaXkWFcFnjFZ3UUjsuo24fQiTUZu83e5PlxT+YQUnduyDX k0AfsgHSdabFVi5If5WhV0mrFOT6F5tqRPOODryif56R1FXwZjagZ/oFNyBM2QZjGh R0XuXzlBNVs6w== Date: Tue, 11 Jul 2023 10:20:08 -0700 From: Nathan Chancellor To: Baoquan He Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Niklas Schnelle , Christoph Hellwig , "Mike Rapoport (IBM)" Subject: Re: [akpm-mm:mm-unstable 86/125] drivers/irqchip/irq-al-fic.c:281:2: error: call to undeclared function 'iounmap'; ISO C99 and later do not support implicit function declarations Message-ID: <20230711172008.GA369569@dev-arch.thelio-3990X> References: <202307110516.V0qgum1Q-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9AC8840002 X-Stat-Signature: 7of6yekwmfh3h5xftpkyryuimjz86mmh X-HE-Tag: 1689096012-53581 X-HE-Meta: U2FsdGVkX1879e7yLrzKaioSscImu1Up41i3FD9XbooNSUOzqBPAKKbIbv7YxFqWSncqPhyrwFI3PXcKm5+a/gswUSwiO/QeO/K3HAF9JHCLuvyBUBJVKzlc9MMQUZU0agPERjc9ndLbPxa05AmRjkKTtKsM+Dmm/gl2EoXsAehEk1gnTFNITiRXTDmtpnEhGTNLa14l3bKcsCjmyTo8G8smb9N6uKsz5Dmei6e1tHo3JKBosXtD5yrX3BGivnbGZh5EhvEQdv6lThco5KB8YFM3+3ftZq2Z7w7RF4sC9ZBqcjA7+FwekxsJO90DcHBRi5p+YBUq+kXblMzCQCcHBSbGZ/4MzvV+uthtBK3nTtPTfkS6gdUoqLqcbUgL0guDYqua8TJu9ounCzq/4UrxfRTB/Qf2SvWGt5bywXAMW7WeM0gEWVBPM4eogNp8t88WqzdTxbiZloDcmlAXtphE60VMx32jIhEDvHeUfGTM3paiXzgKCA+fsJjBNAHxOggkm27aadiS7Gex6btXZQb34OCAmJexQKhHWS3nBOYkwUFf81RnCSDV5na56k8BvfLrL1eYB1XIep5r+ftIjHcVu66u8czyKOZ/MOUYTVijbnSve3VXOCuSiwI9N8enqcRtOsPCZwMt7mXYRyfvMPZB9H6by0ow/6Vr7bwqEhYZV5GRnjvtyyWD9EVOka3/qzwURXFhk2nnT0eQ3//h6syc5z/Tm606gzm4vm5nwouYA497hv7jWHEdUBtlN2UWYEf95BHeWoE8+b3MHWRC/t9d/FH2gYEjSMAz6yPfmHDJbABjoOBKscjVfIWUmjHb0RR/qsic8FCtRB+168GP1TdA+GHTo4RIwUUnXQ7qm8eTWfucaWjshcwHiihmibe5jcCJVec9elw2OCJVn6+PEZAxIvySfvj/lI74ZYm0HW99ZoB5oSkuc5TCz6Yezfqp5luR/cpw4r3+2BoY0fMm8t1 eb4Squk4 6KmzrNqqgSq/BRrHH7QJi2vpMBFIiby50zP5u3nxr4hjCBUPmEHSZgKGCZZUPnqX2khVFg+dkJLS1jdKGNEaaGSV5S2o0g3cdEpKOo+Tk7ZFW1A7uRfvg6Kb48Nxj99aaZloB2MjxPYkC/n/TO9kHdo/u/x/zcHeNHyOINj5sPYAk64WRIM06+cPM8QjRUGSLTmxhSq2aO+Osc1GYYmEy9xsnWgTXBht6QrEK+c04b95G2deCq+suvbpL+KYHupdHEwhh//ZGehbU+eVoiUpwWMtOBxZL9NdCxuPCAbE/MQnbhMbpJ62ZCTYHpVljqlQg7NownmwJlcoHYDuV2EwkgVS5gn8Xek9bFiHm3gQMzELS/tIbvzixJbXGRXQaMUSnPm6FWPNWOCVlmxW77hoXv6X38YwFXLHSor0Pkh12cz2KRHojc5M/dVL40kgnwWZNCCKe54y493LqTNR/+xwLUTp5/wbV47RyC60ltG7ZCSNc2LHTA/h0CaV0xr7/wVTlb7Ga7CNjMbpIrUBPXrTEb6SpS7HukaWXi+nLJ3wN7IM6pYqjOog6rz+IJS86Wl6dDo6ZRddcnRh+e+eCKO1f2Zw6B3dUC22G9zrhiwrCWKKaeWymSfxFeGdnAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baoquan, On Tue, Jul 11, 2023 at 08:45:20AM +0800, Baoquan He wrote: > Hi, > > On 07/11/23 at 05:22am, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > > head: 17712b3b36c898462c3d31d4b47bd069e87359c5 > > commit: 7aeb1874c9d6e390a405529c7eec76d2486f65d8 [86/125] s390: mm: convert to GENERIC_IOREMAP > > config: s390-randconfig-r015-20230710 (https://download.01.org/0day-ci/archive/20230711/202307110516.V0qgum1Q-lkp@intel.com/config) > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > reproduce: (https://download.01.org/0day-ci/archive/20230711/202307110516.V0qgum1Q-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202307110516.V0qgum1Q-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from drivers/irqchip/irq-al-fic.c:7: > > In file included from include/linux/irq.h:20: > > In file included from include/linux/io.h:13: > > In file included from arch/s390/include/asm/io.h:78: > > include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 547 | val = __raw_readb(PCI_IOBASE + addr); > > Thanks for reporting. I am not gonna to fix it because Nathan told me > there had been a series specifically taking care of the PCI_IOBASE > warnings from Niklas. Quote Nathan's words here for reference: > > > https://lore.kernel.org/all/20230612160237.GA199007@dev-arch.thelio-3990X/T/#u > === > I believe that this series [1] by Niklas Schnelle should take care of > the PCI_IOBASE warnings (which are not Hexagon specific), so there is no > need to worry about them when they show up in build reports. > > [1]: https://lore.kernel.org/20230522105049.1467313-1-schnelle@linux.ibm.com/ > > Cheers, > Nathan > === > > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); > > | ~~~~~~~~~~ ^ > > include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu' > > 37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) > > | ^ > > include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16' > > 102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x)) > > | ^ > > In file included from drivers/irqchip/irq-al-fic.c:7: > > In file included from include/linux/irq.h:20: > > In file included from include/linux/io.h:13: > > In file included from arch/s390/include/asm/io.h:78: > > include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); > > | ~~~~~~~~~~ ^ > > include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu' > > 35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) > > | ^ > > include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32' > > 115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) > > | ^ > > In file included from drivers/irqchip/irq-al-fic.c:7: > > In file included from include/linux/irq.h:20: > > In file included from include/linux/io.h:13: > > In file included from arch/s390/include/asm/io.h:78: > > include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 584 | __raw_writeb(value, PCI_IOBASE + addr); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 692 | readsb(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 700 | readsw(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 708 | readsl(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 717 | writesb(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 726 | writesw(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > 735 | writesl(PCI_IOBASE + addr, buffer, count); > > | ~~~~~~~~~~ ^ > > >> drivers/irqchip/irq-al-fic.c:281:2: error: call to undeclared function 'iounmap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > > 281 | iounmap(base); > > | ^ > > arch/s390/include/asm/io.h:29:17: note: expanded from macro 'iounmap' > > 29 | #define iounmap iounmap > > | ^ > > drivers/irqchip/irq-al-fic.c:281:2: note: did you mean 'vunmap'? > > arch/s390/include/asm/io.h:29:17: note: expanded from macro 'iounmap' > > 29 | #define iounmap iounmap > > | ^ > > include/linux/vmalloc.h:167:13: note: 'vunmap' declared here > > 167 | extern void vunmap(const void *addr); > > | ^ > > 12 warnings and 1 error generated. It seems like this was the error that the robot thinks that your patch introduced, which seems like it might be legitimate? Is an asm-generic/io.h include missing somewhere or is there some prexisting issue that is exposed with your patch? Cheers, Nathan > > vim +/iounmap +281 drivers/irqchip/irq-al-fic.c > > > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 236 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 237 static int __init al_fic_init_dt(struct device_node *node, > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 238 struct device_node *parent) > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 239 { > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 240 int ret; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 241 void __iomem *base; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 242 unsigned int parent_irq; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 243 struct al_fic *fic; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 244 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 245 if (!parent) { > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 246 pr_err("%s: unsupported - device require a parent\n", > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 247 node->name); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 248 return -EINVAL; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 249 } > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 250 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 251 base = of_iomap(node, 0); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 252 if (!base) { > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 253 pr_err("%s: fail to map memory\n", node->name); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 254 return -ENOMEM; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 255 } > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 256 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 257 parent_irq = irq_of_parse_and_map(node, 0); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 258 if (!parent_irq) { > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 259 pr_err("%s: fail to map irq\n", node->name); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 260 ret = -EINVAL; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 261 goto err_unmap; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 262 } > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 263 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 264 fic = al_fic_wire_init(node, > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 265 base, > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 266 node->name, > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 267 parent_irq); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 268 if (IS_ERR(fic)) { > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 269 pr_err("%s: fail to initialize irqchip (%lu)\n", > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 270 node->name, > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 271 PTR_ERR(fic)); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 272 ret = PTR_ERR(fic); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 273 goto err_irq_dispose; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 274 } > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 275 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 276 return 0; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 277 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 278 err_irq_dispose: > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 279 irq_dispose_mapping(parent_irq); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 280 err_unmap: > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 @281 iounmap(base); > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 282 > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 283 return ret; > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 284 } > > 1eb77c3bcdb70f Talel Shenhar 2019-06-10 285 > > > > :::::: The code at line 281 was first introduced by commit > > :::::: 1eb77c3bcdb70f2501f419b3da45b19acaf01072 irqchip/al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver > > > > :::::: TO: Talel Shenhar > > :::::: CC: Marc Zyngier > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > >