From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DFDEB64DC for ; Tue, 11 Jul 2023 19:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B96F06B0071; Tue, 11 Jul 2023 15:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B46E56B0074; Tue, 11 Jul 2023 15:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0E4F6B0075; Tue, 11 Jul 2023 15:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E6626B0071 for ; Tue, 11 Jul 2023 15:32:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E82C1C7350 for ; Tue, 11 Jul 2023 19:32:50 +0000 (UTC) X-FDA: 81000328500.17.66C1D48 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 76B64C000D for ; Tue, 11 Jul 2023 19:32:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a2ZSyKfk; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689103968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tWqMQ6zndsnWXxc5QlSqUDcy3iitASWBvYGdWlMZ5/I=; b=YoQibixGQjxXXEnv41/34Twqw5Be9c2hLggNcAFTk8PIYxDkAmkVNoM+SWtV+x4NW/UarT NHRA9FKNE7I87VMoJpyqf0lpIN0A/QZ1XxJ1fWZQd97z6azMQh+dtYpN/G1P+li7XWMTrm 3tl2AcCRd3HDLkXZK3ARsOHWN8YlMsI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a2ZSyKfk; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689103968; a=rsa-sha256; cv=none; b=Ch+6LV3eL1PHrHzW88OQrZMRvvVdlCihXzdSsbH2ELdksR6EdtZN7zT9k96opoUA8E+Sss AYYySeKVH09EyAXE7dM1PygsI/KZEAVY685BzFbS7jV0EiAxJlsTceII0KH1gDo9C/hLCt +vLGwTIx6JUR0YEDa48KLpo/bBE55kM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33ECC614E6; Tue, 11 Jul 2023 19:32:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5584AC433C8; Tue, 11 Jul 2023 19:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689103966; bh=WbGGH319GGiAliOny1Q0FGLHKF8BtHi4+zSqoKNuvBQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a2ZSyKfkoLOLhvWO8FGdNVPfSyG27ErAEjli61nTXq9TEUiz31rUOWB0Bwa24zBlR bWe9aFNV2pjACx1jIHzhbZyXmky5VZTfH1HqoKDdAhDacDOYXhwg2HKVzoEwh3vrQ4 niTbR3LtGB2DB9HZ5LfrLHt4N7Sh8KFYbEt0tX0c= Date: Tue, 11 Jul 2023 12:32:45 -0700 From: Andrew Morton To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, david@redhat.com Subject: Re: [PATCH v2 1/1] mm/filemap: remove hugetlb special casing in filemap.c Message-Id: <20230711123245.473400853fd1227459017650@linux-foundation.org> In-Reply-To: <20230710230450.110064-2-sidhartha.kumar@oracle.com> References: <20230710230450.110064-1-sidhartha.kumar@oracle.com> <20230710230450.110064-2-sidhartha.kumar@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 76B64C000D X-Stat-Signature: dtkg1bgjyryqoy7pq5xauk7umtd99ehh X-Rspam-User: X-HE-Tag: 1689103968-190190 X-HE-Meta: U2FsdGVkX18wLGrZZ3xBTfgSNpKEmzOqOafa/TQMawdN7k9qEpQ4gI+gNJ4P0iti+fcHsODxSPfTGS0uypcp/m2djw+ifi+bdm+6AnrBCO7bc6bRn/8g5sXQhv4HU71sUCptJiiVZohIfCJGlhdG3q1sz8IhzaUgEUeYkec1w89FCPpgMAfvd8darJaRm3ZfYfHBmtTvq1eLlKi2jUey5mMP5UweS6H94X6z9qjhd8sIhdrynp2RROs1PF34y+7taTRcnlr/DBFCPcb4dAgtUscCGrCP6AMpCfx0pu6WTCcc/wzbylXh0IkZAaY/OZgjfOl/Urn9NF/DgN7dI7JBGwDfMvqWalvqx+PXPFGxGfeVAvHpJJHNe0YFA5QNg4JzpbY9BaAwVWtZSSkMA6oYXMNIZcenn1JzPtsH/u0Z1nzRQQ7VKiarsC2SDtxYzWO1QcDxnbBoCxiazByFo3k0fhPEUuuZ6obR6cCo6/sBh5QiwWek6VvnRKBcH2HP/pj2uXHGc7UH/AGuTM/id1SrNhdeiEc6D/mYHXyELy5i8PK7FJc+RVbugtsHGI0tu4vpe//KffJgdsLfbuPs9BFJu5gyAaQKfHzPuGglT7O2e5vw0coZlkZK880YTvpTxwxR5iSfuTtT3YpeVEEb33SphFpJyN1s8pQJyrn+2/TCwiEdT0cahax2VlUxQo1iPskNDSAxUEN5soORH1CjRzYgiBkuUBbjUDDTcdGQNcqV3FyWAE43wp0XQKTYqKMEW9Vvd5hv7r31Uyiq19JKw62+mYlyL+EAEdqn5VBTuj4vjujur75p8mEQ3DLfdqfvqt9Mz+PcNwCu7xXK7WsyLiTpJZA0hX8SCyBHYM+BWKL5KcWs2vS4dHL66RjQg3pTbBf6yM+NH7WMoaCZG9SkABlYZgXRcwaXFRmBDaVsAFLCMXNet7Jc1FTjkegQQJyqpFoxKHNiJg259qrXCwn58Is YfpjDbbD i4lBaoHmMgvzXInqJFIprny8SAoVHJkBfqE6W8c3K8+nKuWTALwKjeFN31+Fy30duDAA883AtbJjlwuHlMy9VkwmkVF/b/TjOS7AbhDYamc/cyuBn9r48a2GWFbZSgZTr3WYqk+Q5561sdqMLrq0buMLzcTjvg1dypETfCw9CLi4Y6qm2rw5PqYcGNpiFbg9Ue8ltH+5XjT+VcnRpmjTDF2s4f7NMDZ7un6qU/nxjtWeQIj2WJ+/RqM9qO/dE72BSWQjXUi3q2DYofEnpiU4AlK0OzqSgBpAh8U2AuJDqBdg5tVnPmq4+66Mi3zGDKyMXCpPn49LlKs+Z8Ke5nON6Knv31rGslH5WSj3uJvI2nhgZLF0vRWfZnz+NXvHX/SvZzz6bqgIdF0i0pQgFQYeIHVQxl/UVZaOy1XfYpFoqA/qFDWVhnc3hB5cWx13jiWvZ33IDXiVG16L/cQZbp7SJcmoHcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 10 Jul 2023 16:04:50 -0700 Sidhartha Kumar wrote: > Remove special cased hugetlb handling code within the page cache by > changing the granularity of each index to the base page size rather than > the huge page size. Adds new wrappers for hugetlb code to to interact with the > page cache which convert to a linear index. folio_more_pages() was just removed by "filemap: add filemap_map_folio_range()" (https://lkml.kernel.org/r/20230710204339.3554919-35-willy@infradead.org). It looks like simply dropping that hunk is OK, but please check. I'll be pushing this all out in a couple hours I expect. However the series which contains "filemap: add filemap_map_folio_range()" might be about to be dropped because of possible s390 breakage. Also, I don't think it's necessary to have a [0/N] intro for a single patch. Maybe crunch all the (useful) info into the single patch's changelog? Thanks.