From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9635EB64DC for ; Tue, 11 Jul 2023 11:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4048B6B0074; Tue, 11 Jul 2023 07:51:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B5566B0075; Tue, 11 Jul 2023 07:51:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27F566B0078; Tue, 11 Jul 2023 07:51:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 17D036B0074 for ; Tue, 11 Jul 2023 07:51:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E65D21C7D95 for ; Tue, 11 Jul 2023 11:51:27 +0000 (UTC) X-FDA: 80999165814.27.4695389 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id D3D3C4001B for ; Tue, 11 Jul 2023 11:51:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wRboR8jj; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689076286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PH6oczCY2S48OMHioiU/D8QJo1+dj2ecfu0k752Tjj4=; b=LknXWcPLXO+jz0ScoSAp5bvOM096CSHhxYaHJXdTytt04pd+Ne8IPSKYDuuZkwYzsZrdMW Cg3qtlSMpkkV9ntO2AeeXfkmaGl/WePAmuKg0OejaaYNzbqmIHZBNv0G6tBrMSnAeCJzwN WftfALNNtjEuzRZM8uCU4BfH4C9Ko3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689076286; a=rsa-sha256; cv=none; b=S24RVPuv13AobMOgoRchTlb+KTlyFib2BfUc/vY9KilfGY/s4VyM+H2h5RIHdlAP3y1tI1 onCKV0ITlzPdiytk6YJ2ly9RCVIq8lCzDskaJ80BaTuevF4h7POr8xUTa75LUWK00Eoki7 40DOUizn5wZRfz1abeSwI6XzumzdEko= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wRboR8jj; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PH6oczCY2S48OMHioiU/D8QJo1+dj2ecfu0k752Tjj4=; b=wRboR8jjgvVd53fKMCoUzQJhAv UQg72sFHXt/ZytZ49FJZOtXcj8j0NFIrz/oEIzSAxkrZUYtTXxZ+ur3YI3Ykm9ajtTdyfCknWelDq FN2K77ByWsqtnsWWD8MK71e4Jezf11ZM2i47WZNCz7mfSpJUl75xQvzq8T8VTbbUIza6zlPCNNcN5 txA1/+XtTFP+MazM7XYSBh04hR24n7PIJzoAlfjocivkjaqWKTAUKSZDrzS/C3y3yuPqIKq3GXlkW p6PB2D80HvcliTu/Vqw3t7VvDxVFdGC0MsemgAy8IqVjJFCAfI4zYdClvlnxVWX+vkuR2xvWbGfnw udGnAVeg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJBtm-00FgYd-Oo; Tue, 11 Jul 2023 11:51:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 36BB0300222; Tue, 11 Jul 2023 13:51:17 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1F640243429D0; Tue, 11 Jul 2023 13:51:17 +0200 (CEST) Date: Tue, 11 Jul 2023 13:51:17 +0200 From: Peter Zijlstra To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v5 28/38] x86: Implement the new page table range API Message-ID: <20230711115117.GL3062772@hirez.programming.kicks-ass.net> References: <20230710204339.3554919-1-willy@infradead.org> <20230710204339.3554919-29-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710204339.3554919-29-willy@infradead.org> X-Rspamd-Queue-Id: D3D3C4001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: czyzpigge7549pzbih774zkmxh4njkfd X-HE-Tag: 1689076285-258986 X-HE-Meta: U2FsdGVkX18pXZv4rDt3uLu/gn72YNO1oIe9xe9/MqQxJ0llmGxup7Pixl58Wqs2F5GybKc76lc3J44Wru284eR+xRhO5JnucaS12t9lOnXnx6t7iM9ihEpoix3UGOuzuIAVfj372rKi+pWIv2wtaVpj00g6zzE8xJFIKLFNcheFTqERpuZctz9qdxR/2rFCrBDHUpVtbbzs0spsxwpwLgcmFGlGcMSfYRX7WBW67F0kRdgtL9ZGNVXUZTc2gmrRB73OoxPJHZ9CZ0EPtZ8iU6ZkoakLrxUrlJl8XvK/3FcekZlKuzpGuk8C49zdwmPrT35MORrls5MoAW3o3AskFx3aoeGeXX/tZZYtOCuAnCGWW4Zgg0Og8xEbO64WQN0QsyQ2IdwiKJGMXZn/Jp8t52h/oJLZ9kj/+43N4ZEMQw6z2f6JgbkUlgWOBYA5TYTTRJIG9mkiuSfS5sVTsSa6wS7T9ff3DfnBTsEBpzVlDEMxw71z+GmpDwCFEnQYMFns/OiFuzfAsP9XnxcHQdHb9EduDAkGGlOceeFVrIv8uZiSFDwFNSrxk7nFuwP+0SONqr0MQ/ftOb9nhDnjKEQN1P6IdGP8WpivBhwNBLRZ5/awDebN6uk7Gg8QDr0NXYPeXG0tv6G2r0llWSHRjAer8hGEVntZ/WRYF4YfgbLtZgG8iD1JhfS6djvhM627UyCsuvDl4cqqEY+qTAGnC8cYRpBkvxHCuwoOeosJdrCS5ChcHOtF8eGdUyfApUsS0D8XBjzNILyQN7Qt8HbS+irbdz9PXug6+wnEDlJVZPT97PqcIY2EylMr/JzUyanbogZ90ORLvQyXUaPmhmdWr2AGh+D7z3tIuj0GjW5mdS3/dYfrvdDIlwYDMSS17zg/0zfhDH5cu0o7IruLjT/9Qeqjb2Lww7anX0FQePEnK3IyZWx1lZHPyBck3+I8BVsKa1jwJpwHj+a+VvV+hp0kySj qSzkMbXX 9TQVCBcpUm06qUdRnhOWf3PAOKyH/zlb6G7cxbjGFKP2UO+BBaVeR5GsE8MjHSXRlisjdHUKGqMPxiDzpOMG5qWqbNLLcWdVqEOODn2FxF1DNzG4n4Lzj5101Z9eroxbz7v5ol3PwiJi+Or0BIKDtXRjhiYO3OdUZRFtUmcXIxhab6gm8BUfqAX0AjhDDkjUPrVJcsd/APQI/y02WSybYorPfohpXFBAxZ8Yb2EuPp0/kVAF1UfGyLCXNfDU0wqFxweEc8uIPFqm/JlZ7uoTT+1gxjzfmYU5mNJkgjg757EaA5PMr6Ur+6MtJUQhgCCiPQH8vIUtNoVVPTau9oK2bcvzzQvRwrEDak/bvAaBAJDR9Dxk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 09:43:29PM +0100, Matthew Wilcox (Oracle) wrote: > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). And it silently removes set_pte_at() :/ What's happening here ?!? -ENOCONTEXT > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Mike Rapoport (IBM) > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > --- > arch/x86/include/asm/pgtable.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index c6242bc58a71..9818f13bfa09 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -185,6 +185,8 @@ static inline int pte_special(pte_t pte) > > static inline u64 protnone_mask(u64 val); > > +#define PFN_PTE_SHIFT PAGE_SHIFT > + > static inline unsigned long pte_pfn(pte_t pte) > { > phys_addr_t pfn = pte_val(pte); > @@ -1020,13 +1022,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > return res; > } > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > -{ > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > - set_pte(ptep, pte); > -} > - > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd) > { > @@ -1292,6 +1287,11 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep) > { > } > +static inline void update_mmu_cache_range(struct vm_fault *vmf, > + struct vm_area_struct *vma, unsigned long addr, > + pte_t *ptep, unsigned int nr) > +{ > +} > static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > unsigned long addr, pmd_t *pmd) > { > -- > 2.39.2 >