From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E24EB64DD for ; Tue, 11 Jul 2023 16:03:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 705276B0072; Tue, 11 Jul 2023 12:03:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6974D6B0074; Tue, 11 Jul 2023 12:03:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 554DA6B0075; Tue, 11 Jul 2023 12:03:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4298D6B0072 for ; Tue, 11 Jul 2023 12:03:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 38BABB0117 for ; Tue, 11 Jul 2023 16:03:10 +0000 (UTC) X-FDA: 80999800140.30.4977BB0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 8363110025B for ; Tue, 11 Jul 2023 16:01:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zckNfeTj; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689091294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tCKa2zPP3GGsx+r/IB1lwHd//wKnjy7AMBQ3cCaolqA=; b=LaS3/vhHFyRgyB8jxPekbDAcUzSUQMS2Q9r1fbUi+FR1xfixpyUi+vb7kTES0nFCTPgZO+ QKvD8u1QbKTd2KnOHKhmEjT31zpG6RzFdUjeWIKuWR2Tdkmnnn4K3ko+/g0e0mLmugNPO8 kzwn56SY6aQw5G8ZVdF7/duATuVcSbM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zckNfeTj; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689091294; a=rsa-sha256; cv=none; b=a2fAB8ukarVMbVDkD+RM2tMOkJtmi0iDYNUFLm/GS8htE8uA08OLw1VzJXVp5srIg2cikN Z1yMxZdL2vaI3ZeqwmO9VMOFirxc4eTuH36AftUNW3xwZykIVnVYZRf5f4usJNkCMOlMGN 53/RG0o/Br2BdwmVBw/2+XrrkkmlVW4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 202D061549; Tue, 11 Jul 2023 16:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F54C433C7; Tue, 11 Jul 2023 16:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689091292; bh=W4jQlbMQdBvo7/FDTvEj5jeyPtiEw/LF6hLHC5rkPRw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zckNfeTjVADMHyofLUUTnGXURxoqX+nnQXOrhYQsdGHTcpkU7xuK9xU1TSXohKsZV Gr4B10jt8jyme7faeeuTKSh30IQgpSlLSfzECc8YC+IbUApBm71TAmZxgCP2soKfc5 S8VuU6DES5kr7V1aK0NlvWdhFt324C2tZXCp0gjM= Date: Tue, 11 Jul 2023 09:01:31 -0700 From: Andrew Morton To: Matthew Wilcox Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , Anshuman Khandual Subject: Re: [PATCH v5 04/38] mm: Add folio_flush_mapping() Message-Id: <20230711090131.20d61e87e4b6983357105e9e@linux-foundation.org> In-Reply-To: References: <20230710204339.3554919-1-willy@infradead.org> <20230710204339.3554919-5-willy@infradead.org> <20230710161727.7a676996b64e9885cc15eaeb@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8363110025B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ygpub1ctuzhiih1weomnr1cpd86topfj X-HE-Tag: 1689091294-293001 X-HE-Meta: U2FsdGVkX188SZnhCKUvHMwOMRFXy0TRp7AzXLBEyg3SjQhLkC9Vwen8yv3JtlXQO4cNcY/gnRsHXOGYy4AVO2B+e+W086xPK9b11BMeyjGVH1NUniTWNVJ3eIyLfc1N6i7+f0aghE03RO308qVSojRuEyng/VIIRuD4aLIwoHFttIXj0jLqVdkaS7AU7Er3pL6EyfKmgMsj0ZHzDOKonLDX5FbKkxNpRfUfaqrbqLMj4Jw1PQtM+GOfy62CZI6nEzijQa7FmDPcJkk/M5htmWiiiMVlaKcO+mTiYAHrILEnNhJ/urWeXpYIuH0DRXX1FYO+AdY4E5xffiVRUklJ+vMgNsMAI4qODHcAID9ZavCqrelNf/ZrtJuOBfQKDwB/rKtjEEX3UHBNtr+4ZLgINpyvcRMg50R01I5bxgiZelYg9KlsI5xfPGMJ/oT7C1o7QRFOUxlIYBswvQPtjB5042AmeIjIn3Jl8vLGA2yEEEEx8efwYeVvy8PII1782O1Ysw3Gwk0DIU7zrYM/a4vnpCJbaOh7o+uwel3VgjrXAjA2yl3WZ/hBOjrY7BsP+3nV66+0ONS5js13vuMbxIECijH/UWRj9HrZWmecHr0RrNObfTgeNYfVnUrKA+1s5WJJG8pZez67e4+DR8eCH5L8TEpJJuEeY/o+cMaWrWVkxW3AmEzBWqAcrsD2kzpvc78qqpqhtB9JFlnz3Gz+2nVrW33cTtvVJsLAVTT7UmMtH92JQExNxK5ZuoVBfYDp3P+6xtVQHfEVKG52zMktruz42gLvK36Sqby6Gk2uRF2Nkf8Qxqh9E+amtU7Dm6Y8cPqCk89Dw8RKpQltb2ckXbQEU5z4HgeRYHb7Q1MZr3i7PcQWxcasT7WmUIzOP6WCjLK/5tbgblEHmY+1dFXm+vkNsln/sylZBPNJNE8OyiOAw/prAX8jhna81DN7p4kD5xoa/BvZxDT2Y6LQJMfyuwL LHpQFryr cecojY3G3YqhpmRPrlOZ2ics25x0R5V5ivFxh/B2XZlWPPdC/UbKfNEUxZmV0w5z7dR+hoeI/QRp7n20IJELmML1uQBF5rMF0YY9hIX7J2Iv8jJzGHFNBHxQL2/r+qYmrPjpFrKJZPQhd9ytCTiHnr50m/ll/pAf4ABmeHS9CycQHe8mGJL19EpXI1R9J7ePz6Q+uxeXkxI2aDdjtSUxTlzRV8JXboyGMNDWnKDYxJ8w5Qu+tMUvqmtfFwtUDYNMsVp3ZA3xgTB0j3ZCaT3orsmWS4mlmzqezYhGqc35pTBKTzt5opT/KhCFUnf/itOXJF5DQA9Zzk0RMpTSnIS6nijFXJE29BmAJpE0ppGxPLECWKW9RxdRwJBSOoexmmFeeWQGIjupB1FENEPLRHgVX/xHO5meGlzBERoCpOAUPz+I7H4ELpsTlKtK9cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Jul 2023 03:33:42 +0100 Matthew Wilcox wrote: > On Mon, Jul 10, 2023 at 04:17:27PM -0700, Andrew Morton wrote: > > On Mon, 10 Jul 2023 21:43:05 +0100 "Matthew Wilcox (Oracle)" wrote: > > > +static inline struct address_space *folio_flush_mapping(struct folio *folio) > > > +{ > > > + if (unlikely(folio_test_swapcache(folio))) > > > + return NULL; > > > + > > > + return folio_mapping(folio); > > > +} > > > > The name makes it sound like it flushes something. Wouldn't > > folio_flushable_mapping() be clearer? > > Yes; I wasn't a big fan of the name, but I wasn't a fan of perpetuating > the page_file_mapping / page_mapping_file confusio either. Do you want > me to send you a set of fixup patches, or will you run them through sed > -i ? ;-) I sedded.