From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF601EB64DD for ; Tue, 11 Jul 2023 09:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 492BC6B0078; Tue, 11 Jul 2023 05:01:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41C446B007B; Tue, 11 Jul 2023 05:01:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BD446B007D; Tue, 11 Jul 2023 05:01:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 193556B0078 for ; Tue, 11 Jul 2023 05:01:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D73CCA0193 for ; Tue, 11 Jul 2023 09:01:09 +0000 (UTC) X-FDA: 80998736658.01.6937A4B Received: from out-61.mta0.migadu.com (out-61.mta0.migadu.com [91.218.175.61]) by imf26.hostedemail.com (Postfix) with ESMTP id EF91714002B for ; Tue, 11 Jul 2023 09:01:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tWhdIP3t; spf=pass (imf26.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.61 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689066067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8prDY+X+iYILjO7R/8XWZU8ZCBnkl0AIfcoAHpqpNkY=; b=fL3eyTwkGbOf4Ooa1ydXoDAunbsNe8JhxznXs2Ibf1o4l2ZgK5yD7ohsuS6d6deMJOu+xR rOAFbffkPifW9uhyffsAMpMQnJVNOwuu6yOL2Im9z+KOsxpsF2Ke1KCsvwZ7YUNpTRMfbL w+NW3OxBF+EW3AWN1zpxbdHHzMQcgIg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689066067; a=rsa-sha256; cv=none; b=Um6F22AEYcX1dGHiNAdBZoD23zNg5SJALoDCJsnO7uudNQpawGLU/oKmSZ+H4holtvhI49 tW0LhkzR+TTbnHyuvsaepCdTNhxB16YgBDuJeNczDbpgkP4WRe7Pr2dw4725cT5pz9Nu67 sz/wpGLYHEnRPRn72SrsvIRSG4+lgUM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tWhdIP3t; spf=pass (imf26.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.61 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 11 Jul 2023 18:00:54 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689066061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8prDY+X+iYILjO7R/8XWZU8ZCBnkl0AIfcoAHpqpNkY=; b=tWhdIP3tYXkCRM5aUkWNieZXrrq2a5sekriw98u2PZGTFAhKQ04lUR4ULr/T7/SP9IZJy9 mpgdK9hwzhHjNEvBCDMrQ/3H1D9jtepKb26uuZ7C7RqluYVUHrelF2DK0RUhSPhc++HuDi ZffjFGticrD5KjU5UzVV/sT1jNeOCQE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/8] mm: memory-failure: remove unneeded PageHuge() check Message-ID: <20230711090054.GA2221061@ik1-406-35019.vs.sakura.ne.jp> References: <20230711055016.2286677-1-linmiaohe@huawei.com> <20230711055016.2286677-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230711055016.2286677-2-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: EF91714002B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: afbin6wwjcskjrursaa3zcayfxezyspc X-HE-Tag: 1689066066-665625 X-HE-Meta: U2FsdGVkX1987T198kweiaaKJxDyC1swELodHZgOH9u3o/tN+WhKeb/iYTCJ55OYJned9V5fGjfQlNoMlcq8B1qN1q/2OabOAFiq3oSfJXedCdhxW9ePuw5LQ+z9uRjb9OYqwway3rkUq++V6S1udR+AgwRjd3IDS+5ZkOAj3+qJhFjTGIQj72YkjA/ohucT1ENlY/nUqkhhnusmbuWpSEHf0WmLxwf4j8MJbGzJqmoycShlBrFDKnCIbGklE/Ve0wx0ylx9VONjPr8NbtivJomnmCo+QYVDIum3Mcjc1Q2utBLaCaNGpreDpLmWYlB7nVm33qi/CJupIJYzUgGbqyc+k1oU2BQwyN3l0cXQnBVwAPJRwDTkMSPorcgBgvfnx94zNDwLMN9HNLBpBsitw40xafsk8pYPU8wlRq9VW7VaxINy7gvJAfHdWcmmOJwIZqMsljgNoHfKsVfEufKdM2DilTnm1cjCSXnTw1CD6fC7Ek1WaL3jRjzQIYK6JsreRJUPhWWezcqGydLeHmd0oDszhrU/QBSTht8AbhQVhB21zEYcNfNT9qcq4yX0Vcq16+/1YrEkKDGrJGl8CYIcniQykKNbjn+PzskMOBmjIDZhvK088yeSmrF12RYwB1XyJTWrmFJc7tOJ98NaTNL/LwXs4f05sAaDJfIyVN+vknzJi7j/CUkJwhhoOrz4rnvWMN5xBmKrefC9CQZf2uZDYz7j9cNlOTNe/oKyni9pKa0nqdCJCiMlU2VwFyrwwZSt5cufG6NIy/x7iG6PjUzU1FXtDlAZqQemihK/p0uGpVf4b2DDDMKMzlHXoebQe1DN1ZcMW4Ykv46K1+18zXpXtoWttHmbq3sUwWZG2GjiL71v5FvzPMmGwPwdqDrXNwoUlv2NaRPrZ+KYQK0WpZGzB8h0ChGgTQhdP/aYN6Myi2pUBAQRw2uowDWLEJx7EN8Wko9slmj7ykJa/FDgYK4 ME+xRlqy rDQhDd1JzWxbpZxMvO0zw0p+gVj92GI6s2os6dJIwCSOkwc2NENyZ81L8PMa2dDQw8jvEH0ELpXLyf7A/SvvLDTC1E9m2OXQ8q5u1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 01:50:09PM +0800, Miaohe Lin wrote: > PageHuge() check in me_huge_page() is just for potential problems. Remove > it as it's actually dead code and won't catch anything. > > Signed-off-by: Miaohe Lin Thank you for updating. Acked-by: Naoya Horiguchi > --- > mm/memory-failure.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 64d7d34c177a..913fcf02ad38 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1187,9 +1187,6 @@ static int me_huge_page(struct page_state *ps, struct page *p) > struct address_space *mapping; > bool extra_pins = false; > > - if (!PageHuge(hpage)) > - return MF_DELAYED; > - > mapping = page_mapping(hpage); > if (mapping) { > res = truncate_error_page(hpage, page_to_pfn(p), mapping); > -- > 2.33.0 > > >