From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] mm: memory-failure: remove unneeded PageHuge() check
Date: Tue, 11 Jul 2023 18:00:54 +0900 [thread overview]
Message-ID: <20230711090054.GA2221061@ik1-406-35019.vs.sakura.ne.jp> (raw)
In-Reply-To: <20230711055016.2286677-2-linmiaohe@huawei.com>
On Tue, Jul 11, 2023 at 01:50:09PM +0800, Miaohe Lin wrote:
> PageHuge() check in me_huge_page() is just for potential problems. Remove
> it as it's actually dead code and won't catch anything.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Thank you for updating.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> ---
> mm/memory-failure.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 64d7d34c177a..913fcf02ad38 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1187,9 +1187,6 @@ static int me_huge_page(struct page_state *ps, struct page *p)
> struct address_space *mapping;
> bool extra_pins = false;
>
> - if (!PageHuge(hpage))
> - return MF_DELAYED;
> -
> mapping = page_mapping(hpage);
> if (mapping) {
> res = truncate_error_page(hpage, page_to_pfn(p), mapping);
> --
> 2.33.0
>
>
>
next prev parent reply other threads:[~2023-07-11 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 5:50 [PATCH v2 0/8] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 1/8] mm: memory-failure: remove unneeded PageHuge() check Miaohe Lin
2023-07-11 9:00 ` Naoya Horiguchi [this message]
2023-07-11 5:50 ` [PATCH v2 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 4/8] mm: memory-failure: use local variable huge to check hugetlb page Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 5/8] mm: memory-failure: remove unneeded header files Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 6/8] mm: memory-failure: minor cleanup for comments and codestyle Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 8/8] mm: memory-failure: fix race window when trying to get hugetlb folio Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711090054.GA2221061@ik1-406-35019.vs.sakura.ne.jp \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox