From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A03A9EB64DC for ; Tue, 11 Jul 2023 08:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 816036B0075; Tue, 11 Jul 2023 04:59:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C6486B0078; Tue, 11 Jul 2023 04:59:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B53D6B007B; Tue, 11 Jul 2023 04:59:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5CAE76B0075 for ; Tue, 11 Jul 2023 04:59:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08D85AFA54 for ; Tue, 11 Jul 2023 08:59:53 +0000 (UTC) X-FDA: 80998733508.29.627DBE1 Received: from out-3.mta1.migadu.com (out-3.mta1.migadu.com [95.215.58.3]) by imf27.hostedemail.com (Postfix) with ESMTP id DA24D40016 for ; Tue, 11 Jul 2023 08:59:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eG1uW4BN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.3 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689065992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3olRG28fHuMVdScfXTk+VChhHoKMcs08gOMMym6Knco=; b=Nzk9OhurKGY1YOAJgXTXlnsvCO/A2gvnu+Ey07bBqXQ4NvgbPgoLfBQrzxOGrIcB9ZSt0t tZ8mkpT15osNgX7tvUa+IjIb13xm3iDmSKdVmu0plevDpvzQTzSlUR8OR9DkuIohLAze+W L2u3u6ADTufTZUrmzR+XEoxtnPC5jUM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eG1uW4BN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.3 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689065992; a=rsa-sha256; cv=none; b=RhXaVTWKP4SRWRZtT1nHT5k+hTzdyB4pN6xqaqR8wWceLVoF20s49VsPsGK/Dy8wDrDbMi 6F3ld+rN1y1UOFu/QTO9nmMTw8UDX2yV7yge/BYaHSGnEPtDOb+6CkPP8UmXZdA+RUWUER T4bFFaU/sgcrEWQAaywq+xNatu6X+rs= Date: Tue, 11 Jul 2023 17:59:40 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689065989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3olRG28fHuMVdScfXTk+VChhHoKMcs08gOMMym6Knco=; b=eG1uW4BNj7Ebz5WBJY4Z7nnNtP2AUxH00bRUZcf20kWdXqy7D0O5EuqtQ/XKewGpVfgrlE FgTol6C228VEUzZH8rWzoVu9Bw3uOLh2vUmN+5lyQ0dsZb6qUIpT5wKZSujYU/CMm6LOil YxytCRH3T7fSHaju40ijdpmgyscymlQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Jiaqi Yan Cc: Matthew Wilcox , akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Message-ID: <20230711085940.GA2220255@ik1-406-35019.vs.sakura.ne.jp> References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> <20230710002116.GA1578139@ik1-406-35019.vs.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: DA24D40016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yuenhtr9x7mt3zfzk1krfmo7ec3j3cq9 X-HE-Tag: 1689065991-324946 X-HE-Meta: U2FsdGVkX1/HivfLNaR2hnYbgWJVDJihoNy6YxR5wpK4LrTmw5iiqGzHK7+Ae4Ictp5W60Z0svW1s+l88SmqZ4NMesoE57WlBRbACV9Bgyzl4LCCZ6Cuqkz5ouZmUPkvb7Dsd1K2UwxR4KbAQXjOtGihSsm6K+EgxjnnIpVgx0UK1G6F0vtRjYUSOQ4uC1NP2wuH1N1BxxncgM6nYl94SLXgLYwiy8euPhtFo62OP2+sZydQZKL7cYIEUegJU+y9JNCFvFSIohX/ItvGvRyf5Bi+ksjrdUoqkd//owtWYNgFnHzBhG6Crym95HeDAuCU113leigFf2y9UKFHuirJjZ/35QWbKodCdJ9S186/QzUJKeZ64BLm8CHfzpzy0ccXKCN4YfCq6IQ+TPrg7Ul1haDPpxe77njTH1mKBbf3qVmA/P9oIwuOZt1SfowGjys7QFMynNvBUIAEGfdxrp2TZF58x4KaWdu4scpDye8goBSRX6HlgI7Qn46i0MLQJn7qViB8pbEKeUllGz0rTSd4+D2P0VLreXhIMS11AyQx8zhnldXL3ilvZQt+JjA8e5C8C6w1zQFe4j6U7RIzi8kbC+bOoLImZbL1/WMc+wuqKMeO67vRmPlIAVysJ8TmGrP5MEMfsh5ZdD9CGP5j6VUzdPZI0uAco7H1rIx12SA9I0n+8JNjyERrdEERQzBNgUDJN/yPUuLlxz7xPfmZCaLEwUhS+dm8rrPm3d+w3/jnqa/tgXUbunivaRcuct0ylvfhzVIMNO7aXsvJM0GmjhIXFIxcCKBcf7SJ2t15JfCB8phTN8n3TCHBidHuWGIAq90JR9Cz17hEwqMMxZNvBUs8fyoNFqmTaApXwtPpZU6JA8IIesHuVehQboMw8HzCwsRp4JP+vFnXa44w/oxL6UCQ0TC0OS2JF5J/Z4pCHfzmfX20xbD48HsIDVx0KIYuGvKgHWc6wE/QQaf4LEBD2Ge Afh9rhYE ih/ZyCCIjsyBmj9S2YOyMAyQTHy/KIxsBUk/1+74Q8Vbh/6s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 08:11:48AM -0700, Jiaqi Yan wrote: > On Sun, Jul 9, 2023 at 5:21 PM Naoya Horiguchi > wrote: > > > > On Fri, Jul 07, 2023 at 09:31:39PM +0100, Matthew Wilcox wrote: > > > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > > > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a > > > > > > This is incorrect naming. "subpage" was needed before we had the > > > folio concept, but it should not be used any more. We have folios > > > and pages now. > > > > Thanks for your comment, Matthew. > > > I think we can address the raw hwpoison page by the offset in folio/hugepage > > to eliminate the concept of "subpage". > > > > > > > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. > > > hwp is already used as an acronym by acpi, intel_pstate, some clock > > > drivers, an ethernet driver, and a scsi driver. > > > > I originally introduced the abbreviation "hwp" to avoid using a lengthy > > function name such as "folio_test_hugetlb_raw_hwpoison_unreliable()." > > Therefore, I prefer using "rawhwp" instead of a longer form like > > "raw_hwpoison," although I don't expect any confusion between "hwp" and > > "rawhwp." > > These are names in my mind, what do you think? > * is_rawhwp_page_in_hugepage > * is_raw_hwpoison_page_in_hugepage // I prefer this one This one is fine to me. > * folio_test_hugetlb_raw_hwpoison_page > > > As for "hwp_walk", another user of "hwp" in in mm/memory-failure.c, > > we can easily substitute it with "hwpoison_walk." > > In this "hwp_walk" case, I also prefer "hwpoison" than "hwp". I can > create a separate renaming patch. Great, thank you. - Naoya Horiguchi