From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A46EB64DC for ; Tue, 11 Jul 2023 15:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E92E6B0072; Tue, 11 Jul 2023 11:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 299926B0074; Tue, 11 Jul 2023 11:54:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187BD6B0075; Tue, 11 Jul 2023 11:54:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 056DF6B0072 for ; Tue, 11 Jul 2023 11:54:00 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C14DEA02E8 for ; Tue, 11 Jul 2023 15:53:59 +0000 (UTC) X-FDA: 80999776998.09.1E05170 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf16.hostedemail.com (Postfix) with ESMTP id C2D9D18001B for ; Tue, 11 Jul 2023 15:53:57 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=I7NZ7oud; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689090837; a=rsa-sha256; cv=none; b=pK1iGVEX9apMZj8VujINtP/EVSHOyGA6w8t3KY2qwnW/OKtNEod/yiVmG/XEwtGJAQ3p4h YfEpxg/8VBuLuHaEikZ7SqgcgKHzxIW5nlvH2Lhbj1FvnhW+BkKtAz+OiqFEPys86srQWQ zlpv38aZHtWZ4CN1fI3nMwnp23vHEdw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=I7NZ7oud; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689090837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/cNKZT0w/ttrTTuQnq2pupPxaZ8+d56ppimt6LWSmTY=; b=KzzPgZ2IhawTejaNYjgWgAbETGJkuIeQMUkhBennEI6TFXlri8kKETtvg22ZblkVvM0SXd MHKXfJPOT4HNXKDzFSnhrzRii1z7PLV5zvOUi143ge1jPifc2xBhovXRHqYtYoV3yFExoM OsDE8uKUY2FJmAJfCr6lJNoOzJVZvcc= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b89600a37fso29754225ad.2 for ; Tue, 11 Jul 2023 08:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689090836; x=1691682836; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/cNKZT0w/ttrTTuQnq2pupPxaZ8+d56ppimt6LWSmTY=; b=I7NZ7oudXfX7DjTOHGibnmEqu5Y6r8jhwGNq5nuByp5Cm8CzCU+gBB6L8H3wfxEBLH PCkIik1Ed0RTDeFUuIdLGcrQrp8GWBfKtwRkSFpJawxZhaTPedElAPQxXBeihxdL+vKe wuwPQtwSgiId3KLkKrEBCOCzZMeONSlUH1xrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689090836; x=1691682836; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/cNKZT0w/ttrTTuQnq2pupPxaZ8+d56ppimt6LWSmTY=; b=cJkPD5wFxOMxg+LC5V1/1nOv35JDkDdhct3xTQCAcngrZNcQOqbK02NSfUjd9ORKZP s+Yq1B0fnU0FFtKZTal/sLiJo5c4G66/lFTUhlqo0R/4g+OgNia4b4F3doKpm4SezXTr STPdQgTUgautRdSaCTN6QmpEhKteaSOjYl4w7C8/V2hJTeaBdCpHV47BfMDoiHwrvB2S daBmKNgmZy1k5G0KdSCwqfyayFHDkJUNsML7rnTgcIfVnZEoEErlaQtHXZtoOynrw7al zfUJSTxhjcyz9Qt6o+aGoMv/Ow58Upc0Vt4zvvM9GvTzVYJlCxfIrP/fFxfJfVqCnURJ V2Xg== X-Gm-Message-State: ABy/qLbK9Peh1/a+Fk3jFfB0yDx8Uc+VLFD6xUKKWPE1m9Aq6bOdEhv+ LbP9cr6I7gX0AxkRyc7RbBQB31gD6qm+npIOq4s= X-Google-Smtp-Source: APBJJlEHiRUlipZEYAc51ylR+oPacMfWIOIrJlTW8swND/ECBm1TJ7EYHrvDwuWGBCO4tdrgDY7W6w== X-Received: by 2002:a17:902:c212:b0:1b8:5bb4:8230 with SMTP id 18-20020a170902c21200b001b85bb48230mr12101183pll.50.1689090836550; Tue, 11 Jul 2023 08:53:56 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i5-20020a1709026ac500b001b8918da8d1sm2100722plt.80.2023.07.11.08.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 08:53:56 -0700 (PDT) Date: Tue, 11 Jul 2023 08:53:55 -0700 From: Kees Cook To: Greg Ungerer Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, palmer@dabbelt.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org Subject: Re: [PATCH v2 2/2] riscv: support the elf-fdpic binfmt loader Message-ID: <202307110852.E093C93F@keescook> References: <20230711130754.481209-1-gerg@kernel.org> <20230711130754.481209-3-gerg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230711130754.481209-3-gerg@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C2D9D18001B X-Stat-Signature: 7mm1ufuuay6j9syh4a35f81ge5uckjj4 X-HE-Tag: 1689090837-606942 X-HE-Meta: U2FsdGVkX18FF9DnPcBJb/3kqmFLUVFDqWoc2t66o5fWv0tSJ/apLeI4Pv7F2btERDunBmDNtfxHM6f++Zei9dgRzc0L8OYVWXA3A1vv1XP3ydloLgs+c5bUrwL4y5R1lkNyOjQMmFNZF8B+Rd5U5e1FMcDcM6999hE+xiexVyiKw6MTtjXH8dNVf/hWYbDhc/nKpB81pkuTDqA8FBX9aVk2VWU0VD14hAR4QplIgCOvxrayqQAEfjHGrD3/LzSnYe10th4spbZnh40G2WVHcP6dlDjSEAP5Q6VyZ2zc91EqH0vnVlLegBWEPweZX3/uhlFz1dTynIF4QvuvZKmTmn+ccBAaTqFHm3RvDrpXC82bzhcm9KmkngGxIsiEr35Z1C2DPb6Ej1v5CFhulNinKwFVsaK0+K0nKcDVFl5mb9pKKRygS9TGWVOKDefyUAxNnpD3fI7/9d3/cA8cSdgfDKVErFnMya8l0qpVSbHMcViVp0+AST9yrGFVTw7Dh+B1AJ/a/eplwrR7F+XPhlx5n8nzN+vWjED0uUXyoipNbAC3lFk1lP/zuUz1WMoyGLoUdgYkIvUZkfkdVR7PZpHgp5wktlN64+KlyVSm747itv80wC8vs1mBAchQbN6N/izK0NaejzGLtfx/LWDponTjRGOVCxcdAqvkoxqzLMXCvkys1OwlO3NE7lp+wFcNipjfskhR0By5dgTIRETJBT2cEhwFDp9mIEGUkJNauCdvEo0L284XTY5ycbnedhowC7RlAVpOArMk1WpuL+1gUzyrQvNXDFcXVsw6scv8nFUKm9Boo+ZDcZJjNZcd5lg/0q8w29JRAVZMGAWrAecezmaVw+47YRzFN5FuqpIPVmQsomSAejA5yNHXWMFgzvGVQTM1FkEMZqqCbTx39E1qTC69Brc1cw+HxDd4Mfz2UGnnUBrXnK9OnDZ4bNzkbmfBSpUZX+D/f/wPFckvVnpXCab GgrLpolO F7auLUuYYK89vnr/fn8+9d5dAM++0Yge77R1deKSUjeNJLUGN4uhpEaQJWhiZBoRobWkU3FsZJdZjqxE142JYL+X2OKHH4qWm+b3+4yYRUE7WwR2pzsUXzC766qweEMI6gQ9dVgvWCm+oa6Y9xI4lvsIHGTm/SIe/cGFl05Ef2RIN3h5pIgDpbJoAmZcVhstjvtqLyu4NUyjByBtwz+2vKtGRUbJx9CG1NvT2ZgUovm2F9E+A6zPXDDkLA9vY3ihvKAGVgqIIURgDkz5Adsp9VpmcT+9bQpA3z0XZQ33PrG9iexR9UIqAo14iOG82+ySh20kgDWTDY58HMxnoG/38RoDKdRzEQqG3s0jC7CCv87sXcYOmwV+Nq/gSuKNsFNdF7u8K/KG45SQNYYm1q3nr/8lLK/IdCZfn3195kZ03Lr45iGrlYuVMIRQfAc6qX3qVJlrYR2QqU1CIOMkNMVxIF0eezA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000056, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 11:07:54PM +1000, Greg Ungerer wrote: > Add support for enabling and using the binfmt_elf_fdpic program loader > on RISC-V platforms. The most important change is to setup registers > during program load to pass the mapping addresses to the new process. > > One of the interesting features of the elf-fdpic loader is that it > also allows appropriately compiled ELF format binaries to be loaded on > nommu systems. Appropriate being those compiled with -pie. > > Signed-off-by: Greg Ungerer ELF stuff looks fine to me. If the RISC-V folks are happy with the rest, this looks good. Acked-by: Kees Cook Please feel free to carry this in the RISC-V tree. If you'd rather it go via execve tree, please let me know. :) -Kees -- Kees Cook