From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87BFEB64DC for ; Tue, 11 Jul 2023 15:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4493E6B0072; Tue, 11 Jul 2023 11:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2BF6B0074; Tue, 11 Jul 2023 11:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2736A6B0075; Tue, 11 Jul 2023 11:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 14DFA6B0072 for ; Tue, 11 Jul 2023 11:51:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CA0F71402F8 for ; Tue, 11 Jul 2023 15:51:42 +0000 (UTC) X-FDA: 80999771244.17.C2FA1A6 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf24.hostedemail.com (Postfix) with ESMTP id 04EB1180005 for ; Tue, 11 Jul 2023 15:51:40 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VEHl1YDo; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689090701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h0Eo8sEWwi+QlL6TwKCEAUf0c6tdOFvYOKUGXKFLpnI=; b=Yzl6Jw8TVa277krJzFJv58r9+jBAtCvqSB8gLp2WTHnZXNgrQ7zgpHh1rWP1bDSTEgLUe2 4YkcnMJ7Xu0eYlEB6imvSO5JQBgv5cfJzD2gNDTdVDC8eHJOu7xSCNncsY6HVIjA54wTj0 jjfUlMwrlrEv6P+0j+cue0xwZNSnpqg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VEHl1YDo; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689090701; a=rsa-sha256; cv=none; b=bzwBTskdijF9khE9Zo1RooijQ2Cg4GlzzRFdkyoxXdni5vTy++NB9QFMWvF3Dn6JsgqDSg X6T9DAfuePsr+At6HyZWsAReFSLNOZAVIgtT9YPcrpPtGqjnbdqpf07Y458wIjTNMhZWsx sVOGq433yOepb5rHeCNn1xlHda+8bL8= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-666e5f0d60bso3352898b3a.3 for ; Tue, 11 Jul 2023 08:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689090699; x=1691682699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h0Eo8sEWwi+QlL6TwKCEAUf0c6tdOFvYOKUGXKFLpnI=; b=VEHl1YDonMq0agfdUsVKQhxo8RItH5aI7RFQLbPPlyzgiEZLoC2QTbgKfhaUAXb0Xs mt2OV6GTXYF+7hq2+LNiL0/ACbBpJ/nlAWB7DJdT+a6lnDl//ZGmngeWOxRP9eIddcv/ F7Yri1Yx+qPeciVnr2KrQ5EVMTSFWvZEHVvVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689090699; x=1691682699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h0Eo8sEWwi+QlL6TwKCEAUf0c6tdOFvYOKUGXKFLpnI=; b=ADv/sLw5bCQwnBdTug2xrBZklVRU6UsEvFVEAPodA/4djlQFVjLxxMf3ucpublh2cn kyrXkedkfy/9VxL1WOw4rEgpQM6lMyStrSwYVtPSnZGXyYME4uAmminVyLOn9gXWZAEL uqQCneEgnixtAlwrO6iaKOgHASd4wk/pibpg/jA3iUpAVpEWcqG+uVE7p7b8wPlhrQTM HC9wyIpdrdeLm22zZb5eWBPOWu+fEP8BEeAduOD5cmQIInRavofGSgem5VrjCo2Z4GsG AB7hRoELhLayPY1mXkvJlj94wkIW7cPrazb+Y3D58WLr6XgXAukjNeHxX682pUn+IkQh LmHA== X-Gm-Message-State: ABy/qLZRn8N35+NAd3e1d5FlLzbXSfbFnqB4dgUPhVxxShInbRA4rQ5z oMW2unYvaSYSpBmeyWZ6v2SV7w== X-Google-Smtp-Source: APBJJlFNryFmhWoGlqCtUbbFGrpblHly2Pt7q3F0N7u90O+eVHxQGOhARPP/AvkikwP6Li4cyHQmng== X-Received: by 2002:a05:6a00:22cd:b0:674:1dde:4c59 with SMTP id f13-20020a056a0022cd00b006741dde4c59mr14931253pfj.28.1689090699562; Tue, 11 Jul 2023 08:51:39 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x13-20020aa784cd000000b00682a61fa525sm1934182pfn.91.2023.07.11.08.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 08:51:39 -0700 (PDT) Date: Tue, 11 Jul 2023 08:51:38 -0700 From: Kees Cook To: Greg Ungerer Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, palmer@dabbelt.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org Subject: Re: [PATCH v2 1/2] binfmt_elf_fdpic: support 64-bit systems Message-ID: <202307110851.7F2EB003@keescook> References: <20230711130754.481209-1-gerg@kernel.org> <20230711130754.481209-2-gerg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230711130754.481209-2-gerg@kernel.org> X-Rspamd-Queue-Id: 04EB1180005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ten1thotbhsmj8nnifz4hh7qgtrzj9w9 X-HE-Tag: 1689090700-254721 X-HE-Meta: U2FsdGVkX1+4syPftS2fZrNsxF9EQue8w+oXRLbXtX8KsOmCEAVm43bOjfNaFyFLiaIa47NwRAWigt++93kG0payhwiaJfSgODN4BC3URjWikGhlacM/xxsHIEa2xyAFxuj84OQPqNdf3a5sK5riN9pepAk+paPvAusnix0Lgte+UxRhHAt5HzGL10V/jJr1xodV6yVvhf9nOcSjUrZQrXaQ7Y782K8ALEg8YcP7fOoqHSkJ9aMJPG4Hk3tp6H7X9jImjfxDnNMX8Z2sZedInlj1Ie+J3IgwoQUdn5cvHZCCgst5+zlJlj4EvCevIT+wvf3zwpPNoCAUYXmuigUymrlPm6suKe7PTebfSA/TCf0bMhPRO99YtabfgA69piC6vn4RK43eHO0OtIM5pJg8lGg6Hu/Td+jJ4Hn2dGe3z5BLodvEYkDIRHv0Gq6dgtKC+BxAE7Bc1RHIt4szHP1GdskRd9Fh0gWt0ms0exIi2XUxMYKm2ihbgJrfKOPSnNFqinjOb4TdxUtgJWZkX1FN4dYXh7tjSGq8fJ1qsG3Utbq6MsgvZZrXwFfeCFZOMmxrqi1Bx/gImEDTSm3VWYXLDsmyNKRrWOvDFXjOFCKKU778Rp3jqN8TqkV9gjgivWXa0YCx+2NhjNjxSjlVc/tfd7I0w5LiwOuYMvIVS9UOkCvT+xOqlTPb8aKk5A3wj2nVRvFYs0qSJErF/3VbbN8ECOnbY9MiqtmIZyjxo2WdPlWw+TvcjvqWyjtTeKcerlcaBGtfdVEd+WwXfRDwSLtMI+FerSwwV/52PfjKO5B4gXY7qQx1Pr1YEKJuK5uKbZc1lj1lzYRZULVsTs9CUs5bCmQn8vNWdcXM4w4nDVxPRIQjHNwm6y37AwZ4+677yFhMnlwX/fUy4XPzRtrDW7AIWUBvdhPyVefWfZtKWbA3KCMQyzoSWaGcZRr6eXBVTOv+1HMy05eKUKKeFrjG6Tp EnPV6gnC Z3LuzVlMVoEqvB+pDsucDrObxYDvMYGWG9AVLv9IPQ3RMy8Iel5yDKwlARQxHM3uGE6jGD2oAp2UVGJMZY506M0hCU+zR/6W5rnbXqYqOyzQkaXM3p0lBS9YfXoalUM2IiViFuS4CfjQMmmarGLCavWPRwKBoOQHPcHbVwPbueN07y0VTcIoxKFZ5KREE/N3g/E+dVSTzytvkwmuI/F1T+3i9ywCJmwwsfF4uEMV49vM+jL2Tvjj2Yt34gKW21qAqDwCMEeyEMTqwc0hEAYt2l5L+QH3WgobzyZOT8l1Y40jXySJjytXIRljyOU9vBl8XD24G14m/vpC26AMdu72qykymjOzbvFn69ye83/ANTnH4RHb41dlVJu/3I5gDdP8sSrJzjJMrj2NW/B5ogFBNeiimDY1woDlggzYHSxgscQA8sLcoYlExldqfsvFjy0V71588NE0ydlKA7lAcR9t1thX9PigvwI9IA2+Y/Vgt+AemDXbyCo824/eyHk0vAuBhRTumtRlznbBdnp0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000351, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 11:07:53PM +1000, Greg Ungerer wrote: > The binfmt_flat_fdpic code has a number of 32-bit specific data > structures associated with it. Extend it to be able to support and > be used on 64-bit systems as well. > > The new code defines a number of key 64-bit variants of the core > elf-fdpic data structures - along side the existing 32-bit sized ones. > A common set of generic named structures are defined to be either > the 32-bit or 64-bit ones as required at compile time. This is a > similar technique to that used in the ELF binfmt loader. > > For example: > > elf_fdpic_loadseg is either elf32_fdpic_loadseg or elf64_fdpic_loadseg > elf_fdpic_loadmap is either elf32_fdpic_loadmap or elf64_fdpic_loadmap > > the choice based on ELFCLASS32 or ELFCLASS64. > > Signed-off-by: Greg Ungerer This looks good an is consistent with what the regular ELF loader does with the sized types. Acked-by: Kees Cook -- Kees Cook