From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH v2 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages
Date: Tue, 11 Jul 2023 13:50:10 +0800 [thread overview]
Message-ID: <20230711055016.2286677-3-linmiaohe@huawei.com> (raw)
In-Reply-To: <20230711055016.2286677-1-linmiaohe@huawei.com>
If hugetlb_vmemmap_optimized is enabled, folio_clear_hugetlb_hwpoison()
called from try_memory_failure_hugetlb() won't transfer HWPoison flag to
subpages while folio's HWPoison flag is cleared. So when trying to free
this hugetlb page into buddy, folio_clear_hugetlb_hwpoison() is not called
to move HWPoison flag from head page to the raw error pages even if now
hugetlb_vmemmap_optimized is cleared. This will results in HWPoisoned page
being used again and raw_hwp_page leak.
Fixes: ac5fcde0a96a ("mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
---
mm/memory-failure.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 913fcf02ad38..feca3c4068a5 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1920,6 +1920,8 @@ void folio_clear_hugetlb_hwpoison(struct folio *folio)
{
if (folio_test_hugetlb_raw_hwp_unreliable(folio))
return;
+ if (folio_test_hugetlb_vmemmap_optimized(folio))
+ return;
folio_clear_hwpoison(folio);
folio_free_raw_hwp(folio, true);
}
--
2.33.0
next prev parent reply other threads:[~2023-07-11 5:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 5:50 [PATCH v2 0/8] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 1/8] mm: memory-failure: remove unneeded PageHuge() check Miaohe Lin
2023-07-11 9:00 ` Naoya Horiguchi
2023-07-11 5:50 ` Miaohe Lin [this message]
2023-07-11 5:50 ` [PATCH v2 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 4/8] mm: memory-failure: use local variable huge to check hugetlb page Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 5/8] mm: memory-failure: remove unneeded header files Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 6/8] mm: memory-failure: minor cleanup for comments and codestyle Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Miaohe Lin
2023-07-11 5:50 ` [PATCH v2 8/8] mm: memory-failure: fix race window when trying to get hugetlb folio Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711055016.2286677-3-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox