From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B0CEB64DA for ; Mon, 10 Jul 2023 20:26:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8DA78E0001; Mon, 10 Jul 2023 16:26:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3BD08D0001; Mon, 10 Jul 2023 16:26:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2AC08E0001; Mon, 10 Jul 2023 16:26:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A22398D0001 for ; Mon, 10 Jul 2023 16:26:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 705D180246 for ; Mon, 10 Jul 2023 20:26:16 +0000 (UTC) X-FDA: 80996834352.30.15527EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 7EA9814000B for ; Mon, 10 Jul 2023 20:26:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UBgdqqvt; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689020774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gyH01PtizYUL5Svf5755bncRciNTpI+JDWU8HXJ7t6o=; b=jF79fUpQodhg0ZEQ/dKqs8IcPZDMKLdCFIEJKkSFI4s5PWAeWeGL7LpE5g0eXhGDKLd1c6 jYGDwm2uiQPlf43NSeT9WCELF5GEiRfu+Fexfv9zSJgShqbL1kvtCOVaHDATfHuhvMm+KI P0sojLXa9fIuouos0RWzELYwb49nOD0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UBgdqqvt; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689020774; a=rsa-sha256; cv=none; b=hFe90RFsMLxMnSF5I/X1Fav47MWox3+/up7o+QxSSHjGZiX5Dvt01FRqFw4TA7VNAuD80l 59PtYvYhlQmIxn+u8mmw04Y6c3gpLgTqTfNFalrJJJgVTTOWvjHUolA9c0HG8t99DuYi6c Wvnj5P3Ba0G7Ima351Qb4z36E/2pvaI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41B53611C5; Mon, 10 Jul 2023 20:26:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AAD0C433C8; Mon, 10 Jul 2023 20:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689020772; bh=Xjx+HnYnS65YQoXatRuMi3xuh6WSWvutNLaaTXSjmko=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UBgdqqvtm7sLAyH42SzguqVkleEGLdFy5ZE6qE+rQlIsaIfZSqgRARIqrMtGI51yh qGgvheCjkZYPDKQiZNGvKdjdUbOF1fuoXER7AoVIvZo0BvnDaisoszvYqQsbrbH6Gu c0GfnqKot1svigDw/XN/SGEe48D56tu1Y7DAHcZY= Date: Mon, 10 Jul 2023 13:26:11 -0700 From: Andrew Morton To: Yajun Deng Cc: corbet@lwn.net, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, paulmck@kernel.org, catalin.marinas@arm.com, rdunlap@infradead.org, peterz@infradead.org, rostedt@goodmis.org, kim.phillips@amd.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] dma-contiguous: support numa CMA for specified node Message-Id: <20230710132611.ccf619f06f3ead06986cb7f4@linux-foundation.org> In-Reply-To: <20230710074944.3501810-1-yajun.deng@linux.dev> References: <20230710074944.3501810-1-yajun.deng@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7EA9814000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 98193bjuhf4eo85xf1ztjwwgyed47ssh X-HE-Tag: 1689020774-498077 X-HE-Meta: U2FsdGVkX19AVyuvo+neRQV76RIonh7nYCsLgAACzqvA9mS5tEjy9x7DLZoKpMqyI9y2FOWy4NfnUNxdoWqoqyg7f8pJr17RD7uHBfcE0bNUhQF9KWRhBLARXd++eUUZX7UfeQIrmf56AQJQiz3o89IxAURNlQPT48Wli6E5aQaMUhr8ZPOcCgkl15L+Thr5WFpIJ/5FXwSswecKY8hZ5ER+eUV/yR75oYbvJ/nfFDW8R9WHCgL/M+8LoEajnvclxGEb6WQLb3MpcokGJdOwat2YDmGwNDNctl+VFjDSQliola0THihkbfbJ7uq63b1kKpVHezIGbO0SRiAcpavvOAD6xfks+haLlvSzZwuJj6/B5iYnHsNtQuYm0vvTeQ9qZuFEQeEKBHFQyi7b8KlxOovd2i/bEgw9VumvH+t+RsHVqFoZyzsaGpYpuT8Ic7rvMHlEaebmkNzMclK4bCyiE39PN+FpG7iXIjcOEDDPYutsdOzxyf6ZbzDCx/g4dGSmAnL8hkLjpQcfDGZarbL49CxxD0HmgANqmi8AjISd2h4rsXyigDyjUrGm7OGj6kycH2DkvZSPwWWiRtZ5wiotSaLL0IvAja8uH+iVLuNNIe+amVk16V1oFDIjjk6FHmUqnMiyWwjp0cn9U60eMYKc2O6S98g+DI9TNzi20XpGmF36l/GHEVi9VSXYEXHvVLakONnXfj+6Fj+4P3foUXk8dL6IfGihri3hG19W/ap5vYMIhDdE3w1H5QbqhCGHQ+UWwvLI48UTftwvgAVAMFi7lDXWAdH164A+2JCGPbqsyVBq5VPIfgFMYrmawRO82SZpDm8OfqkE+EU6K9yWRe3ZNE47V19Rg99jnx+NwftygGreZY/GB6dYni0OAaQTVwSXiVF426Vk2zHK9ab+7dGWx9RIaF4INbAafxadNF04U5se3p4I1uunyEphtyZQYm7jLV+AVn92WWWdkfjni+o 4QFKvgva 6ihMaltDqEYUqsxDsx7g79/vdV1naCPg2OQV8Usex0B15sg//Ubj21DJgA65I1xF05TE3W4DuyQkpH0Km/qJl1SbQRFzvbZPtA0vgyobZGACN2IEMxA38x6Dp0SKfIHmDNvV++AbgrOtUpLVOMdl1/vuY9ks60UnI6mS+uxFH40Q1FvZzilUXXyA1O2da2AjRlcJ5K5xCl7D8+FdnrnOyBtr4/zjMNVDUwzsR23Y0rIj/VjhGP5dG0SuxGCGT4psJEOOxYji7FbVTXQiOmKu13dF5alV4Y5kyi1X+Uf1gb1o2Ft2Hw8b6tPAA7a+6hhBARaLTNWs6V19xeWo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 10 Jul 2023 15:49:44 +0800 Yajun Deng wrote: > The kernel parameter 'cma_pernuma=' only supports reserving the same > size of CMA area for each node. We need to reserve different sizes of > CMA area for specified nodes if these devices belong to different nodes. > > Change kernel parameter from 'cma_pernuma=' to 'numa_cma='. If node > isn't specified, it will reserve CMA area for per-numa node. if the node > is specified, it will reserve CMA area for the specified node. > > At the same time, print the node id in cma_declare_contiguous_nid() if > enabled CONFIG_NUMA. Changing an existing kernel parameter will break existing setups. It would be preferable to add a new parameter for this?