From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DAF3EB64DA for ; Mon, 10 Jul 2023 07:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8E366B0078; Mon, 10 Jul 2023 03:58:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3CE56B007B; Mon, 10 Jul 2023 03:58:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05EC6B007D; Mon, 10 Jul 2023 03:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C2C516B0078 for ; Mon, 10 Jul 2023 03:58:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9432D1602B0 for ; Mon, 10 Jul 2023 07:58:02 +0000 (UTC) X-FDA: 80994948804.05.2D75BDD Received: from out-11.mta0.migadu.com (out-11.mta0.migadu.com [91.218.175.11]) by imf15.hostedemail.com (Postfix) with ESMTP id C8ABDA000D for ; Mon, 10 Jul 2023 07:58:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kZwcshxc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.11 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688975881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N49N5zz7PJN8d+71h+5mF4vSm+C4rcP6xT4u+oKd/Og=; b=yqLy6rIeoU1+8278vSDSQTSNNkBc0InNRqV54YrmyiGeNHCr/HcJ7yJH9+ixqRWTGJaERy EGkIGNQUMjykS9gtQn5kQ9rspD9ree29n0QOisHLRujqyRNDylQJsNoSU7KEgIo+BTFRH6 XAFskitbYXsxfbdLzNee5ANsNzjc2i0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kZwcshxc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.11 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688975881; a=rsa-sha256; cv=none; b=ssArTHX/NQW/Ww0uof/rFcFpo0lxI1JAXNKR4vSTj10KOtU560xWgj/JqlNO21UhnItTrN aej7lZuFySZaWK7QnAhB3Tf3Ii5bhwlu7oxHjKPfuF8NdTDVKnfxU0yUGE+EPT7+5/wOPW wqkYnw/yTQsP5MmSeVA8ovakEICJftc= Date: Mon, 10 Jul 2023 16:57:54 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688975879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N49N5zz7PJN8d+71h+5mF4vSm+C4rcP6xT4u+oKd/Og=; b=kZwcshxcfisGNakXAiOWcwE2dZ36F5epybU6sT2TAr2Gzq2MEK6aBJ/Sc1ef29Dkvo8Kxe rAJO6GBnHJwBlrgMayM3GlGy7SgVf79c5kaZyPhERgesYKEPDIPZiQ3FEJpvLw34nb815O Vji1UMCcnHw9liV+Ct9/cSntK+8/Hqs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Message-ID: <20230710075754.GG1686200@ik1-406-35019.vs.sakura.ne.jp> References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-8-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230708085744.3599311-8-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C8ABDA000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: q8qmtkc9q6uzcqeq99a7w9u873fsjpc7 X-HE-Tag: 1688975880-62334 X-HE-Meta: U2FsdGVkX1/Gjjm7AHkpFaMs9DQX334cPCsaEOzti6Lkn75Zx9k9ceFehHpOZusFgg6RbeO5/nPx12sxu7LzEwGcATJHc4e3cgYLbtRGO84L0xgbMuqQ1PZ3n0KCoduE4MqC07qp/7PW2Eed3lNKDmKxyMePy8vv0hLOZwK1jolFll7AEH6RkEoWz8dw48kJY0E8oKV7qHwh4X2hsITyIkIk2jMic2DZ669IIxO7reGLPSxogBV5dHMDG7V/dEPxtJrrYRv0dZkCby/INZxAcgxm2XoWSLTCbEd9oEAXJGUsPvw7Av6prPzRmmLysOxMJdw/kZsuxM5bG1e5O6Gu667Lt/r8wCfWyMuSoIGIWrRI3wtGgC5A2qu84/vhHzX5OqIoJ6vkwGKHdiLDmL+bvpj0Dc3lI77fVKzTPIj6HMpKdyO2CDi+l1fwXmdHE0mZzfYBRu48n4EROSvI9SiwPAh8Ni/6zLA1N3R3ZpC125+9DE9Nb/VYi/adC2cous4ZuN1a3Nzn7Q5HpOXZLwYuLZwblh2VNHCc73L4nDDL68GAIDsHMFkjfQbcCCPV3ozb1kVikYXanAHAfmxfZ4Rn51s51+jlOxRYaY2QOZTVEtDMfRSTc1YTj17S/tY9FI2KULQgXu6BfsrpngDwIJh7sUIRmna6giWLtNGsHl49E0NxlsDDNJmbUFEk594df9xIXiAe3ujr8Pec2QJ/To0ZRH7EwUd176OQ59z6AQ5wYHaVVIwxb2MnpduWburYviH5H6gljD5apHTZgUpjyqEtNQCEvxbuyj8sECdtZXX5r5ERHgSFqZCNHVdm894lgco0GLsfY6ci7eaxDkDYDe8N8gu7C1bDXFE+14LD6fyQgscnV0Gcg/TrNE0061TD9jLAWUb7edUlT12DZHBIfWLITQ6EJ7xPqpD27UqJz1LHsy2v3CKCkMXhbZZ/GGHjmwyeU02RCs0/4ZbQGIvyKRO OOQTkcB4 b4AOcsEKU6QLL2gUyjGyxNsJu3eLoN1bRHFSDDiTIO9rp5Igsgmu8y5hnl62Q/idIgfzrm7BsIT2V3tbKRMEPB1gwtFW7BRiTzOlX X-Bogosity: Ham, tests=bogofilter, spamicity=0.015604, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 08, 2023 at 04:57:43PM +0800, Miaohe Lin wrote: > Page might become thp, huge page or being splited after compound head > is fetched but before page refcnt is bumped. So hpage might be a tail > page leading to VM_BUG_ON_PAGE(PageTail(page)) in PageTransHuge(). > > Fixes: 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling") > Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi