From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4D7EB64DA for ; Mon, 10 Jul 2023 07:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195BB6B0074; Mon, 10 Jul 2023 03:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121A56B0075; Mon, 10 Jul 2023 03:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F01186B0078; Mon, 10 Jul 2023 03:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E03EB6B0074 for ; Mon, 10 Jul 2023 03:56:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B81A31402D4 for ; Mon, 10 Jul 2023 07:56:37 +0000 (UTC) X-FDA: 80994945234.17.CE16B31 Received: from out-47.mta1.migadu.com (out-47.mta1.migadu.com [95.215.58.47]) by imf10.hostedemail.com (Postfix) with ESMTP id DCC15C0018 for ; Mon, 10 Jul 2023 07:56:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XJHHkkQB; spf=pass (imf10.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.47 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688975796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vh+sVUb6EpExqidiOoU657ohaTJ+4PLiupOU3kMGhgo=; b=6CvtUzheOj8+APtpdfijEs49DJttgi0GU4Elb7KMz/zUfoQdiblaUoKHoB2/rLpC8ucmQj VqqSN3iP9A8BOg2MK6IUfRf8qsPjcQBUkyyYBkYePITLCSB5bRvV9sE72006ClZYt5f17m KCrbRmZNhms4O+aG7DdpIeU51AnbRXw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688975796; a=rsa-sha256; cv=none; b=5O9z6AhWDEwGkEsbsq+9ep61e7/yROKQqBJpFjzUL5yeNsAgFpZGq/4Yh9+Bscnj06diaC 6Y2zX+7s3t61L4QhcNIdwpTzWyXq7w6QHLvQoUQcdECw8jj9MmTQF15PPQYA6HRygYx7BR Ez9euXfDjQZsZ9YrWszaj43zDNfw/5w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XJHHkkQB; spf=pass (imf10.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.47 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 10 Jul 2023 16:56:29 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688975794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vh+sVUb6EpExqidiOoU657ohaTJ+4PLiupOU3kMGhgo=; b=XJHHkkQBwCS2yPSjgk53hE8LAHmHvPptVCTz777HzFEiL3tL8/FUiXdabD0kceMPi/hBl4 y2Rp3svjUriygtlKMbyDqFe7fejdcWaGJLuK8979Dkz9l4q05xkJNJFYoeYeCOmt2NDWQv 1D2RwCbUMYROmofHbnQYLnnNqXz+K0M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Message-ID: <20230710075629.GB1686200@ik1-406-35019.vs.sakura.ne.jp> References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230708085744.3599311-3-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 79zhuw5rehsc7aapn14azw4mmm9pmsjk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DCC15C0018 X-Rspam-User: X-HE-Tag: 1688975795-168550 X-HE-Meta: U2FsdGVkX18a6MRAchmEd3K3H/+jILutrkYprf6AKKfuwuK0Ed66/sR1hdmvb7ryjTFTjJ51nZyfUdTGGDHg8QP/g1ogy3EykloZMleFMnwR6ahkFdf8JFV+Qda2rpAcprsUOo0oQzw/tMw9UYvgoTlT80El7sSeXFJjNLkw4btcuxQfNtSYQ/lqBRyqYVxcISWQ0ksVwSZ7OhFp0xNqifDA6Ct3oWbBJpMcdbQZcKTsTXv0fJBVBa6RBdbrsv055vjsKakTUJm15PwGpJ+D6n37H9ajTz2HTr/O1HbQ2gqW9T6/tUbz8+DdRbtXBdpITwbj8YbdyNYGc3cq9L1HAz4nO/OIMHJ07J48JYAaGS2IIlQ/Fw5t2DXJXwfbxSe5ZM/ahuimLnfLVRc9GsRbVNfh/nL7SB8SmI+3KVM16mrVre8BnLjIAhz1abfZhmZGqU23CAZvWLk6Li4aAECCCMW+XPZkIerj4wFz69Yog01RSiLdy+x9LD77Fi19m9rzYEvMUp8RA3vF5H7v5idtIUXQ2SR86bEYFtoyIY3b+Cf7iTDZmDTLE9kqwioUuSGsUijHcOh1wxeDkjC1PIhy8+OOsZQDY62f4qgyBZkESbf86D/B6vaNjtOMFQpJ7/M3ppz0qqOCY6qA4jr8CiW1yravsunoISRjBZViFa2TseRPSWXI5H7w6dBarkZBLMKyeQpwa6oH5J4EAlxxWIt8d4BC2ayqqcnn0xSXka2CVduz2O5IWgBoddab/NIpJAIc4hGvTi6gkvId+oVjP2zK73EBl0pttU5IILPrNygRbGBN4Gn71NOD7ThI8vQQPw0MjGsXHRErbJk9+9hlZxHirZWhxXnkol6UyL8rUalLXfIPCX91q4Xl94LNtv8Zf0939euEuaWme0v0a2gvpbC4zy8ifrDN113SIaOIdzL+No87VQF1eFml/RIyk+z+N7LMwGb+ZoRpjNZ7ilnBvev 4EvAbs1C H7Cdz3lojK3cV0npDPeNriFjqHyLud4bPqFIjacJRNI5KHsbx8ZYgMrsktY4ZLEauaPo4qpeGSHNB4oRnZw5vu0rMSbrOX6Pf+ded4WP71NzctGBKsGtm5zTEYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 08, 2023 at 04:57:38PM +0800, Miaohe Lin wrote: > If hugetlb_vmemmap_optimized is enabled, folio_clear_hugetlb_hwpoison() > called from try_memory_failure_hugetlb() won't transfer HWPoison flag to > subpages while folio's HWPoison flag is cleared. So when trying to free > this hugetlb page into buddy, folio_clear_hugetlb_hwpoison() is not called > to move HWPoison flag from head page to the raw error pages even if now > hugetlb_vmemmap_optimized is cleared. This will results in HWPoisoned page > being used again and raw_hwp_page leak. > > Fixes: ac5fcde0a96a ("mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage") > Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi