From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages
Date: Mon, 10 Jul 2023 16:56:29 +0900 [thread overview]
Message-ID: <20230710075629.GB1686200@ik1-406-35019.vs.sakura.ne.jp> (raw)
In-Reply-To: <20230708085744.3599311-3-linmiaohe@huawei.com>
On Sat, Jul 08, 2023 at 04:57:38PM +0800, Miaohe Lin wrote:
> If hugetlb_vmemmap_optimized is enabled, folio_clear_hugetlb_hwpoison()
> called from try_memory_failure_hugetlb() won't transfer HWPoison flag to
> subpages while folio's HWPoison flag is cleared. So when trying to free
> this hugetlb page into buddy, folio_clear_hugetlb_hwpoison() is not called
> to move HWPoison flag from head page to the raw error pages even if now
> hugetlb_vmemmap_optimized is cleared. This will results in HWPoisoned page
> being used again and raw_hwp_page leak.
>
> Fixes: ac5fcde0a96a ("mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage")
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
next prev parent reply other threads:[~2023-07-10 7:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 8:57 [PATCH 0/8] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-08 8:57 ` [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage Miaohe Lin
2023-07-08 9:44 ` Markus Elfring
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-10 8:26 ` Miaohe Lin
2023-07-08 8:57 ` [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Miaohe Lin
2023-07-10 7:56 ` Naoya Horiguchi [this message]
2023-07-08 8:57 ` [PATCH 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Miaohe Lin
2023-07-08 11:02 ` Markus Elfring
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 4/8] mm: memory-failure: use local variable huge to check hugetlb page Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 5/8] mm: memory-failure: remove unneeded header files Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 6/8] mm: memory-failure: minor cleanup for comments and codestyle Miaohe Lin
2023-07-08 11:13 ` Markus Elfring
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 8/8] mm: memory-failure: fix race window when trying to get hugetlb folio Miaohe Lin
2023-07-10 7:58 ` Naoya Horiguchi
2023-07-10 8:32 ` Miaohe Lin
2023-07-10 8:39 ` Naoya Horiguchi
2023-07-10 8:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710075629.GB1686200@ik1-406-35019.vs.sakura.ne.jp \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox