From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB97DEB64D9 for ; Mon, 10 Jul 2023 07:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B9F56B0072; Mon, 10 Jul 2023 03:56:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 340AE6B0074; Mon, 10 Jul 2023 03:56:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2C46B0075; Mon, 10 Jul 2023 03:56:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F49B6B0072 for ; Mon, 10 Jul 2023 03:56:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D89FA1402AC for ; Mon, 10 Jul 2023 07:56:18 +0000 (UTC) X-FDA: 80994944436.04.DB4FF8D Received: from out-14.mta1.migadu.com (out-14.mta1.migadu.com [95.215.58.14]) by imf30.hostedemail.com (Postfix) with ESMTP id 191CB8000A for ; Mon, 10 Jul 2023 07:56:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OXMPdKFi; spf=pass (imf30.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.14 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688975777; a=rsa-sha256; cv=none; b=PTlYqdrzmMOq0L0JLCCqhVouG/z32Vkz3XJ29zk+grRAKzuFWBBN+HqEIdFuabk52gaOfR duqEWpKKQGT3aej6erY217l391z7Q27Eri2SOTvyo3C9MydOtNjj8scPFOTaxbKKNDtxGF J55U/4mWtSmuf/RShG2768CJuXh2+5Y= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OXMPdKFi; spf=pass (imf30.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.14 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688975777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxpfsWCTlFG1v+7dBNIcVRA81FfHjZwtoCj7hQ1Emik=; b=UadI0zdGMGfC5BUnJ+6y3DpAjckdtcsjcqBj0M+bPQBjbUKOHzkq1TcIeQI0r6yAuGMbk0 e7RY+X7fosw62QzWXSa7Jd+yNgBMYglDJraL43va9o2ujhkOx3p9qrxCtm25WYmn0PHsp/ 6qD+FQQ62wK5EbG51PfNEm7JgHwjyb8= Date: Mon, 10 Jul 2023 16:56:07 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688975775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxpfsWCTlFG1v+7dBNIcVRA81FfHjZwtoCj7hQ1Emik=; b=OXMPdKFiMdjZEynNo2f5M+d2MB4748ozdgc0DsnBSIbSOX8ajZlQXXrj3eWfPrwmQvj81m +nLfMuKBEB1ReuphfOM7mMAKJl/HZBa502dIbIkwG4pf95lpowjqhhiHJAOldyUKWW1qQy dddbMwtfy0YLqcb99Oh3yoT6L8lAoiY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage Message-ID: <20230710075607.GA1686200@ik1-406-35019.vs.sakura.ne.jp> References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230708085744.3599311-2-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 191CB8000A X-Stat-Signature: k4a3r5ppxruimd5z69a4igbt9ur8fjae X-Rspam-User: X-HE-Tag: 1688975776-754256 X-HE-Meta: U2FsdGVkX1867GjlsJc17ofAgapkWQ1wav+vYClWEDgMn/ngxytsjPUejzj8Sf4ZDRApjRmmu0eNsboAg0S4dGUC5O19wBaNJ9L9aDSrb2OOODTOUkWJCNU/0AQsXxYm+qcm94DCY1AL2Hu1yhb+kQqWjysHhkf9gHFGYehN+P8AlSxcMmRMEKs4nTF2ohl1tJsd/p9TY4iSI9c6//aZa/7K0+fkHaoFynx3jKlNFcNMVleSN1+88tim/He71CW+REUwdAvBXMcTOpvN3+qX6ViL0Ml1oflXwr+aSEFlECor+XO4RbforU3of2E56WgMG651PEA0JM12e/TLg0hdTpcpGj5/l9BT+rX+FYdB4i0d3bWH7BxacyiwGaEjiH0mrbTqumG2nrHnpTB9k8woBMcpsRQzir9np94unZq0qqsHkm0Nzv2TE8uymH1xV04mVgyrWGgAFfXQ4DtvgSSJ1R1/ItkPowxW6kelA9SbDEJOw7PycwwR4vb8QQkRDu2ydvS4zYe2bPG0LtTW+8tR1hdzasTU6jn/twNuRZQ8qaTaOP8B3ZCNr02ckH5Fnmq5+eiZRKXrU+VEwzUW4c7jbwrlv+w7qPBJbTGW3qFuNIQ52UzbjEabtJ5i5dMf858PIfYj0E/F3ZZGbA7mEGoIoKUNPKKNcJoGLi3o8KSxl6D841ESZw0lUcy53gYfuDUG6G91dWinAgiCaFK5lnHsRQmDe+XOhEI79K7vAdfPg0xVdNEbqJQsEPAbMeiw7Df76zx+0MqSlyRjX+9XzeOiAosJxtxS2mNTmxurXXFjKuXETH9CWZZrkt4OkyvW+qonYPTgwB2XTl24IJa5FZmsXFiQfo7Q0/2HWZsNTXKpBmhw/lhU8TaNcqm1nie0r4CF0t7q9MD3wzti4z4DNifNG329U5XhtNNxvx5srVW/vSCsBRrE6y5KigwhZIrqOT1mK4/gzqDd+afnxaYWTJR aDQ1OYMk uG/JzI3B6w4+j7PDnXfRg+yKT59QTSyMFL6UhLSYp1WefhenquRW6c/q+C0WaS7IzBLtc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 08, 2023 at 04:57:37PM +0800, Miaohe Lin wrote: > If hpage isn't Hugetlb page, MF_DELAYED is returned without unlock hpage > leading to hpage permanently locked. But this shouldn't trigger in the > real world because this PageHuge() check is just for potential problems. Right, so this if-block is dead code, how about simply removing it? Thanks, Naoya Horiguchi > > Signed-off-by: Miaohe Lin > --- > mm/memory-failure.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a6221a4bc5ea..d21ee27ad412 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1187,8 +1187,10 @@ static int me_huge_page(struct page_state *ps, struct page *p) > struct address_space *mapping; > bool extra_pins = false; > > - if (!PageHuge(hpage)) > + if (!PageHuge(hpage)) { > + unlock_page(hpage); > return MF_DELAYED; > + } > > mapping = page_mapping(hpage); > if (mapping) { > -- > 2.33.0 > > >