From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049ADEB64DC for ; Mon, 10 Jul 2023 00:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17F686B0072; Sun, 9 Jul 2023 20:21:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12FEE6B0074; Sun, 9 Jul 2023 20:21:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3A076B0075; Sun, 9 Jul 2023 20:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E26DB6B0072 for ; Sun, 9 Jul 2023 20:21:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5FFA1C7D66 for ; Mon, 10 Jul 2023 00:21:30 +0000 (UTC) X-FDA: 80993798340.05.C45C9B8 Received: from out-59.mta0.migadu.com (out-59.mta0.migadu.com [91.218.175.59]) by imf27.hostedemail.com (Postfix) with ESMTP id 8ADD64000B for ; Mon, 10 Jul 2023 00:21:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NF4a43yR; spf=pass (imf27.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.59 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688948488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j9Mc26a/DPJrsB3Au4Lg7Qs2eiX+PC7/Wg8QJdNNfb4=; b=p1LGwZts2v59cshZ52uYX9vtKeliZWLsgaX2sW+o5nQYQx9yGSIgB48t5IhKoISq2+qoEZ fmookFyhuT2OnZiQJkoTsnp8sSieEO5CvZS5kOKLBGBLcQDcR1uNeF9GsD9JI+38sqtrs6 9BqinrvqzmWKFsNPK1unATzQ08ThpHg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688948488; a=rsa-sha256; cv=none; b=BO5FAWR6Abhzjd6a4Ta2IVVLYR+UXttZQaFbDp1crFtpfh54ns7G5pewDAYOyS4wGsMmb9 2CaZsWDvsBjMZL/3h3dSoHdzSXuuThjW/nXOIZtmXjWzfVQhGBMMrXcKGo5gfyHZsMiD8d 23llAvkPDYRERzq5gWTWP8rVIQk8tWs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NF4a43yR; spf=pass (imf27.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.59 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 10 Jul 2023 09:21:16 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688948486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j9Mc26a/DPJrsB3Au4Lg7Qs2eiX+PC7/Wg8QJdNNfb4=; b=NF4a43yR/DlMAmwvsD4TF9y3fLigDbBFsIHMyLJrLsldW94ar6HI8OfvE/2uvwGh/f7bwO 1zbW46g64E2YDSpD1WodpLImFRkyWmv0UrALaLW//AsKwmn4M2VKFlCn5xmSXkQFDf/yqk DKPX7V5FYpyJxsUBcUjYpV0DijSKl+Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Matthew Wilcox Cc: Jiaqi Yan , akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Message-ID: <20230710002116.GA1578139@ik1-406-35019.vs.sakura.ne.jp> References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8ADD64000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gq8jp71rfez79q1krqne3yrn6woeogkg X-HE-Tag: 1688948488-87157 X-HE-Meta: U2FsdGVkX184yQfrMj/sZ0wgBst6Bc3VjB6UttPe7MXu0k8K7pueKj4C9DErXdjium/Rapj26/y4Ia0rWnaussa/CMDDUo8YgenE11ZjzTe+O062ZH9RwqV/DIggLUUMkMNUYv5Rs352+kDEBodbG30zbauLJCeXLmh8YnZqfLtZxFyesQE52rHjm/x4g0JiQUaWUidfC0aRflRuDXopGM1JB/RGzD6AO3pT195j/9JGLZu3l9zjVMLIs8EAeNz4JZEmsyHoR7sEyWWSXZptxvb+lL4Gb+cQPb3M3kj8ztIAEBgey/LwZJNL3S9sMUQo0AkwehmobRlVx+OJq88HfM3LkiVP05BY0mdXZvzqsFg3EFT/hHrZlTqH8tP7fMb7GH0QPV5gxubywERfjxqpvIKqj7JEwEAB4u8od8USajehOOVQEJKjJ5ra3xVTg0R1k/ZIhZ1krfvKQtLdB9XbMD71sPC+nAn8rhbAGJfYLmszgNbdwoPRi+FuwaPHj/u4gWxAx1x2h3la3Y2niIPXRDXf8YVnDr2jp0eXgow5WnzytNBxBna34W24FH7xy2seniy+8dmn7A6VZEtCukTz8/SEXJIEH8bbEaguv6PeerVatizMQmAh0BnvJZctws/0/r7iwFZo3PvxSQFv/+n4kihMWYF5v8jBKZ81uEsHqISyUQgRY8dmJUV4gxxQ0iJ1xIvC7MFIIpH4tF6/heTvq+OGdDw8cSilDdi+/OfB5H4znk4NUO/Mh1QXWUOUhJDHfSZ08VsCZ5T/lAFlyrykkL5c66E1ogZB2KOBVQeqikZi/DV+NQrdkp4pe+uXFMx10ZM404Ha0MqWyydX9EAPqRvacp3jdJCP6Ns8pBMJQPnpV6krYZ9pN3+pNloTUL9oc5G8SH4UdkgYAIUGjg6vdROSEldlMg+FzGlv+miUtoXIM1DTf7rdmukp/F5DY5VjZ6JTkXlXJE1vmqYimVy KIDFMKbH 63XR8kI1SFlfk5bTeZktjC4Ahq3SaLVUd3I0PDIMqwS1TcCE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 09:31:39PM +0100, Matthew Wilcox wrote: > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a > > This is incorrect naming. "subpage" was needed before we had the > folio concept, but it should not be used any more. We have folios > and pages now. I think we can address the raw hwpoison page by the offset in folio/hugepage to eliminate the concept of "subpage". > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. > hwp is already used as an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver. I originally introduced the abbreviation "hwp" to avoid using a lengthy function name such as "folio_test_hugetlb_raw_hwpoison_unreliable()." Therefore, I prefer using "rawhwp" instead of a longer form like "raw_hwpoison," although I don't expect any confusion between "hwp" and "rawhwp." As for "hwp_walk", another user of "hwp" in in mm/memory-failure.c, we can easily substitute it with "hwpoison_walk." Thanks, Naoya Horiguchi