From: Suren Baghdasaryan <surenb@google.com>
To: torvalds@linux-foundation.org
Cc: akpm@linux-foundation.org, regressions@leemhuis.info,
bagasdotme@gmail.com, jacobly.alt@gmail.com,
willy@infradead.org, liam.howlett@oracle.com, david@redhat.com,
peterx@redhat.com, ldufour@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
gregkh@linuxfoundation.org, regressions@lists.linux.dev,
Suren Baghdasaryan <surenb@google.com>,
stable@vger.kernel.org
Subject: [PATCH v2 1/3] mm: lock a vma before stack expansion
Date: Sat, 8 Jul 2023 12:12:10 -0700 [thread overview]
Message-ID: <20230708191212.4147700-1-surenb@google.com> (raw)
With recent changes necessitating mmap_lock to be held for write while
expanding a stack, per-VMA locks should follow the same rules and be
write-locked to prevent page faults into the VMA being expanded. Add
the necessary locking.
Cc: stable@vger.kernel.org
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
mm/mmap.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mm/mmap.c b/mm/mmap.c
index 204ddcd52625..c66e4622a557 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1977,6 +1977,8 @@ static int expand_upwards(struct vm_area_struct *vma, unsigned long address)
return -ENOMEM;
}
+ /* Lock the VMA before expanding to prevent concurrent page faults */
+ vma_start_write(vma);
/*
* vma->vm_start/vm_end cannot change under us because the caller
* is required to hold the mmap_lock in read mode. We need the
@@ -2064,6 +2066,8 @@ int expand_downwards(struct vm_area_struct *vma, unsigned long address)
return -ENOMEM;
}
+ /* Lock the VMA before expanding to prevent concurrent page faults */
+ vma_start_write(vma);
/*
* vma->vm_start/vm_end cannot change under us because the caller
* is required to hold the mmap_lock in read mode. We need the
--
2.41.0.390.g38632f3daf-goog
next reply other threads:[~2023-07-08 19:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 19:12 Suren Baghdasaryan [this message]
2023-07-08 19:12 ` [PATCH v2 2/3] mm: lock newly mapped VMA which can be modified after it becomes visible Suren Baghdasaryan
2023-07-08 19:12 ` [PATCH v2 3/3] fork: lock VMAs of the parent process when forking Suren Baghdasaryan
2023-07-08 19:22 ` Suren Baghdasaryan
2023-07-08 21:18 ` Linus Torvalds
2023-07-08 22:36 ` Suren Baghdasaryan
2023-07-08 22:53 ` Linus Torvalds
2023-07-08 23:03 ` Suren Baghdasaryan
2023-08-04 21:46 ` Mateusz Guzik
2023-08-04 22:49 ` Linus Torvalds
2023-08-04 23:25 ` Mateusz Guzik
2023-08-05 0:14 ` Linus Torvalds
2023-08-05 0:26 ` Suren Baghdasaryan
2023-08-05 0:34 ` Suren Baghdasaryan
2023-08-05 0:49 ` Mateusz Guzik
2023-08-05 1:06 ` Suren Baghdasaryan
2023-08-05 1:16 ` Mateusz Guzik
2023-08-05 1:36 ` Suren Baghdasaryan
2023-08-05 1:06 ` Mateusz Guzik
2023-08-05 1:42 ` Suren Baghdasaryan
2023-08-09 21:07 ` Mateusz Guzik
2023-08-10 20:31 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708191212.4147700-1-surenb@google.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacobly.alt@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=liam.howlett@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterx@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox