From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 4/8] mm: memory-failure: use local variable huge to check hugetlb page
Date: Sat, 8 Jul 2023 16:57:40 +0800 [thread overview]
Message-ID: <20230708085744.3599311-5-linmiaohe@huawei.com> (raw)
In-Reply-To: <20230708085744.3599311-1-linmiaohe@huawei.com>
Use local variable huge to check whether page is hugetlb page to avoid
calling PageHuge() multiple times to save cpu cycles. PageHuge() will
be stable while extra page refcnt is held.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory-failure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 905758af70f3..88e48a4801ee 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2621,7 +2621,7 @@ static int soft_offline_in_use_page(struct page *page)
}
lock_page(page);
- if (!PageHuge(page))
+ if (!huge)
wait_on_page_writeback(page);
if (PageHWPoison(page)) {
unlock_page(page);
@@ -2630,7 +2630,7 @@ static int soft_offline_in_use_page(struct page *page)
return 0;
}
- if (!PageHuge(page) && PageLRU(page) && !PageSwapCache(page))
+ if (!huge && PageLRU(page) && !PageSwapCache(page))
/*
* Try to invalidate first. This should work for
* non dirty unmapped page cache pages.
--
2.33.0
next prev parent reply other threads:[~2023-07-08 8:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 8:57 [PATCH 0/8] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-08 8:57 ` [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage Miaohe Lin
2023-07-08 9:44 ` Markus Elfring
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-10 8:26 ` Miaohe Lin
2023-07-08 8:57 ` [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Miaohe Lin
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Miaohe Lin
2023-07-08 11:02 ` Markus Elfring
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-08 8:57 ` Miaohe Lin [this message]
2023-07-10 7:57 ` [PATCH 4/8] mm: memory-failure: use local variable huge to check hugetlb page Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 5/8] mm: memory-failure: remove unneeded header files Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 6/8] mm: memory-failure: minor cleanup for comments and codestyle Miaohe Lin
2023-07-08 11:13 ` Markus Elfring
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 8/8] mm: memory-failure: fix race window when trying to get hugetlb folio Miaohe Lin
2023-07-10 7:58 ` Naoya Horiguchi
2023-07-10 8:32 ` Miaohe Lin
2023-07-10 8:39 ` Naoya Horiguchi
2023-07-10 8:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708085744.3599311-5-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox