From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F52EC0015E for ; Fri, 7 Jul 2023 15:55:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E4E28D0001; Fri, 7 Jul 2023 11:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 894796B0074; Fri, 7 Jul 2023 11:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AA168D0001; Fri, 7 Jul 2023 11:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C2F36B0072 for ; Fri, 7 Jul 2023 11:55:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 22641160853 for ; Fri, 7 Jul 2023 15:55:33 +0000 (UTC) X-FDA: 80985265746.22.D193CCE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 55C6318001A for ; Fri, 7 Jul 2023 15:55:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=sUQTi0bt; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688745331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nu+pM9A7Tn0mPaaMwZcDkRe9m8dmL4O6ss3hpCnkgqE=; b=0rJ8QTZAyAwU6UH9pk+DNgX6tfiqZzYDjfWJ4ysG4ySpUdcYsM2TUtHR3ASZh/gH/4pTwb zgPyjo2nUCNSMMj44CVWkLvnixWVxovr0CljztRZZVAr0oVvrmUsY3r8SXIMsUxWCiFbyK p1qWQDzoYFUKqr9dF0NM1p3DTULe0RQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=sUQTi0bt; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688745331; a=rsa-sha256; cv=none; b=Dph3tw5iquSEKar/BWD5nckMyhpo7Z3r73zcHoL/QeBu/ZYPWGP0QxeuxNrMpa5yh0D7Um UaGF0ipZfoPofXiLvB4h6OZFnSwFdtU/dGFrGTPCFJiHLw+GlaORMMZLqjONZSfpZxp7jf hNT0EPC4ijk0Ocbm6Zem/NivgoFKBuU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F8E5619F9; Fri, 7 Jul 2023 15:55:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A3BFC433C7; Fri, 7 Jul 2023 15:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688745329; bh=w8KYR6gzrUNFbtKM/p+G+JdWO4JfsO1K+O7KqoUEqtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sUQTi0btfsvZqBKWmLBywAmzE41jyD42XPM9Zc0dUv/PHx768itGsSGmaM9v1lkM8 P6YWSL0IecjEdMvfbaCTPnDN8ogTsxy9nwnArRewdXEzITBuVKLtDESLlAVpZZSAnF Zp7UcmmV1sQecT3Qc+DiOgs8JpBP9b5SrEtQtmn0= Date: Fri, 7 Jul 2023 17:55:26 +0200 From: Greg KH To: "Liam R. Howlett" Cc: linux-kernel@vger.kernel.org, Andrew Morton , John Hsu , stable@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH stable v6.1] mm/mmap: Fix extra maple tree write Message-ID: <2023070748-confiding-abnormal-b7e3@gregkh> References: <20230706185135.2235532-1-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706185135.2235532-1-Liam.Howlett@oracle.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 55C6318001A X-Stat-Signature: n4d7f3k9f3n7udsio1nrrcuesx4sskka X-Rspam-User: X-HE-Tag: 1688745330-6610 X-HE-Meta: U2FsdGVkX1+MM7afP/uWDVTlHB/PQaNZ3wSBQIvMu9aganoAMZMfa2t0BsGBh9xgA5oDXB4VOwCSAAAqEsvXDXQzDStktHdOe7o53MF4fvtxQTAvUdtD42cIHtYspso5Pv0sIvXoXz0p4jPzFNN7fQ333PHzSHPSEnKYaH+Wp4PXMenMWnj5eOs4kPSic8k1I7BZPtc/1+3pxjx+IQd/vQj1D01EFy8UmaPhpz06e3a0XesDo8CRBeptPCXinDXdEOSrXDxCl82mquLlnb+hfNLXodCh+k1GzVVtS8L55RVbdkh8xykpGYzH8OfK9mtu3vqvWxsYwvT2xn3v3ApIERWQg+GcI4amPW48mucIRRLndS/cZy5ajL8s1rvgFmZh4etjKoMfJLvvy9y8NbQF2Y1aXBMhy/1bHJI8VZaZIMoZCsuLUqw6Nt/rV6AEQGTQY+DDMICvDHOO+sesJpGuIOaszfGB5M52t8Wno3yw9XeJzGtNM+WEp1IDh0po/kj0biZ0yD5uizDkt6o6Oeeq0Ga2jjSHXFZJA0jgeQaTSa42VaQow4MXvvo3l51H6py2+xbSMPPdG4GMNNdyLhdSQ7GaM9xHFO6Xx7Af9YYj301lGRyQBTZWizhQEAENuVKY175bgC/PqHS4F1u144dQZtsEVw7L7pqWL6Lbz0Zj7cL6q+BW18F8ayziBcyl2AmnrbUD7ii4oq/YfzqRhtFFALb1673opdRuYpn1N0KEopvRRVbToDIY5Tz//V8piL7Bt1tXwvYEolzt/OQGqfBkrxUvXQQD2YZym6uGGRJJxCl4aSsvFAfFO64lm9ByGxvnRq1/QZMtynpw8GGJuqxWiW5zpy8az7R8lEr9rD6zcN0M9aScqJteb2hIIvj5IN+aAY9KWxTPNqiNAlU+7p3b5P03g2d8WRiAYlK1F7RTTftltTZ6c1NNXzQ/lj7QJox8tieZrO5aeonFp1zF7mz 1/AeGS+6 MCbDbhZaT//JihEn06CZaOuyEEPEmI18Rp+6UFqd9oFXQ2jB6veyw7kOFU2dVilib6D52eGPmjzEy5+AiuNkH6CCTp+e9NhkYoHlGvV21jPIib5c0aXbJDomEZ3d5QtSEs98BnJL+B/S0O9gzeU7qDMn6vNQacPV4tD7DPdURH7ax+hEffYUfdncMtzbbxdCp5o66ZZS1IBHapZIqBJYXibNLAlFtAOOIiY0JffqiydgtVu9SEWmh6wNZImRiSbMPV+6cPipkBUT1FzvogM61CQWm6jqmMG2LdHu7O85/zbRwAboO5Pm92vutMXfY8pfwraFP/HIUmNaN0OY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 02:51:35PM -0400, Liam R. Howlett wrote: > commit 0503ea8f5ba73eb3ab13a81c1eefbaf51405385a upstream. > > This was inadvertently fixed during the removal of __vma_adjust(). > > When __vma_adjust() is adjusting next with a negative value (pushing > vma->vm_end lower), there would be two writes to the maple tree. The > first write is unnecessary and uses all allocated nodes in the maple > state. The second write is necessary but will need to allocate nodes > since the first write has used the allocated nodes. This may be a > problem as it may not be safe to allocate at this time, such as a low > memory situation. Fix the issue by avoiding the first write and only > write the adjusted "next" VMA. Are you sure this is the same git id? The one you reference above is _VERY_ different from your 2 line change below. And the changelog text is not the same. confused, greg k-h