From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC87EB64DA for ; Fri, 7 Jul 2023 21:05:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A47C48D0002; Fri, 7 Jul 2023 17:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F7D98D0001; Fri, 7 Jul 2023 17:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0A78D0002; Fri, 7 Jul 2023 17:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7989E8D0001 for ; Fri, 7 Jul 2023 17:05:57 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4A48B16012E for ; Fri, 7 Jul 2023 21:05:57 +0000 (UTC) X-FDA: 80986047954.29.8EEAFC3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 6395D40012 for ; Fri, 7 Jul 2023 21:05:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="z/5k/i7f"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688763955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2z2OaMUgrFB9JYfeEsfqzMKC4srN3j687jYfrQhlCIM=; b=VLKC27Z7LYlPgMzuzBVXfkiscMfimwKu92wNtNpQs+rihzO3cRBfSvsn1W6QLSoAeEopXI 22nDTaSyxwItlL1skDphFh4GVe/6cpY/oEWeJJ1NNFZcEb8tCA3HOgdAm/38DHAab1X8ik kXCIsQFiqYNbQ3shlNA9qcumh6+PST0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="z/5k/i7f"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688763955; a=rsa-sha256; cv=none; b=dNZmAWLAHZOp4Yrw6PvJ2hbQL7UABHuGN6lh7HUxKc+o3t0fpL1dB7fK1zNpYiDFCGJuyR mhyRkESN79b9ok+vgl0W65Wprre/A0jfvwKyv8615XlwrOWWifYAtQPqPQ/r4p6QQIJJkj syrpHjsgExF3qEnuAJxm+zKKTG/QwpA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31AED61A51; Fri, 7 Jul 2023 21:05:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BC7FC433C9; Fri, 7 Jul 2023 21:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688763953; bh=wIbc8HTUUZfRvfDpoEteNIK4JDXCZ1at/pNiozS117k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z/5k/i7fxqVHgVojMa++l/xaXfNe7dqYCBfHSWAwn5Vvom1hVKoyeOGgvh6Fcejjn fjbvugBxpSZwlu5VfZvPb6BcOFzrkKMjmwC/vcygGF2P4J3nC1wdSDfoGf3u2M/Vga BNyvpHeP6+4+y2oNjNGrC40yJNDGdMgQ+0UZFSMM= Date: Fri, 7 Jul 2023 14:05:51 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Jiaqi Yan , mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Message-Id: <20230707140551.07e06293e4943be0c6c557fe@linux-foundation.org> In-Reply-To: References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6395D40012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: kz16o1djfcmfy8qojixhj7z7ahgpufci X-HE-Tag: 1688763955-285822 X-HE-Meta: U2FsdGVkX1/tc8R5In+SLiIxjw6OVkNHI14CHXWmNMC1t9MyOckpJo21B/cxJSGNIPKcJHpfqeP+bC+XDV324l0i05uIS7+fKti0a1tWQDla7vB+/yqVWC3KWjCRuMEUfGNggKApLs/VfSOwfrAyP+iE2xFX3VMVw05u0zuwP6JUhoKFEAFOr3MA+pM/76IsNqc8I+ItjosItI0jTrn2K0rZG2rx9LHe4v1CVdjopG0IJUlXctvQ/3kSVpWywm6r7XLUg1PMxYFZzxNNw8FlsY5K/ewpbrGl/W2UW7T7Lelmb5CE2BvXMzmtIOLjhc2MjtR7KyHLFJ3WH8c9PQqzEGHOVr5/93rQF/EzRxegwkmA4998dZ0B+E+kfPk3YWpRrFuv4e8Yz0A6rM6rhrNmUB22t1seRhDEiRi+6AgDuP60fDRDPZNKfA7FCipUDTRu4uwBgisze5yEkT+HTVGvQyXlsxkiEnBN5ViAcA8+PDowxzaikAngf3BHQ5MeHikhAE/5C2GhTkG3qvVfBrvq67XbIwQ5AqN/zWevjR1H1WG9SOYZwhbxkNrZva00Q+5flPGrZPzBpTtf9lk2wwbs1IpWTI9+Xnng3ORwxEz64ORcanujFsaB2j15MINPm0E6+oGS5qgQsJQlsaElDaWo5WXgs404BeR2/H7Pk1FDoqEqrAaP88HZs0qrMaF+N8kRP7c6KM8FqgelsDdQcn5SjTZAnMitTwQA43uMnUBSqj42S5TRPMlURWLwmyDCVri7ou4sPN6tEyCXODfMP6d6Ph8jxgjqqXZB8+gtqKNuo70qw8D9Bz7EVv6AiWuHth9Q9AnengznDr2gUlgpYN3K6jdau/SxWoxhY0KfkN0LlYBXN5t52F7UtgoD3g9Be/2/rycRIwMELhRdTERYtaJ3vAMctBs4Cb6xHYRxdTPUqZXU6WU4ixZ+3W9JUqNpSzquCtl5KO16qdyXz9030hU LRBpAT99 XEIvkxiZ/uvbJlD9ljP463OOsrfMlHLpKIeXsZwZ7JSiYxSbx7xA7K94OUGTrq5WQb2yZKkYb5nnJaU9nAb3+reJUNrqlVz8YvE4baIi2rIfYBit6KqwfBd6Bi+kyypXv3NUwjVI2dymw4DWUdCa6i61QCsaVDTaQLHvvzcXWT6j56uzG+XFI6LNv2ZHw/lajDGB3IoG/8NN3pKQkYBiCgYgnAeZTjDqdswf2nncvdkIRo6RrUkDXy3htxQgWMpTvwW7nrpWe4BA4HixgwjFD8pv0ZWFtsRALKK5t5Vz3QSRP7LEA3yT92ZF9bfsd3S+NgpFmerouMxLt9GWA1vHlSBRxazAFUNN6N0UgpN7773QTN4USGst/TLvq+Pzfw+leg/Tk3xxCocSjOvc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Jul 2023 21:31:39 +0100 Matthew Wilcox wrote: > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a > > This is incorrect naming. "subpage" was needed before we had the > folio concept, but it should not be used any more. We have folios > and pages now. > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. > hwp is already used as an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver. Thanks, Matthew. I'll merge v3 so we hit next -next (which actually won't be until Monday), and add a note that v4 is expected.