From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096F8EB64DA for ; Fri, 7 Jul 2023 13:50:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 912BA8D0007; Fri, 7 Jul 2023 09:50:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C3038D0002; Fri, 7 Jul 2023 09:50:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AA68D0007; Fri, 7 Jul 2023 09:50:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 688CF8D0002 for ; Fri, 7 Jul 2023 09:50:53 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 053491A04EF for ; Fri, 7 Jul 2023 13:50:52 +0000 (UTC) X-FDA: 80984951586.25.40BE7E1 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf26.hostedemail.com (Postfix) with ESMTP id C8586140021 for ; Fri, 7 Jul 2023 13:50:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=cuGvqIHk; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688737851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u1DUJ0Z1myy/8WXZxpVo4Ndbmll4LToyEcu13r4HL0s=; b=571t9LwZY1f/QzPh4VWsFBtGBisBgRTyI3cu/FKBNmocjUiUMiYMR4EGWeCqhCxSnmqd9n p5C3rorbdkpp7WI/fKXlmJ7LSmOp5LUlGUKwBIfGJz5Ld4h1rP8qRCJ5BOFRXKDeDm0sLr O1ZHSok/3zqXMmAPHmfKG6f0wJ8L198= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=cuGvqIHk; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688737851; a=rsa-sha256; cv=none; b=Op8Fx58F0P9JIDbMnmSkNSxJLlcTniE7m84AFLjHuPHykiWx1CyoN0kH34nzDbijTYnEEn AE+0aqfobyJdkZ3pycpFSZlZT9TSRpsQ4rLNEf6JybTPokEZeewjxeul2FSQvMYptqLm+R uYr10tByTa52hCoKj710C/PFw6XcKjQ= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-767582c6c72so176559885a.2 for ; Fri, 07 Jul 2023 06:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1688737849; x=1691329849; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u1DUJ0Z1myy/8WXZxpVo4Ndbmll4LToyEcu13r4HL0s=; b=cuGvqIHkXGqmGowaPkIu5OulgLDF+iBIB2QBuOW1Q5d5vzw3aJFdSYerGWSHdoiGIz xE+wtsN7H5un+Wb9kt1QnDezsgZURbxIr2chMcKsHdNwqLiji1ElwSl5hbvsim25WlZN 4ymA2ROknspUqW26e6EGA2Eh7RAVTs/H+DSVoaOIJVyi/DdJFC8cT3G/hNgCP651Bcjj gYsX9jjim44U3X7V/obLjLYI3zBWYPOYx0U8usLdditE5bWt9cImPYQSt/vtXALbEO45 wImJbW4yzIDZJIfTSPccFdcLepG2kIERKzn7S5widOao0PFYr4OyV0nRkpSEicD0TptK 4EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688737849; x=1691329849; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u1DUJ0Z1myy/8WXZxpVo4Ndbmll4LToyEcu13r4HL0s=; b=djhD8661S3x0JN6zC5gP2+BgW+YcB42XAzMbuEy4f49kG1+kw24kozOuhnGjZ6hZYS MKlwRGZyes9UyCLSylk5MEadhAxYdILDSfYH0nqffgRQhfQ8aAVaSZXZGRREP5ESzzAu rnatxo/gloPbCMaa5yKKNzD/GhsJTf2SdVwGTpEugltdniQNS3KbFfKpKllA8WQNMuIF zBFX6J+Wr3F/CwbJm+CEHC7JGLIMpHRBfUjjtt5e55H3DV+FOayzc48V0f8nHzrhittj KtnLNjWK8RYMDoi7RSnZOET18k/TGNy6960eus9IQlzOuIrzrZIZxO3n6B7cWSfizCyB sglA== X-Gm-Message-State: ABy/qLYBMe9Ni9YYCSgDR+PWfamO7xASyD5jGqlPsoSqzIUlaNYL3FVd 0Qygwfm1JPkbe8xxiPrVDlTu6w== X-Google-Smtp-Source: APBJJlHK2pg51q9ucOIC96xV9D5o9O8IsqXh7gIL6kpw0u78RarRKJUifVJ5+w2adh/5e6MzdaXSKA== X-Received: by 2002:a05:620a:4504:b0:765:aaa8:67ab with SMTP id t4-20020a05620a450400b00765aaa867abmr7105309qkp.26.1688737849516; Fri, 07 Jul 2023 06:50:49 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:15ac]) by smtp.gmail.com with ESMTPSA id o6-20020ae9f506000000b00767b7375eadsm344918qkg.39.2023.07.07.06.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:50:49 -0700 (PDT) Date: Fri, 7 Jul 2023 09:50:48 -0400 From: Johannes Weiner To: Michal Hocko Cc: Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , linux-mm@kvack.org Subject: Re: [PATCH] memcg: drop kmem.limit_in_bytes Message-ID: <20230707135048.GA214771@cmpxchg.org> References: <20230704115240.14672-1-mhocko@kernel.org> <20230705134434.GA156754@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C8586140021 X-Stat-Signature: fmb7wxzsxp1xrbnxxf96osxyho9iha1o X-Rspam-User: X-HE-Tag: 1688737850-948197 X-HE-Meta: U2FsdGVkX18uuykdybUh7mTKUivUriT9gbNkKqwl8wOOS8EVw0MhotgJcmgbhs6gUEjgo3a6BzfaS6DW0QVJDlhVZB8jIL3x7eCJqekeZwC97koPxM8RCf7VCxw39v3lh6IC7+9PvLt+eYefCohAdbb+Qf4kFWvZW7h0PT65YYQyuCK2lIBKwV6nBFsSMWJrfRAFGqIIVmsmjcobMB6Mf5sVRMTK4FaeUTczH52rUYueQB9mn88WNDYdHMgXg0RD8lIyaX1ut+C9m3EOgnZ2LXvzITBqKwGtd0NjhRFphUAuFlhd5SYIaR9dx/CbJfHCE6XlWyhrbpXLAnZSAqOMnkIVTPVKnG8yyYVMfZoNkQIavXX0f/I1wMcZq1aS32fssLO6FY02hxQQym3WKVRpWoiA7ZYdG6HbjpSjIRRTiDXOs5ft31ATpHFle3bQmOWdxHMLtoPaTFE5CMF4mHLocLZTReGOOjTG1DJqqGd5hP54Po1ywf/pCJyeztg5hmaru2nqkol2UHJ2ApaTX9xUFgWYHNgxhhK7d/SAfR1PAwyabtcJu3Yt0/uD7zf4JpUu+PcWk1KwXtmuLQR+r7AGUaShlk5ds8jqbyRR1UpzbizJdqe8hFy/NAlmDOPHiuFWpkYdA2c1O9Gktut8VvNekRJPmALqsZQE9OiuOCVP+J60GxksnrqrHVSKOhHX126qncauKQsYFpPQ2lWDbXSmsD/c4AySVCFt1Rrehxi+8T7415tS5l+Qh4sC30e4LrLCQkiLzKQJQ4SlrMIKCCCoblYOiP3ImaMUGagJ9zS3H1AwPVD/tmFDLSWiVZgKQ1P8zfxy9bIFbBWK3fs6DBgQuza3LIoZE+agz05sCB4zhcaChXYu8fzpvtZnDnp6KqZrwVpzhKkMefm/aobfV5JV0AY15JORzSWUgVN24LDcS3ePKZFVEwj32AqclLmQs1OlDDm13sLdoYcPTLmmr8t clVQ3uTb DIcgfYTlk66T+iWQZxbfaBlNsrptgqkfutb9BQETJZscDzjrSBP4xdx943B7CnfXEW/JS2lR55oAgjlFJEJHjOpNkjSUZYAQGZJmXP2JyBJ9BJFWq8kkjTmTme2QqnUfJQeZU1odrKgktIcYCMDDvzF5Y7p2LJ2xv5nxcqnxxd8DmDrvUdLMgN/vBTw5JjNob/LW+mbSb0r9LT8mPjxPpMhi77yg13TqE9vq1EvXHxEIhLPy7G3FBk/d5gfPtc7M0EW8mrVYkydFhVzNRP0AGCCoiPfEyd9N3sA0SiFiy0wmUfnTL/B040Y5S/NkCflWEUBRig3+FAsrk3RFmQULZvYBOCU9cXA9vButK/hIWafnIGufo2nhlBfcUUPzJiVdz48ovQo4Cmc1BEJ9P3iVPlHzR+sg3aCiCegalRdcGEmcFkMso/Hixed6oJBTjJgMPGGXjQIJKEG9yIFBwhAY7CL5M4BBOxIDDeyECH/1PjIn1HNFj8e/HjHGqNxQHeek6ZPaCADpL+9qNeXCkU1FTFYeLKeaAlxOnpw+01Gmvll8UIhB0wnCiUP5xVywsygkAvphKrgUuuDeC74WrYrfsNXhMxdb+6trOtxhu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 09:07:47AM +0200, Michal Hocko wrote: > From b1bbc63b6baff9c5aaf30393cec29112b3abca25 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Tue, 4 Jul 2023 13:38:11 +0200 > Subject: [PATCH] memcg: drop kmem.limit_in_bytes > > kmem.limit_in_bytes (v1 way to limit kernel memory usage) has been > deprecated since 58056f77502f ("memcg, kmem: further deprecate > kmem.limit_in_bytes") merged in 5.16. We haven't heard about any > serious users since then but it seems that the mere presence of the file > is causing more harm thatn good. We (SUSE) have had several bug reports > from customers where Docker based containers started to fail because a > write to kmem.limit_in_bytes has failed. > > This was unexpected because runc code only expects ENOENT (kmem > disabled) or EBUSY (tasks already running within cgroup). So a new error > code was unexpected and the whole container startup failed. This has > been later addressed by > https://github.com/opencontainers/runc/commit/52390d68040637dfc77f9fda6bbe70952423d380 > so current Docker runtimes do not suffer from the problem anymore. There > are still older version of Docker in use and likely hard to get rid of > completely. > > Address this by wiping out the file completely and effectively get back > to pre 4.5 era and CONFIG_MEMCG_KMEM=n configuration. > > I would recommend backporting to stable trees which have picked up > 58056f77502f ("memcg, kmem: further deprecate kmem.limit_in_bytes"). > > Cc: stable > Signed-off-by: Michal Hocko Acked-by: Johannes Weiner