From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C63EB64D9 for ; Fri, 7 Jul 2023 19:41:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B78608D0001; Fri, 7 Jul 2023 15:41:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B28A76B0078; Fri, 7 Jul 2023 15:41:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F01B8D0001; Fri, 7 Jul 2023 15:41:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8BAE06B0075 for ; Fri, 7 Jul 2023 15:41:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 40E7D1A0173 for ; Fri, 7 Jul 2023 19:41:20 +0000 (UTC) X-FDA: 80985834720.10.6C5E746 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 859764001B for ; Fri, 7 Jul 2023 19:41:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gsvPIT99; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688758878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4j/y0gv2OPm2qzE0lc3c76Dbw0fRiSEwa/Mkt12m7dc=; b=JVIEhaK9muegz/XDWxBKtjxc4sNOMkPjuEjjJbgnqbHQVnSTEWS9BW0YdIIcrBZ7mVQHtB 0iYj3OgiHCA9ZwFWzFVH4YGI2oh7THek57xa1g08hBTDGrvDoMk79H6t9l3qig5rarF7RQ UvjqVJp2iyWcR9cvcFYTXxmgF6KOmlI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688758878; a=rsa-sha256; cv=none; b=o3he4OJRn/sXiuX/cSTsHTEyopQncgcC+2XHvkXjB5s/oNMoV7i0G3PqKsKFl2X7F3c+Vj 4ngyRfL70Mb+8NMEGmugaTf0KSWvnmSJ0s2rLbDGxAa+uCss30s7nB5wqNsfZGaIM13SSD AkC32aQxKfIZ18U9FFwS8uGsVXWw58M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gsvPIT99; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6A1961A17; Fri, 7 Jul 2023 19:41:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E629FC433C7; Fri, 7 Jul 2023 19:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688758877; bh=BIeNaJY/voqJfd9eF4kJLjzAy3Uzj1oevyqwzuncZRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gsvPIT99tQSE+DZ7q0ml7NndWr+YIdWiM+/tOR6whtqZxWXBeIP96OO2EubetbExF a8PEouGBKNZB9nhhVSCv5gJehoxDlnys1PI1zWpbTBKSp0uNv/8VAkFCcsrlfZgDnC Q6STSoVuJEI9/vKcwe9rqvvbyYlx2m0xiH0HbH38= Date: Fri, 7 Jul 2023 12:41:16 -0700 From: Andrew Morton To: Muchun Song Cc: mike.kravetz@oracle.com, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: hugetlb_vmemmap: fix a race between vmemmap pmd split Message-Id: <20230707124116.d7be4ba6504a452d11e2629d@linux-foundation.org> In-Reply-To: <20230707033859.16148-1-songmuchun@bytedance.com> References: <20230707033859.16148-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 859764001B X-Rspam-User: X-Stat-Signature: hqzaqukst35xpupx6bzx54i1jmuj4fh5 X-Rspamd-Server: rspam03 X-HE-Tag: 1688758878-820514 X-HE-Meta: U2FsdGVkX18oRuUgyRqf7lFCk5n4ow1w/HKDZ8eo4oGZzz/owY9r755lWbj7kPEwG2utAy1nkeSujChh2c5VW8gyE42rgPj2WvWtzPDWt9HoTqpqIaM/GyPwV+h3RVCrrwPgMqBbstm181RmjBM4C2x41b0Pbopa8KOtAVkvPnfEhgy9CXXAcvWo0zfbNPHuBCwQFVnyxfI/DmtJiJxqRcVuMVcUkXK4tdR4IMt2jLT6YbgOgmbPe5o+7OuDB0DmIkhRA5ESdDMoT/aIVEbKrQpXZJHRvq7v+n1RKOt0hugoS37pAN5hFgqz458DogWmu2T/H6z1M5P32aNP/WJQC+j4sM+XcUCAi1FvCConXIPngwTiVt6oncw1pH3CaslPPvWc+TTLsnZbNmrt+bQ2ggl/8zWQKRkTe6IB8g9CCUpWYTllV6u+FBqSERS6xjslGCBN6v0iYISsj4yskcyw+s+pQL8fiMQIjXxRYBArFwQ1QuUVDHkj5SecK9iyQY1ihH2ng9/t+APPz5AJ/TespEEfdK0AO5lEH+k1F8/Wz9l8fF1Px4o45dE2SR3tnbhSlTAbVb04BhbcI7hP8BpawpGm9oLiKLJtdFYU9QRTvivlRS6gim0AbWyn7yLuosSNOdWcuDLeeknGfGVvzaPd/p29p5lM0Jk6Qpp4nIdzNw/CnMAFv3cbH7wdN+qC1/GAnDkvqNLBimMu4/XrngM1YrsU9tcccRuEKH6Zdq7Vl442D0bhBXoLUyfGhXgGBhfjLdFp9dnp0WMFNzSVSJ3tn3hcj3vliccLaz6xD7GW91Z+6mU34n4f+rahj4p2y1ec5pSAis/0FDRcoCPnF37g0jvdeaR9JgURWElZjtq9B1q6pHH/w9BolxeZwpmo/dHdZRS4QoRL7aJAgcfeQzlideG+2vE8nqBQQUwiI+A2Jx9ifMNnlvSBOxnn2zMVF2iwRmnIoquh+sSj5ggHZaR WfkPdPqD Zt+ObVwMGcHD5LscM6+dYW244PPWAFtXC0S89L08Q6LbhKT+Ok0u4C37Y3dkXcUbxjslsMLTStwSLIq0QmsjO50kNZbvIe95u+NytEdpYfXAa7hHwzJxmIic8b6aWQmf/pqC+xw5n/l0IhT51BXPV/IO/J/nU1tkKENS4ep9CRnffuDQ1kNyvM/IHsoA62CWqL0bCiSA71diZ6VfTc3xgLj2VGTN5sbbtIU4O8gNoOLPOa5rTXdVyniAWzn4iG/vaLPbmASV/MAWpi1TjsCVAlZ1Jp7vJ6i449U8MO1NN5rNP/urisNnpm/fjGZ8GqBB9+O5pYsVBzgN4RgyVnMQ4Qjv/6BSBB+dEDUSGpsug6U/czkxfr2Z30NtJXZSupDxdHPCOxADPexRyFuk/hAhqQXwMLvHFygULwDzBfBkI1doiOWguKZZOBGGm1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Jul 2023 11:38:59 +0800 Muchun Song wrote: > And inline __split_vmemmap_huge_pmd() > since it only has one user. "open code" would be a better term than "inline" in this situation. If we are to offer this change to -stable then it would be better to do the open-coding of __split_vmemmap_huge_pmd() in a separate, later patch.