From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C40EB64D9 for ; Fri, 7 Jul 2023 12:24:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BE38D0002; Fri, 7 Jul 2023 08:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD308D0001; Fri, 7 Jul 2023 08:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB0038D0002; Fri, 7 Jul 2023 08:24:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DAC308D0001 for ; Fri, 7 Jul 2023 08:24:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A409F120D26 for ; Fri, 7 Jul 2023 12:24:39 +0000 (UTC) X-FDA: 80984734278.27.A93FF15 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id A0A8A180003 for ; Fri, 7 Jul 2023 12:24:36 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LqFRs1c1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WsVzOxtN; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688732676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v97Z4h87RrabL7WLNBXHFysNCdL5KIt8mtxxyrwI0lE=; b=OGCZuJ14uRTgBz0gvW5s6qD0QuDx8GV/gonTtnrzXFvMBRTUPZRAWVajpxaW9N3QswXhc/ dftDlIS8qRddBj7Dr0hiikriF45xozz/1IorGo9mbkXo08ydTIFUZgtEvD+xXtcWBeV2QF o1Xmw7CR3Y/YGsS6i5bM8QmgTuX87Rk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LqFRs1c1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WsVzOxtN; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688732676; a=rsa-sha256; cv=none; b=Bo2uNB16NvVzobt8ZzU3xQBx0skjrbmwZLUMIptPykjrwCpphHwNz30V17bi17di8w11Vw VwojK+4nhUEKzLepgGUxUB0pYsrZRZnEmywi5vJjY75Q+dEL9UqgEalj4JsvfidKjFv/gE Nc9RbNRo+KN1FvdpIsqEtI010/7c9zQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0C8D1FDB5; Fri, 7 Jul 2023 12:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688732675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v97Z4h87RrabL7WLNBXHFysNCdL5KIt8mtxxyrwI0lE=; b=LqFRs1c1G67BsNNDLuNq3gTOMo8UAqFT+ZgX0/ce2GYyjoNTkNY3JvymPyQUIIgvdCfdfA wvYabjfbqON86k1PsUxAyhGKf+BANbZ0orxg0fUOS7bjyZ5ddpTiVyICESJEtA4U8iKIIb 0Zu9Qq9rWpT0jHo3EjIE5diazY1476M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688732675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v97Z4h87RrabL7WLNBXHFysNCdL5KIt8mtxxyrwI0lE=; b=WsVzOxtNAjI8cmGR5IMHwFDPJM5ZBawTTSTtFHjjnpb4nomNuwaP8lcoennzww9M9DfIc5 k35MoJGFDmLh3vBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D97F7139E0; Fri, 7 Jul 2023 12:24:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rMQMNQIEqGT9NgAAMHmgww (envelope-from ); Fri, 07 Jul 2023 12:24:34 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6AC15A0717; Fri, 7 Jul 2023 14:24:34 +0200 (CEST) Date: Fri, 7 Jul 2023 14:24:34 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: <20230707122434.s46ytxpne42hecni@quack3> References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> <20230706161433.lj4apushiwguzvdd@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A0A8A180003 X-Rspam-User: X-Stat-Signature: kcyf3uykmfd8fki4psyjoghyqdhta8tc X-Rspamd-Server: rspam01 X-HE-Tag: 1688732676-205526 X-HE-Meta: U2FsdGVkX1+oVbnh0eHtu+BrCdIe7TEy64S1dCysQS6neXTn5KAr8Bil6OGas1UrqEktNX4g3o8/0L7aQjg8ZBwHd52v8kgshmWGftZeYJQsbjqU+iGRsmbkfRq33vjifxhMSgNKJMiwM8oV8ZYa0tJZj2Rg0fDSLV2Lb5wGpo77dtPezVd5vDzXy24iTwvfHgI0gdbVwxXYdKcd4duwegN9HLiOCoHRgNsO37LBrn26QLeL+ZJY6GlZ7S6K4mTaLllYqhSArDTGeiVBNnwcoEErG9PmfhHvOvem8TYSYdJfvfeklvdFmm0NR/xqY6P6nf4iloduojwhvBXARvSoP1F9FB5wh2eBno4JsyGrA9we652Xj1yEIGO8uJDQ5jOxvxL5tHgsh/my6CoHCT5ScLzy/R8I0i5OyM3eaL2g13KUqbWpr9VNZxGwxcOUptAzEVtuiS5aVMJnJJThc6asl5eTd0Rp8x5yTTGHGIX6jOmDma0+lg8dxonalnhGzEAlDAEmA8T8NR0S/ZIb0jJtuq6meVHce6bIFtLLQyAz6XSbYXXFW1vV0+uuHtaenxsKm+sJJb7f+1cAoOXQhep+NzoiGSkimFEZeIg1I4fzp9yoBhZBj3M7DxjmVRCi3ovQQid8IsmEMK+hYPUwh6kosu4ligYARWZVx/UY8zKpQB8j2TmU5ldO8HwdT6nTT1x3TPAkAN2s9ff7Q7gtC31EO4lsTwLOtR9MeXTysvAAlGoxzhAD2Vo6ypRgXvnkmilHDW0vWkzMBKfdqfLmnPsaoCMrpsv21qsgHZkLWFsrzc244vkMzM1HDQ9kQypLvyHvCq3BsXZWsMOMBTRY4DAAynyHQZAaQYnYVGfjDHLQiEQ/56BQFI2qp95qgplyzigxfsMWW8KZed0kY868MnFFS485ubEn6fD2/uf24867h0FuF3xFXI5JfAyCl8SGfSvp0hCFWjeLcfOkNmRgbBi SAcOhaB3 hQKcrP2gJuDC1qqQ7yOUNRkh2qItd0tJsLK6KoW4/+YJeqxUI6trU1f0iXGlIVCUIByda8STJGQ1vjuZlRBZ6brpTU9ckkA0aYwsOpq1PX4XJKvqDzyQRhNWThZEcQSPgMyfm6JNi1apnt4pOUU3qS0WoZJerYxS0cWeCfLZogE2JSxeJhQBWdpIK/9jq3ZYIr9osqHAOfZcmfFm2F2OFObDQX/51niVTIIRJuXsVDh+FmdA4Zi7uaXvFHO1TZLA0GtGfNOSn3q/BZvzpbk7M/EW0S26UbO2PN8YkX456BHmvnZVcvxs6sPPzQJP0AlVEQw+5H4vo2G39k+Oj5pUkXzGg2KNn+sDu+gmLgJCI1qYusznGEyO77oEdNO9i2VwoW1F3b9GxRzXRVMPH+JvSvqUSiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 07-07-23 04:28:41, Christoph Hellwig wrote: > On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote: > > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > > void *holder, const struct blk_holder_ops *hops); > > > void bdev_release(struct bdev_handle *handle); > > > > I'd maybe use bdev_close() instead of bdev_release() but otherwise I like > > the new naming. > > We're using release everywhese else, but if Jens is fine with that I > can live with close. Dunno, to me words pair like open-close, get-put, acquire-release. Furthermore e.g. ->release() (and thus blkdev_release()) is called only when the last file reference is dropped, not when each reference is dropped, so that's why bdev_release() seems a bit confusing to me. Honza -- Jan Kara SUSE Labs, CR