From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832C4EB64D9 for ; Fri, 7 Jul 2023 10:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E49A8D0003; Fri, 7 Jul 2023 06:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1949D8D0001; Fri, 7 Jul 2023 06:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0837B8D0003; Fri, 7 Jul 2023 06:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E8C2D8D0001 for ; Fri, 7 Jul 2023 06:32:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AC58E1C7E1C for ; Fri, 7 Jul 2023 10:32:44 +0000 (UTC) X-FDA: 80984452248.27.389D09D Received: from bjm7-spam01.kuaishou.com (smtpcn03.kuaishou.com [103.107.217.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 694A640003 for ; Fri, 7 Jul 2023 10:32:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kuaishou.com header.s=dkim header.b=UuyMOdWC; dmarc=pass (policy=none) header.from=kuaishou.com; spf=pass (imf12.hostedemail.com: domain of yangyifei03@kuaishou.com designates 103.107.217.217 as permitted sender) smtp.mailfrom=yangyifei03@kuaishou.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688725962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=elR/CUA67bIsrY8k02zjWmaLHSSZNGva7b2+ov2x4wY=; b=koBFjnJRrtzZorvm74lo070fW+1lvMJySyQfp/L/v5Atz/sMR9g3CpnXBCNnIlZDzoIJrR 0d4Sz3BdKo6SJxAOS2KXAOAFqCp5GQduFajYRChzcdViTC6SgPDtjGpJDMOg9lMB33LAw5 znpsrvAiZ7HqKafUcuJxnDMUSe01XHY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kuaishou.com header.s=dkim header.b=UuyMOdWC; dmarc=pass (policy=none) header.from=kuaishou.com; spf=pass (imf12.hostedemail.com: domain of yangyifei03@kuaishou.com designates 103.107.217.217 as permitted sender) smtp.mailfrom=yangyifei03@kuaishou.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688725962; a=rsa-sha256; cv=none; b=WxpeODvZokybEXzr51+RPVi82bGpmtKZ4BkfiF4Adyr8NiScCbr6n9KmPn1lf1ANhlNETu rPZVPmVj2lYMlEair3qkZxYXmVJyb0A5HpDskLUP8HOKbdZj4JLLA6BqT6Ce1zR1tJKcim XynsjRjsavzO6X9LTDVQdMvvkd+W5+U= Received: from bjm7-pm-mail12.kuaishou.com ([172.28.1.94]) by bjm7-spam01.kuaishou.com with ESMTPS id 367AWXfQ050673 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 7 Jul 2023 18:32:33 +0800 (GMT-8) (envelope-from yangyifei03@kuaishou.com) DKIM-Signature: v=1; a=rsa-sha256; d=kuaishou.com; s=dkim; c=relaxed/relaxed; t=1688725813; h=from:subject:to:date:message-id; bh=elR/CUA67bIsrY8k02zjWmaLHSSZNGva7b2+ov2x4wY=; b=UuyMOdWC5iW9fEjfe1Vpy31A1lQ9H9REeiFSO7aFfHoRbJuwscXaaVRbdqwtD48iD9SMuxrWawJ l+NvtFDcR4vYQ3S38eqLAht9pDl+IQW+uBXabsLyKGW1UWoECjsOQZfLuvQWb0ue77/iN4Pkrkm86 AUnOpFcmRH+s8a9nYTc= Received: from public-zl-rs11.idczw.hb1.kwaidc.com (172.28.1.32) by bjm7-pm-mail12.kuaishou.com (172.28.1.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Fri, 7 Jul 2023 18:30:13 +0800 From: Efly Young To: CC: , Subject: [PATCH] mm:vmscan: fix inaccurate reclaim during proactive reclaim Date: Fri, 7 Jul 2023 18:32:26 +0800 Message-ID: <20230707103226.38496-1-yangyifei03@kuaishou.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.28.1.32] X-ClientProxiedBy: bjxm-pm-mail09.kuaishou.com (172.28.128.9) To bjm7-pm-mail12.kuaishou.com (172.28.1.94) X-DNSRBL: X-MAIL:bjm7-spam01.kuaishou.com 367AWXfQ050673 X-Rspam-User: X-Stat-Signature: uxt31s4zzagabgid8rkjf1uh16hs1yyf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 694A640003 X-HE-Tag: 1688725960-521796 X-HE-Meta: U2FsdGVkX1/2ApcBw/ChA5ZHt5af+vix8819/jjko5Y8/VYFKJ9fx1+qah9YWYwKPfJpHbwhVT0kmWXrFCKfQCsS4Wf9q8ldIP8q0OMcNmMl3kwmiuVALBoFiixMgyof5vUZv5vcT829AJ96Fypan2vI6BxT6PWT0FEGFYsD5x4idBBiuGCik2Q4+mca4m6sRNy6/18aCumh9UVezn9tTHtQ8RFGJNkIaB8yRlM61J/U9uU3hhQ4MCRxFZ6OcBfzKp9UrrGodcUXME5fVifLjScDBWAn/JbIi4IjDn/wdGfrGtm3FnExN9pzImlNhjGhnK8VzqX6z+aliQFoVmQIQVbRRFUOKv+7DuUJweFX+pXVbWoS899h7mp8fsdQ+aba/DHh+LvLVqvu6vEhzNlBK3uDXvUB8S/1GNIEEaFW0VP4H/Nhk85GbVKoAM1xoGe/g5ghf3aF8M8HAZyhI4cQaXt48plcFCmVi15OGVIv7HNq+dmr5whpqTX2xXTgt+LyTs/JIzASSzckge72cUp2B8pvFA6HlIyTE4VneyS1Tt9CzEroQOsPl3eMZOwLR9ydhJ1ElpiX/c+zSWj98mUYyir60V7JGXVm1Jil3LsoojWaINbm1yJIPGZnMMMFjDFO6J2dECOwbSd/NG+UPRK76S6q8kngPzpQDU4ljrfkBNEeyzHIUXw5oGwgSsvKOHhmuvCOI/zmULpW9Cbj41vYXH0sS750bBc23/EfrlYWhiGfdKUN1978ZawGhBTwieP9bDeF4RqTPztQMk7dyHY89ckr7Oqp97YkqT/3Pt5EVFXWRE4UMwEV0fgCtDmRai8Uf4XrFWwl3YviD6El7o4zUIP1YiP+n/LPS4iqnLBG4f4JkLsIYkWSNN48r2ZHh9p+0PVXkTwJTKUJrU7a2Xvjhd/0J1/IdHJgh++wJ3/2QrXd+A/vnWdYSs0GLeBIXuoWMdzD4wSLTxofalTNqlK YgdZ05Bh YZAn9MeiCgv9WTGazX/VkQALyx1zYW9GRC5wNdN+dWa7rgenfAvYW4jcj1xyguf7TeIiqa2vD+UJ2b79PERUieyJc6fjmBfc6ibxY6lvytSYVUdQKrrRZaEACwdtTzoj5aX3TVEC2/HnuduEsQUOyPdnJPPhFyZ5r+wUy5ieQjlz6SgslTk4WT6Dfgt+RLFqe4bOhs/mxqyTZjnJr1NWVtRCpDcw0WQjihYyGXjWkEuuYDNcFLifIG4kLyEvLo40wd/S1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: With commit f53af4285d77 ("mm: vmscan: fix extreme overreclaim and swap floods"), proactive reclaim still seems inaccurate. Our problematic scene also are almost anon pages. Request 1G by writing memory.reclaim will reclaim 1.7G or other values more than 1G by swapping. This try to fix the inaccurate reclaim problem. Signed-off-by: Efly Young --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 9c1c5e8b..2aea8d9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -6208,7 +6208,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) unsigned long nr_to_scan; enum lru_list lru; unsigned long nr_reclaimed = 0; - unsigned long nr_to_reclaim = sc->nr_to_reclaim; + unsigned long nr_to_reclaim = (sc->nr_to_reclaim - sc->nr_reclaimed); bool proportional_reclaim; struct blk_plug plug; -- 1.8.3.1