From: Efly Young <yangyifei03@kuaishou.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm:vmscan: fix inaccurate reclaim during proactive reclaim
Date: Fri, 7 Jul 2023 18:32:26 +0800 [thread overview]
Message-ID: <20230707103226.38496-1-yangyifei03@kuaishou.com> (raw)
With commit f53af4285d77 ("mm: vmscan: fix extreme overreclaim
and swap floods"), proactive reclaim still seems inaccurate.
Our problematic scene also are almost anon pages. Request 1G
by writing memory.reclaim will reclaim 1.7G or other values
more than 1G by swapping.
This try to fix the inaccurate reclaim problem.
Signed-off-by: Efly Young <yangyifei03@kuaishou.com>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 9c1c5e8b..2aea8d9 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -6208,7 +6208,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
unsigned long nr_to_scan;
enum lru_list lru;
unsigned long nr_reclaimed = 0;
- unsigned long nr_to_reclaim = sc->nr_to_reclaim;
+ unsigned long nr_to_reclaim = (sc->nr_to_reclaim - sc->nr_reclaimed);
bool proportional_reclaim;
struct blk_plug plug;
--
1.8.3.1
next reply other threads:[~2023-07-07 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 10:32 Efly Young [this message]
2023-07-07 19:09 ` Andrew Morton
2023-07-07 22:55 ` 答复: ?????!?Re: " 杨逸飞
2023-07-11 15:28 ` Johannes Weiner
2023-07-12 7:42 ` Efly Young
2023-07-11 9:43 [PATCH] " 杨逸飞
2023-07-20 7:27 Efly Young
2023-07-20 16:24 ` Johannes Weiner
2023-07-21 1:41 Efly Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707103226.38496-1-yangyifei03@kuaishou.com \
--to=yangyifei03@kuaishou.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox