* [PATCH -next] mm: Fix some kernel-doc comments
@ 2023-07-07 9:00 Yang Li
0 siblings, 0 replies; 2+ messages in thread
From: Yang Li @ 2023-07-07 9:00 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Yang Li
Add description of @mm_wr_locked and @mm.
to silence the warnings:
mm/memory.c:1716: warning: Function parameter or member 'mm_wr_locked' not described in 'unmap_vmas'
mm/memory.c:5110: warning: Function parameter or member 'mm' not described in 'mm_account_fault'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
mm/memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index db42a3e939d5..ceff67b5a0e0 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1698,6 +1698,7 @@ static void unmap_single_vma(struct mmu_gather *tlb,
* @vma: the starting vma
* @start_addr: virtual address at which to start unmapping
* @end_addr: virtual address at which to end unmapping
+ * @mm_wr_locked: lock flag
*
* Unmap all pages in the vma list.
*
@@ -5091,7 +5092,7 @@ static vm_fault_t __handle_mm_fault(struct vm_area_struct *vma,
/**
* mm_account_fault - Do page fault accounting
- *
+ * @mm: mm from which memcg should be extracted. It can be NULL.
* @regs: the pt_regs struct pointer. When set to NULL, will skip accounting
* of perf event counters, but we'll still do the per-task accounting to
* the task who triggered this page fault.
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH -next] mm: Fix some kernel-doc comments
@ 2023-07-27 1:55 Yang Li
0 siblings, 0 replies; 2+ messages in thread
From: Yang Li @ 2023-07-27 1:55 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Yang Li, Abaci Robot
Add description of @mas and @tree_end, remove @mt in unmap_vmas().
to silence the warnings:
mm/memory.c:1837: warning: Function parameter or member 'mas' not described in 'unmap_vmas'
mm/memory.c:1837: warning: Function parameter or member 'tree_end' not described in 'unmap_vmas'
mm/memory.c:1837: warning: Excess function parameter 'mt' description in 'unmap_vmas'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5996
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
mm/memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index 2130bad76eb1..49bf57aae7e1 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1813,10 +1813,11 @@ static void unmap_single_vma(struct mmu_gather *tlb,
/**
* unmap_vmas - unmap a range of memory covered by a list of vma's
* @tlb: address of the caller's struct mmu_gather
- * @mt: the maple tree
+ * @mas: the maple state
* @vma: the starting vma
* @start_addr: virtual address at which to start unmapping
* @end_addr: virtual address at which to end unmapping
+ * @tree_end: The maximum index to check
* @mm_wr_locked: lock flag
*
* Unmap all pages in the vma list.
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-27 1:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-07 9:00 [PATCH -next] mm: Fix some kernel-doc comments Yang Li
2023-07-27 1:55 Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox