From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B41DEB64DD for ; Fri, 7 Jul 2023 00:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07EDE8D0002; Thu, 6 Jul 2023 20:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02EA58D0001; Thu, 6 Jul 2023 20:29:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38328D0002; Thu, 6 Jul 2023 20:29:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D40688D0001 for ; Thu, 6 Jul 2023 20:29:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 95F5DA06E3 for ; Fri, 7 Jul 2023 00:29:00 +0000 (UTC) X-FDA: 80982930840.24.8003D6C Received: from out-7.mta1.migadu.com (out-7.mta1.migadu.com [95.215.58.7]) by imf02.hostedemail.com (Postfix) with ESMTP id C97A88000B for ; Fri, 7 Jul 2023 00:28:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D+NHfSZJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688689738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lsh6MjdQ0KBHzuwAeoaHvgzWnP9TaDfDS/YmZHIn9sU=; b=6CdQpKg+dmIln60XNzzvKFjuRzpl+glsrRIcolAyS7T5+8M1THFvWUpF1lIZk985/DF0fj FJg0n7k0iIiNdjOOrSJPOI0fCdceRwUXtbd2Wlgoii0Lt/yNMYDCVlTUAOmVy4iXrj3KAC lEv5HVZqC18tAmynnQ0zaz7Vwl+bvhc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D+NHfSZJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688689738; a=rsa-sha256; cv=none; b=7S+MWHJyMJCcYCYEMsPl+2MuFPedv4Rx8fTy9XrG8N5Q02Q1I7FMUpNtzjv13TUqTIqDxd UgPbSMKPyT1yho2fxt3vp+H2+8O5YksmyBlP1Q+SMfNdBpr0VISBcNkKYNrRFuJu+U3B72 ALFeQL6NOiKES2OlegBbyeEyOgX4pGM= Date: Fri, 7 Jul 2023 09:28:41 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688689731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lsh6MjdQ0KBHzuwAeoaHvgzWnP9TaDfDS/YmZHIn9sU=; b=D+NHfSZJ7dtg6xct7bIgm2tX7On2PzW4RmxD2jBqXPb6KzZs9dEwU7UojNDj6ZjajJnpo3 BxYvND1K6/jGPcrUM8/Z0UYtOsskMuuGrYxh+WXYsptindqWkBxWmfgx0QAprv77nn34qo sX7ASyPSDGKTrFy34JZd1tMMSyrG31k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Jiaqi Yan Cc: mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v2 3/4] hugetlbfs: improve read HWPOISON hugepage Message-ID: <20230707002841.GA72816@ik1-406-35019.vs.sakura.ne.jp> References: <20230623164015.3431990-1-jiaqiyan@google.com> <20230623164015.3431990-4-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230623164015.3431990-4-jiaqiyan@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C97A88000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6dcqytqtu93743n791emkw9zokyru3it X-HE-Tag: 1688689736-16499 X-HE-Meta: U2FsdGVkX19Ku3qmWNM3g85v0qRoxPPwgpRwh47jL+pK2mImdR5G/bpyP8iDukAOQFQb+vkvdslNBI2v9DK53TerMh6ICd3a/zzKNRHxsOSLXXcwWGEkdXrDAJtrZcEwlDvJzTb/jbwCfzpb+POqY6gXPkx2vz0t+VlyZy4tTLWZIK02MUv9KMNDVtQjRNCSdeD7hsVMuhl0g8rGSWMjoApjBocyMQdBOTWIu7jwJpdLWK0QDN9VTa6Bb7RP7PnuapmczcIsXoOb2uPUZNHezXngl0wuMLzl8QPgi/czsFjVg89C6RK6sd3deis4HHOOh73CZ/VqN5eH6IowHJwCPCGfaznJrK1L393yXAr/ys6gnpUs/vGu6EEnumEVP4SXW5lMtmSXN8Ktg57NnPfAAr8sBhAqRi6Lirfd7CKuGEerlmoVa+73/v44oCAJAn51BRHW+rE6fRVelkcBC2y1ptIrcdVv3d0LqvezeVZmbSHZ/IYyyy84lEKdHRLZoUgeFfdVegOdhul1feQM6pSHn/JJS+899koXeAR/EpsoLI8QabhV5z9i6s6okMzdX5q7rbkCaWFW+Jo9rUpvvV8LfZcs2vl0CCuSOq3UemcxQXfe+zVJm1mUw0us0KMjl5FtEhRo23C3YYPTy8ZsZwHe+mkYr8MEfwijlje6oj/VezEWu1b/V0NlGwejDJeesVlV/TyXUWDUM0Y6GyOKySHJKOjWgk8IQWRHNVz5FGWH0Ur7XjQfg3bpw2xsOhaxy1iS3alFc9+pR9RqjIhFhl4q3P3MzgGkHpSt4WSG0YZ+LGz7sENtCc1E22cPe/J57qe1NC1N8krgNDXCkoIVUg1qHBYhoFAUPMeKWKmIn9ZOhvPGB6bSHvidTvWkmvixilCr7fdCtTvGNJXQeNcVh3VIoPEphktI766+ZEnGMpDmwY54YhMHa7CvqnYm0RoWBNtSpHd6JeBC9Wpw1yWXXU5 ojN4n0oG ZR4CiUenJFz8waVHGGcRF2BZ+qonabPjFzCLrE0kxrAywYAxYf3oOfPjSaLfG+0uU8bgA3YNe4VPO/fSTgZ8V/J8g9qH0oOLSdxm1VJ7quq9SLeRIjTTOazyOQrZB4rZJVBZwYhgXgaM+Gu4wywBb0RLFvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 23, 2023 at 04:40:14PM +0000, Jiaqi Yan wrote: > When a hugepage contains HWPOISON pages, read() fails to read any byte > of the hugepage and returns -EIO, although many bytes in the HWPOISON > hugepage are readable. > > Improve this by allowing hugetlbfs_read_iter returns as many bytes as > possible. For a requested range [offset, offset + len) that contains > HWPOISON page, return [offset, first HWPOISON page addr); the next read > attempt will fail and return -EIO. > > Signed-off-by: Jiaqi Yan Looks good to me. Reviewed-by: Naoya Horiguchi