From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: Jiaqi Yan <jiaqiyan@google.com>
Cc: mike.kravetz@oracle.com, naoya.horiguchi@nec.com,
songmuchun@bytedance.com, shy828301@gmail.com,
linmiaohe@huawei.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
duenwen@google.com, axelrasmussen@google.com,
jthoughton@google.com
Subject: Re: [PATCH v2 3/4] hugetlbfs: improve read HWPOISON hugepage
Date: Fri, 7 Jul 2023 09:28:41 +0900 [thread overview]
Message-ID: <20230707002841.GA72816@ik1-406-35019.vs.sakura.ne.jp> (raw)
In-Reply-To: <20230623164015.3431990-4-jiaqiyan@google.com>
On Fri, Jun 23, 2023 at 04:40:14PM +0000, Jiaqi Yan wrote:
> When a hugepage contains HWPOISON pages, read() fails to read any byte
> of the hugepage and returns -EIO, although many bytes in the HWPOISON
> hugepage are readable.
>
> Improve this by allowing hugetlbfs_read_iter returns as many bytes as
> possible. For a requested range [offset, offset + len) that contains
> HWPOISON page, return [offset, first HWPOISON page addr); the next read
> attempt will fail and return -EIO.
>
> Signed-off-by: Jiaqi Yan <jiaqiyan@google.com>
Looks good to me.
Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
next prev parent reply other threads:[~2023-07-07 0:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 16:40 [PATCH v2 0/4] Improve hugetlbfs read on HWPOISON hugepages Jiaqi Yan
2023-06-23 16:40 ` [PATCH v2 1/4] mm/hwpoison: delete all entries before traversal in __folio_free_raw_hwp Jiaqi Yan
2023-06-30 14:52 ` Naoya Horiguchi
2023-06-30 20:59 ` Jiaqi Yan
2023-07-02 23:50 ` Naoya Horiguchi
2023-07-05 23:35 ` Mike Kravetz
2023-07-06 18:11 ` Jiaqi Yan
2023-06-23 16:40 ` [PATCH v2 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Jiaqi Yan
2023-07-05 23:57 ` Mike Kravetz
2023-07-06 18:25 ` Jiaqi Yan
2023-07-06 22:06 ` Mike Kravetz
2023-07-07 1:27 ` Jiaqi Yan
2023-07-07 1:06 ` Naoya Horiguchi
2023-06-23 16:40 ` [PATCH v2 3/4] hugetlbfs: improve read HWPOISON hugepage Jiaqi Yan
2023-07-06 22:09 ` Mike Kravetz
2023-07-07 0:28 ` Naoya Horiguchi [this message]
2023-06-23 16:40 ` [PATCH v2 4/4] selftests/mm: add tests for HWPOISON hugetlbfs read Jiaqi Yan
2023-07-06 23:22 ` Mike Kravetz
2023-07-07 0:51 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707002841.GA72816@ik1-406-35019.vs.sakura.ne.jp \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=duenwen@google.com \
--cc=jiaqiyan@google.com \
--cc=jthoughton@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox