From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3837EB64D9 for ; Thu, 6 Jul 2023 22:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A51F8E0003; Thu, 6 Jul 2023 18:51:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92FA28E0001; Thu, 6 Jul 2023 18:51:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7822E8E0003; Thu, 6 Jul 2023 18:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 630BD8E0001 for ; Thu, 6 Jul 2023 18:51:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 37B401C80A9 for ; Thu, 6 Jul 2023 22:51:09 +0000 (UTC) X-FDA: 80982684258.10.3393B39 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf21.hostedemail.com (Postfix) with ESMTP id 6EDF51C0018 for ; Thu, 6 Jul 2023 22:51:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EK01mLyp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3WkWnZA0KCK0NkRYeNfZhffRaTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--axelrasmussen.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3WkWnZA0KCK0NkRYeNfZhffRaTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--axelrasmussen.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688683867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vNyM+7c0est1wcVkLGeYyWS2zFzaKr32nANrKlDiGpI=; b=yjjsEN+P2YsB5lMgZhmzFCWUcboJOASh0yl/YOhhCUptxbKADZyRkrkGXcu8ddqJiI8y9o iN7YXENPvjFO7rUi+dCrLTPqw09m3kyCH3Hj9W77a+o9KPa3jlIGLIPnV5LoD/2/x5S4AO NF2yhAkpXNtXTBphrVLEOjPITULzvCc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EK01mLyp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3WkWnZA0KCK0NkRYeNfZhffRaTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--axelrasmussen.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3WkWnZA0KCK0NkRYeNfZhffRaTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--axelrasmussen.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688683867; a=rsa-sha256; cv=none; b=yRZRY/ho+C8ecPa/TLZo4teZTHMZraNtZIAHJmVxjOiIYK0orKKDdV7G+4sRsM/gFs5Ayz 9bXTZx4zvdmc5aEnsutKEMkUABZbD1v3L1CFnXm+7iKKQfJxPyzG8B21Xj9E479R0A6j9U /zeGA0i6d3qahIX3yDS/KcKtnjRgx/M= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-c6c616faa39so541305276.1 for ; Thu, 06 Jul 2023 15:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688683866; x=1691275866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vNyM+7c0est1wcVkLGeYyWS2zFzaKr32nANrKlDiGpI=; b=EK01mLypW26xwbB17tl+WVi77pgJ0OApJdOy0ZdOVv84/lYvfVuW7WowZ4rEK8f7WX g4rTBFdn/gfopVFptl2AY7oR1MbOxcuKJ5NLlgJS4KZnwJQ/O9DYar58Cp6+LJtem2dz 7aV6c0xPB8rtx/DVLBBYyqqPk4Y5aP7bx24BzHZVQh7fjXNIuWh3WsjiPncdyuOWOy0f szlc4nj/Zd3/Khbkib9ISdsge3HmKG+4el8u83yJEUvEUWR2sl14PZi/zm9NTrqicFDS XKFqXwSRFH+ICd8i9r7ldw2FSna2YUHpUhgptiJGArRniVNPuiWl7n0jMNBuoRiJ6+di 6/Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688683866; x=1691275866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vNyM+7c0est1wcVkLGeYyWS2zFzaKr32nANrKlDiGpI=; b=Xm7/cGu/MHCEXa+jNc2LKgtk+VTt0qjuvdHZTpZ8fI733icvBTs+WbtAycv4f7CMoW XY8K1g9AiwpWA1iuompg4OpzUWPn/B9XAQIaiKb9xNV5oJ23Pwi+J7NCN+moeqXGVBT+ Bezr7rsZOfTXF9yeqAiLSE4J2sP0ph56ph9EYkQGaBHrTCelqO5eVn4GTOwDboPe3QJN uIqQRnXm1SHouLi5Ze/zP/Vl/5HZK3U3bbWT+Hu82C3GbiWNwBE3qe8qJU/QkqVil+rW L0cQ07TXV4ePX6RHfLbzv/yVlt41Ff6wz/UygoY71KWlTgMix5NPMhVVAQJ3m1IRHZli S5oA== X-Gm-Message-State: ABy/qLYkgFK1Pq7mvP7KZWgD7zljZt6SJJVXlJs5YPYangt++HwKI0m0 Y1WkoMFhuA1+OPND64WiD39aUbRIJR9/zTPxOQlS X-Google-Smtp-Source: APBJJlHgoq6fX5m1+Roj1PD+nUlgNcdctSDPa98kXCzajWjYbfEt4nefdrt/24V9AOah7Hkvx+a3A+kIbPjrz61F6Iqg X-Received: from axel.svl.corp.google.com ([2620:15c:2a3:200:bec3:2b1c:87a:fca2]) (user=axelrasmussen job=sendgmr) by 2002:a25:ab90:0:b0:bc4:a660:528f with SMTP id v16-20020a25ab90000000b00bc4a660528fmr39975ybi.5.1688683866544; Thu, 06 Jul 2023 15:51:06 -0700 (PDT) Date: Thu, 6 Jul 2023 15:50:36 -0700 In-Reply-To: <20230706225037.1164380-1-axelrasmussen@google.com> Mime-Version: 1.0 References: <20230706225037.1164380-1-axelrasmussen@google.com> X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog Message-ID: <20230706225037.1164380-9-axelrasmussen@google.com> Subject: [PATCH v3 8/8] selftests/mm: add uffd unit test for UFFDIO_POISON From: Axel Rasmussen To: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Peter Xu , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Axel Rasmussen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6EDF51C0018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ojkrhwswub1qy4ncqdurrbx8ijddo8py X-HE-Tag: 1688683867-121304 X-HE-Meta: U2FsdGVkX19e9trafK3sSmrxnKntE9d+RZ/ndcphClkzdT8pOr/Lx+SDCp8Parw9RZNGsbLTf61blyic0Neq+bRoDevNYom9r9/ZDTY8GfcihF01xUk05XEy+SIECDQEejFguIG2vETJmbXqz5xgC791ibZiEG42A9NSk/xpYE8WVB0JxJxYaQa/0Nt9Mit8ur7vDq/Z5LhHbnxUB6F7KjX1p+Lo3DuOPG4TAVqNW6iuoHnkJ0ygCZ7ltoPYcRLYXe5rR/otK+GF7YO2py2oTu5+Hf7b2rRhx8ECv1F3RShjCVFv8c7M5cXiSA0JEwQNmW7/HV+WeH5GTmX+RNJR1kdAPp1ruNuWlky+vnWfwTEyKwcIp9C7YefGvp8qDvFCl3BL55PPueRqX7BiMK/JssA7m7pTIIKTZQVUci/mPR8zX+sojZ1wBqk/fz3C2/JiF+e0L1WqtCsOcVmIKEbmpZNQcQPOsyrk1jcOJIVuRXMo/Xs+wXNz4bkML9nHPjle1V0BMjBIIrXF3vWOGpLgofsGyWJ1qwsHvsjIL4pJxY1gsZUcVdRtroLfM/OnRigglVNrbMca6KIiAXjAgROv9XHCo/YCD/XauZBsrmAYGkDfLo8xujinhebbJuo5ZP9i9GJ8pu/Bquiv7qyiN+2po4dwZnclzrB9xWVK+FrzGdYuWTc3MCOVlaMscEjML4gq9EUoPEcNlF53ET3QKYClNX2bDwVV7oAdzJAcQw6sIrVvvLpDQFZ3RL1hrQ7LPLOHrlkoAFuXzx18vSVSZ9iELjsouag+J49A2ND2rCJUELvTtoZGaRSYDYyJoGRIcYA5P5O4L6p1PuyCXGnnqhMz+GRwf25+iSQL6qkenyRCcCOiwtUkWUwePwuLppBzK1LfrPRF1ljokuuuc5JP+68qp5HLyq5gbO/Z7DiuoSw5pxDderAWeRfw5WlF2KW/VaZ71+NU6KGx3awJciLE1fz 2PUlgT67 W/bBiOS7We8LrKjH6se9uP617UDphVLh0UyD+zc0/kTJHLu+3RVTvouXKzRW0tQFQYklMcYJSnWatLM2Zlnheoyv4ta+P/QX+dWFlNToCDlV51E3zS4L7l6WkUk9sQAA9ZFAmPe7RfmuEWhcrbQLDYOjDXwvNClzdjOLrq/w6pmWVJq793O9n6FPABgNYw3G5kawMsIyaCi5xtKNBJqe5GgWhcv3U2gwVNvXERHa98YBiCy+ucBZFwEPiOpsHrgOj145t9Kd0m2XgOZ359yQX3wf7yKIX7NRfxltXYVkLJBwDHo1N2omPeQrjGyIExNfIUfIacmDe98QCEHP9Ub2AIXDc2ysfTWWzw1dUOha6ZfZrv+Fp/SZJ4uueXs/+duHTjlcAtHPqfF+ljbA5/Kf7FHYkGU+cI65pLsNRBihz+mZscFo07493w1vNM0al1xDos/idHSvW4D+j0dbTUre14kuD24Htx0GpfWyszC3fQXA8xb0iHdHcwR86ynWrJVpcoYGoffoZ8hCISb2sFJ8KMiSYkjvMl3ymplqGKgKTbMeYmQRCvPf0J2c8zGg60Ve5BkhAMWnoj9b1oyOL7elrnrAR2pJFpjfJ91BQZB5LrlHyzpXV681g886iWhadOuRGdfN0g6tUYhOFuS8nxPU6iAFJdqjLnX3tiWx6R9HRUzKXM7B9L2crgMGv1Ph/W7XRREzF5t2f7LxeWd7LIx2gowY/ZJdIoe4MoT0RegJg4a4S0xg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The test is pretty basic, and exercises UFFDIO_POISON straightforwardly. We register a region with userfaultfd, in missing fault mode. For each fault, we either UFFDIO_COPY a zeroed page (odd pages) or UFFDIO_POISON (even pages). We do this mix to test "something like a real use case", where guest memory would be some mix of poisoned and non-poisoned pages. We read each page in the region, and assert that the odd pages are zeroed as expected, and the even pages yield a SIGBUS as expected. Why UFFDIO_COPY instead of UFFDIO_ZEROPAGE? Because hugetlb doesn't support UFFDIO_ZEROPAGE, and we don't want to have special case code. Acked-by: Peter Xu Signed-off-by: Axel Rasmussen --- tools/testing/selftests/mm/uffd-unit-tests.c | 117 +++++++++++++++++++ 1 file changed, 117 insertions(+) diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 04d91f144d1c..2709a34a39c5 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -951,6 +951,117 @@ static void uffd_zeropage_test(uffd_test_args_t *args) uffd_test_pass(); } +static void uffd_register_poison(int uffd, void *addr, uint64_t len) +{ + uint64_t ioctls = 0; + uint64_t expected = (1 << _UFFDIO_COPY) | (1 << _UFFDIO_POISON); + + if (uffd_register_with_ioctls(uffd, addr, len, true, + false, false, &ioctls)) + err("poison register fail"); + + if ((ioctls & expected) != expected) + err("registered area doesn't support COPY and POISON ioctls"); +} + +static void do_uffdio_poison(int uffd, unsigned long offset) +{ + struct uffdio_poison uffdio_poison = { 0 }; + int ret; + __s64 res; + + uffdio_poison.range.start = (unsigned long) area_dst + offset; + uffdio_poison.range.len = page_size; + uffdio_poison.mode = 0; + ret = ioctl(uffd, UFFDIO_POISON, &uffdio_poison); + res = uffdio_poison.updated; + + if (ret) + err("UFFDIO_POISON error: %"PRId64, (int64_t)res); + else if (res != page_size) + err("UFFDIO_POISON unexpected size: %"PRId64, (int64_t)res); +} + +static void uffd_poison_handle_fault( + struct uffd_msg *msg, struct uffd_args *args) +{ + unsigned long offset; + + if (msg->event != UFFD_EVENT_PAGEFAULT) + err("unexpected msg event %u", msg->event); + + if (msg->arg.pagefault.flags & + (UFFD_PAGEFAULT_FLAG_WP | UFFD_PAGEFAULT_FLAG_MINOR)) + err("unexpected fault type %llu", msg->arg.pagefault.flags); + + offset = (char *)(unsigned long)msg->arg.pagefault.address - area_dst; + offset &= ~(page_size-1); + + /* Odd pages -> copy zeroed page; even pages -> poison. */ + if (offset & page_size) + copy_page(uffd, offset, false); + else + do_uffdio_poison(uffd, offset); +} + +static void uffd_poison_test(uffd_test_args_t *targs) +{ + pthread_t uffd_mon; + char c; + struct uffd_args args = { 0 }; + struct sigaction act = { 0 }; + unsigned long nr_sigbus = 0; + unsigned long nr; + + fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); + + uffd_register_poison(uffd, area_dst, nr_pages * page_size); + memset(area_src, 0, nr_pages * page_size); + + args.handle_fault = uffd_poison_handle_fault; + if (pthread_create(&uffd_mon, NULL, uffd_poll_thread, &args)) + err("uffd_poll_thread create"); + + sigbuf = &jbuf; + act.sa_sigaction = sighndl; + act.sa_flags = SA_SIGINFO; + if (sigaction(SIGBUS, &act, 0)) + err("sigaction"); + + for (nr = 0; nr < nr_pages; ++nr) { + unsigned long offset = nr * page_size; + const char *bytes = (const char *) area_dst + offset; + const char *i; + + if (sigsetjmp(*sigbuf, 1)) { + /* + * Access below triggered a SIGBUS, which was caught by + * sighndl, which then jumped here. Count this SIGBUS, + * and move on to next page. + */ + ++nr_sigbus; + continue; + } + + for (i = bytes; i < bytes + page_size; ++i) { + if (*i) + err("nonzero byte in area_dst (%p) at %p: %u", + area_dst, i, *i); + } + } + + if (write(pipefd[1], &c, sizeof(c)) != sizeof(c)) + err("pipe write"); + if (pthread_join(uffd_mon, NULL)) + err("pthread_join()"); + + if (nr_sigbus != nr_pages / 2) + err("expected to receive %lu SIGBUS, actually received %lu", + nr_pages / 2, nr_sigbus); + + uffd_test_pass(); +} + /* * Test the returned uffdio_register.ioctls with different register modes. * Note that _UFFDIO_ZEROPAGE is tested separately in the zeropage test. @@ -1126,6 +1237,12 @@ uffd_test_case_t uffd_tests[] = { UFFD_FEATURE_PAGEFAULT_FLAG_WP | UFFD_FEATURE_WP_HUGETLBFS_SHMEM, }, + { + .name = "poison", + .uffd_fn = uffd_poison_test, + .mem_targets = MEM_ALL, + .uffd_feature_required = UFFD_FEATURE_POISON, + }, }; static void usage(const char *prog) -- 2.41.0.255.g8b1d071c50-goog