From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC9EC04A94 for ; Thu, 6 Jul 2023 16:14:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 863FE6B0071; Thu, 6 Jul 2023 12:14:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 813C08E0002; Thu, 6 Jul 2023 12:14:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4948E0001; Thu, 6 Jul 2023 12:14:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B4D26B0071 for ; Thu, 6 Jul 2023 12:14:43 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2DAF2140C38 for ; Thu, 6 Jul 2023 16:14:43 +0000 (UTC) X-FDA: 80981685246.12.C174AA0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 5289C120021 for ; Thu, 6 Jul 2023 16:14:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QmpkaGPR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BFZ9Tyry; spf=pass (imf29.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688660076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U3X2c4DZ7u1WJQoXTnnFA0EIrJReIsvKkxSR5ka0KIA=; b=mYPN0vCYjPAvQrmTvd4cFbDN5tdxEzz0nJNpW+1oT7KF84vQe7Qi5IRLTtRl5hEt6C1dXp RvbRcsDBdflYh9T5UrUn/BEJ9k7cNa4lZ1k/SUEYpSnS1EDLMBSId95mw1dbjbS8NBibTT YWQZNKKG+R3mDyMVuF70CwAYZ7osjBk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QmpkaGPR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BFZ9Tyry; spf=pass (imf29.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688660076; a=rsa-sha256; cv=none; b=hMkkcCYLbioJxhM3r70EJmCEFVV+KXc9z+orUJ4qL0d/wb6qymw4xnzf0UPwfzfx8XS716 3agGGnZGX/rDF+n6x/BNiVYWIic04cN6mti7jZCx/TqbwDv2a4NbveKCQQY0guLytEO8yX Uyjufo3lwHgeiTC5jgRJh7l4hBLfm7o= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4E502223E8; Thu, 6 Jul 2023 16:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688660074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U3X2c4DZ7u1WJQoXTnnFA0EIrJReIsvKkxSR5ka0KIA=; b=QmpkaGPRZaoHJzRo2a6TjndqPucrWh7f/FY2L3L/tkSmDEI1eMsM8wrizbEulyyCbALdKF NAhJw22VD9dE7RV9U1X7QxEMrx2wMp7N4RocvtwIIP7j7sOckxmGngjpgD0K7UzZlI8BMj 7TaptoZ4hnlDaa+a0YvCourIJS7rkEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688660074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U3X2c4DZ7u1WJQoXTnnFA0EIrJReIsvKkxSR5ka0KIA=; b=BFZ9TyrydR/g+7ExWBaMGJWuaCnekgsDWt3QOA77tpx+pa0ab3V9kDQ7HgXi8ns77IxFLs krph+7hPTygy6eCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2ADF1138EE; Thu, 6 Jul 2023 16:14:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +RN/CmropmTIKwAAMHmgww (envelope-from ); Thu, 06 Jul 2023 16:14:34 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id B00D6A0707; Thu, 6 Jul 2023 18:14:33 +0200 (CEST) Date: Thu, 6 Jul 2023 18:14:33 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: <20230706161433.lj4apushiwguzvdd@quack3> References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5289C120021 X-Rspam-User: X-Stat-Signature: mzq3qmyuyac3d1su96rtf7go1aw8onj4 X-Rspamd-Server: rspam01 X-HE-Tag: 1688660075-183852 X-HE-Meta: U2FsdGVkX19DeFrRHvLXHEFyF55JSVZHeSK1YnnVOkoYczyRWEvAQ7iQ1PRqXdhoz3Eyiii3URbHiiKHa54d/wIfZMPAVHoPc4LCDpWF5kiF0AbfSwPoRyWgssqbdHA8e6xoFot8mGyX2nVDqXenpcuxFi/YnsALDrF+5YDJMunkBj5rg116OW1IfghCC7R6h2qs2628uWCIiBw2hN94NeEyU3YQghuKwsl1FCKHlErMVSWxoU2dViYfBYehV4c36tqQgWI2Qco/A7LvJgzMybSsnrx0jRfgHvomxeIHJMZud8uGAxGMfWg3kcirN5QxthekzEwquIcispIclw0jHK30Vl1ZKdiwmcUvPwkbLzTTdtOmqPaNaqzJ8XJCByjbPtFH2hRkDT9m9WaAKbzckEwtlgOr43PuROBl0qrh+Ep2qyy6HaEcqVCCr+E0s30u/5XRfqPrOUer1S2Ci9p9ERUImHeCFNREfbFP2esXCXqyvDHNMfCKUvsLYld1sVokYStbGPc58hfzoyumCXTiZazPNSikujP13nO2CCUJt7QVYIg8JueaC4mGd5yQL3y/9vcy0Jc8pZ9zyWwyZxKSKmcAHL37HkuCNogwTFgxsdZc7Xye5Mr2dT+/AjS7bJf3ktKGln7KMmqOF7qtgW1piS+HZ67eY70Y3+ns37BJ817IXCCPSJ9g/wUNzZmxRnoTBEerYVqNT4Bsv3Rq2Q+NSSMM7qGVwmBlXsHgKnxLGAYB7vidyffjZK2Vt1LHHbWY+LpNQ8GCLULg5PkWlHOH7o6JKpxZH3fCDhMFep3b9X1Uc+XUPme01TBWTL2heH0pXqW+ff/8eA7amoxx61ke+KUhYa9Uki8xwZUJEjWVTdWY0XHB83FEm9HRwBwuhMsxvoRtzEjvkBIMLW490UQ6W7AF6comBReWPN+fwn2+IECr0VgcNqqEEjpaoLr5QOCofu1Ceiam+zQtQsYfHiX Vo/jrffe knPKNTS1ThxGfjKqIfnWu2GpqXVF04xQIW7rsSkJwWK4RuncARKWcU9lL8RscFkUs1PQt+/4JJThGTUU58mXMtLOv6ZHhJRC1naTgrZ88iMfLxruyJj76wdKdttXTGz36mDUMbWe6/WCHpxSesZACt/ioZWRYFyI2XrfextJXZBia1gVPb5nTw6gCc6McE4k9ejspIXZc4SA0o3MtpbOutfjjKoKEeT4CB75g9WDCSNekl04MNR1Oi8h8uNhimlTYXOdJle2FsdztoCJTShwBs3f4rNDU3miY8qghE5D+EOBFdtvt1/Q7SEZDymcD2A9xHDTemI73VkrQqhVjU66F/r6qjteakEQ5wVPVwPgkwJ5TUBwQk9c+LnLZbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 06-07-23 08:38:40, Christoph Hellwig wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > return this structure instead of plain bdev pointer. This will > > eventually allow us to pass one more argument to blkdev_put() without > > too much hassle. > > Can we use the opportunity to come up with better names? blkdev_get_* > was always a rather horrible naming convention for something that > ends up calling into ->open. > > What about: > > struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder, > const struct blk_holder_ops *hops); > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > void *holder, const struct blk_holder_ops *hops); > void bdev_release(struct bdev_handle *handle); I'd maybe use bdev_close() instead of bdev_release() but otherwise I like the new naming. Honza -- Jan Kara SUSE Labs, CR