From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D758EB64DD for ; Thu, 6 Jul 2023 10:33:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670168D0002; Thu, 6 Jul 2023 06:33:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6203F8D0001; Thu, 6 Jul 2023 06:33:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E7D98D0002; Thu, 6 Jul 2023 06:33:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3CED78D0001 for ; Thu, 6 Jul 2023 06:33:42 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0554EA01F8 for ; Thu, 6 Jul 2023 10:33:41 +0000 (UTC) X-FDA: 80980825884.15.ADEADEB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id E5543A001D for ; Thu, 6 Jul 2023 10:33:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=glfJHcFp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=X+YQuFhW; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688639620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NiVsKdAXkC4C1ti6b6hv0jp+iKes0bsFerqPpfs57dM=; b=18O5cciNbiO/2Hrhi/exOJu0HjlhGUYIcSWB5UkHGYNn5YTny2/ljC7m7XNPhK2jYRw/NR L+uem2R6htFe/7Bkmus6ggsE1NjkBbkBi3tW8qk1AVpWBsN9pSwBonAx8w1N1h7C62FKVC tdpBCeoEge1OItseddzkRMwCiJrnWmE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688639620; a=rsa-sha256; cv=none; b=lekqYjJMAmum2Xo5E1sOq8rLIQ8ltBQiFXZA6Sza7FNoyku+rw99q4WeBTcaGkNFXeiDVt vIXWJpf1Vwe0QEu81I4X8y9tAN6eboze/xAUiAQEOtjIk0BiQbXz9Xfp/Q6CQPhulkwSHC AA+hMXBposO3IC7fxD7zSjpW0xO8bY8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=glfJHcFp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=X+YQuFhW; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14BAF2233A; Thu, 6 Jul 2023 10:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688639618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NiVsKdAXkC4C1ti6b6hv0jp+iKes0bsFerqPpfs57dM=; b=glfJHcFpaeYEutx1HDXD6eVdg0ILBGXBa4bW5YEn3PVWWtV34go0pHkIrRRU0YtNXQ19wx cteoX9cc3qVvs5jzstomNCgKata7JaGt1xP+2qhMqSO4MJQXPiJUTcUzpwSZBKiyy89e+m mzacgXc0cQE7M3MSwC3GaTjTFfK98jM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688639618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NiVsKdAXkC4C1ti6b6hv0jp+iKes0bsFerqPpfs57dM=; b=X+YQuFhWtWCgxTpI6PkCQKgC7yYru0ex9ES/5Ey/+4mRL9wl5p76yxAPtjmyHpNr09H7QR KmPtM5l/HPzYrEAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC821138FC; Thu, 6 Jul 2023 10:33:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GC2xOYGYpmRLeAAAMHmgww (envelope-from ); Thu, 06 Jul 2023 10:33:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 715A0A0707; Thu, 6 Jul 2023 12:33:37 +0200 (CEST) Date: Thu, 6 Jul 2023 12:33:37 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Hugh Dickins , Andrew Morton , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 11/92] shmem: convert to simple_rename_timestamp Message-ID: <20230706103337.phdkyo6yylua6pdf@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-9-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-9-jlayton@kernel.org> X-Rspamd-Queue-Id: E5543A001D X-Rspam-User: X-Stat-Signature: dzfxwfkkoauq5aquzrsu6z8fuw5fqygg X-Rspamd-Server: rspam03 X-HE-Tag: 1688639619-437688 X-HE-Meta: U2FsdGVkX18CXQGlFrCujMuB0Mf/w3u6c/WTIlYAzss0mv98bzjlMmRWWR+a7QIy4ChRJCv+XFTYLrmZkH56kth8lBDbjmZ+DT5hfo2fRD+9RWh3BBowCf7S/jT5jtKcuxE7abEAflYuQhLp96Ly06gq1bVPPnOQjhboF+riKnD5UKVrvZXM4Xo3RKOfegsEY7xwd1mo8BHslXYbk1UQNkM2daW6O0Bvl6gUTO7VpO2LESPRXiyBWo34EobMBnnAoGrqlL+q9TRSIeSwkeVutnU7+BPcopFXxZHyu2mnXyyjyYTl5CRtEG2zsFEbqSlbBqgBxipgVB5PTf5k0g+gKC4oP6mjb+tfX8g9581Xdkt1nhuBSIiR1NSN/vFqcjJBTBnSFzecfxaXG9JOChnH//ZJQq+mZXn1X2um9pr4xdO0y1eKvnPaZvQ+C82IMMO52iwFGZ2V8cLu8UvQMUeuLVzgJoEqiHE27YYe+cHNSJO4dXDJXflegdJ7DH+iIz+dHDmfCuWcz4m85leD/0kjkqc/I6WadXTzIBT/GbEYjfo2jcadKaFQDdutJVXYcO7foJrfhIdZW6aUwplvs4HTaGMnXKmk8v5oz26y8Vp7o7L1aQ2IaPN+gDdxxbYFO5bVU7IRx7BpIRNIgrR6gnk9LsLprmpwtkYKCfhRYH91WycNspBIPRkB++ttJGL22d0wRd6GyLKOWCeadNgsfjbIM8omgXurPf4ATc5cYd1Fl7GLWq0iMXHG/8T+iIFd3tV8jtMMlWe4yDfqkkPGxTHDoTl2j1pwu9Bh0c2wWCf0VJ4M7KiLVEVEZUrwypJLohO4QLJ5VgBR0J6uW7A48yrCSnpzNQj02sW3a3LN+bVIl+Sx4YOcKa4F3pimfFYzk9OpcOVRU0JCN4ETFgFIzFk5Ng86Zg9thlw6QFCiJ43G6q+G8R5OnVY0GSihzRkJnCzixuZaX1yeM61ylHLbxvp /qloNLUa x06hE5X4llXaIjjoYlvPceXqdSkd/+5ScaYMiS2ZQC1OeJSoLJa6KEK0d0zC6aGcF25Ofhn0AD867gVGewOsEXpXO94DMvVBr2WCO8w2HZr1hO9Ef3m7+2PMy63ZPESjazMLbZSaHFEqpWabwI36yfsiPV27U3gACcY1SvZEcvZbbe7dPZ5HmMmQ8S/GJUlT4Fb58CQYAMwtmQ4yeFBIBN0chIy5E4ZQBps+8zdJevbT+qqpBvNAjkVsAU6at37G7+pNRVkFrxoaPgWp5fNiNeehi5Lb/AJZLgvurkJ5T10mVF4x+M2VDUHi7QGP6VRbVD8TJoDEXV+6I73kUOmgevDIf5EyFDIh272XQx2on2SM7bAI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 05-07-23 15:00:36, Jeff Layton wrote: > A rename potentially involves updating 4 different inode timestamps. > Convert to the new simple_rename_timestamp helper function. > > Signed-off-by: Jeff Layton Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/shmem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 0f45e72a5ca7..1693134959c5 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3306,9 +3306,7 @@ static int shmem_rename2(struct mnt_idmap *idmap, > > old_dir->i_size -= BOGO_DIRENT_SIZE; > new_dir->i_size += BOGO_DIRENT_SIZE; > - old_dir->i_ctime = old_dir->i_mtime = > - new_dir->i_ctime = new_dir->i_mtime = > - inode->i_ctime = current_time(old_dir); > + simple_rename_timestamp(old_dir, old_dentry, new_dir, new_dentry); > inode_inc_iversion(old_dir); > inode_inc_iversion(new_dir); > return 0; > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR