From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F3BEB64DA for ; Thu, 6 Jul 2023 02:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4911E8D0002; Wed, 5 Jul 2023 22:20:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 441558D0001; Wed, 5 Jul 2023 22:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309278D0002; Wed, 5 Jul 2023 22:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 238628D0001 for ; Wed, 5 Jul 2023 22:20:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E131FC07F7 for ; Thu, 6 Jul 2023 02:20:22 +0000 (UTC) X-FDA: 80979582684.01.ABF456B Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 1BEF340004 for ; Thu, 6 Jul 2023 02:20:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Wyo7HQOc; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688610019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=SB+fp/4IAcwj1AaJES96F8jM/hE9LomLIq3InAZgx3Q=; b=sAdXNpU1bmDQUzfcXH3Jmr09+gBbWE73NHZSlRCgqVecyNaHw2COufOfPk6hGQyo0+ynr9 pTMmeAtMO0NJoWAB72plh9a6I/en1d2HvnPGeioAA+Eioh0nMZH6+fNQlVbL4QlbORenUG qgIOpbDeWsL9dUUksvd/y7Y7/jhxzFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688610019; a=rsa-sha256; cv=none; b=ol8I6W/I2bpLzvieiCymWo+BwiNF/KnAGonARY58pb9myrc1PIZ4Qgs1MaSiQsPDh25Qv2 sDeISlscEFL7/vPfFemRs5oXwE3X8BmKLwV0QMFFIcHClI4Da/tbL+3/IFOK0yFJn/i0KU jHYC0/xId46cpkJMHR/0ybTGQegRA0I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Wyo7HQOc; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688610019; x=1720146019; h=date:from:to:cc:subject:message-id:mime-version; bh=hriqH5lwXIcP5IRh6qNw2jm+L4AedwNBnlRcup7jB0c=; b=Wyo7HQOcDtIw59762bnin999Jh0umrnAL3zOMZuJPHOXzEZDIc6lG9nN VUqnW38QQfkfo/9NB2lcEY5fZLkNeu0cihD+/AaXyv/S5zUlvxOzXviEA WbiQVElkpubSg3HcAVEvVOZInVCbJoEuc6f2P5F1Za109/jsVMGZY2sRN wVrT/ViXCdxUy58e6675bFm3gxx3Q1lc5IRrTT1Ly8Ntc3VLS0ktj7FfZ +PhXO1HFmC6k9707WgO4rk2g7zTmk8cWGtx51dFX/cek4J9ikuWoNpp2I BCE+B4nuNJQeIrrs4cECaalzvCexKVs4RC1dtcQt4LP3Y5RHFwbyOG+ZP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="449847278" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="449847278" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 19:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="754585410" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="754585410" Received: from lkp-server01.sh.intel.com (HELO c544d7fc5005) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 05 Jul 2023 19:20:12 -0700 Received: from kbuild by c544d7fc5005 with local (Exim 4.96) (envelope-from ) id 1qHEbL-0000yu-2x; Thu, 06 Jul 2023 02:20:11 +0000 Date: Thu, 6 Jul 2023 10:20:08 +0800 From: kernel test robot To: Hugh Dickins Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: arch/m68k/include/asm/mmu_context.h:164 load_ksp_mmu() warn: unsigned 'mmuar' is never less than zero. Message-ID: <202307061010.9IbhSZb6-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 1BEF340004 X-Rspam-User: X-Stat-Signature: 8am4w13panus6869ppjjt9quutuyim5d X-Rspamd-Server: rspam03 X-HE-Tag: 1688610018-699706 X-HE-Meta: U2FsdGVkX18T1pXBLeSYt9wSuN6CPXIhq55o35KXhVqCYe7H29P6Ms4RV24HAFD0VeJjahELCpSCWahfVXbcV9BovW22a/0UBVfn6zwKMwgoH3G1XbYE2MIdTgqYoJh7jhoj5B6UogWzchogTCIHyKAyAuZRCgadOLBHAkhYsWbiLr7gKHIJw6mCASD2wtoaGdcIDTl/HS00YmopCg3awhJrhH40i8j5DafzW5g0I/qm/T3DT+YzzKA0uGnlr6rPVvfr81IApsGoyMLlNHrNCZd3o3RoPsWwSb0gdk8xXtbHyIwLZ1E1cX1nAaiFzzSJnTCLAB02k47ixNGwg6uVuHnMj845hqLjaJEYdNG74QYWmnnk8IOaeVx73P/sXiDktHgKqwOqnJMAswVPblygBToHcrqgJUudaT9DPL3VTIYugXwOmcS9AGavhk4JImH6DfC+w0wvVbF4qfTbJlXa4FJ0HCJEvdHCHoTes0nUCTk8hxk8c+A/EkRO+7BABsTQvbPGO6arnzSMK5zSyP37o7NXJUTO8R+ZVsaHAZJhobYkd27fmxez2nTywdc7sbr+iVPPx5FaUtyeJeF4MB0uRN2vt4eWNH75nKeyLImb5OnVP6w9gWGJ7vhEnoxS30HM5xXrNlG111qhT5hHjLeQc1DkVi6dzxYRVu2b/I3/Apd6ZimpZQzCdom1O9i0ZvNXti8+ZgLYX0DPzV56nMpXWiuZitBpVWfsIwDDQIVjZ/GARj5NHarAXWazcJYSooc3OYiASfn5TtSrydzMMU1GXrckcm/1txqOYFqg7418hgFt+A+nmSaMMvk1+qdbvmj8C9XbJlHJKqqfNiRZXlEM7cH2Lh47Xyl0DoAF2mfHetRzD1bMMig83Afy9oA2F8nfRsUD01kB0H+JcuMglilZNwIdsBitT28EztrDaKlFGuW1jQy10Ro7G/0B4LuYQwRYxZS0JaaFU9HXZObsEoM c+YhIhtB E1k0v5NCNLNF2G8hQS+1n4By+/9wIwx1euZCSMHPdkq+bJgYiCvkfxQ6AMf5BOl3YnuM1S7bxBEXuOJx2vbYx6XzedRUCmpja4kLDR6ore6snXkzhBpBAj+iuiTRdUwh8JXj6PKsMtDNXNXrIyQFz335d27VBtVpZkcTGDEnP1Md6IJEnUPcQG4LrSm8OoWY5K2EG+NJ7HFx75IpOsjZ9GZFKmMaHqD24jEIw6kJ+18fNaqysaRpexmedkQZ6D/7cfRUdzMxppxlzzlF2n2taeveCOme7gLej393V7P3Snwol2OQcvnQpQW7ly/7+emz3xj4f6GoCCGzVtSVhf6P2huJnreddfd1RWYJ2wdnQbNQs8YL6wNB96qxLgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6843306689aff3aea608e4d2630b2a5a0137f827 commit: e67b37c368b7cc24b8c0fe5ab6c44422312eab37 m68k: allow pte_offset_map[_lock]() to fail date: 2 weeks ago config: m68k-randconfig-m031-20230706 (https://download.01.org/0day-ci/archive/20230706/202307061010.9IbhSZb6-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230706/202307061010.9IbhSZb6-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307061010.9IbhSZb6-lkp@intel.com/ New smatch warnings: arch/m68k/include/asm/mmu_context.h:164 load_ksp_mmu() warn: unsigned 'mmuar' is never less than zero. Old smatch warnings: arch/m68k/include/asm/mmu_context.h:114 load_ksp_mmu() warn: always true condition '(mmuar >= (0)) => (0-u32max >= 0)' arch/m68k/include/asm/mmu_context.h:140 load_ksp_mmu() warn: always true condition '(mmuar >= (0)) => (0-u32max >= 0)' vim +/mmuar +164 arch/m68k/include/asm/mmu_context.h 92 93 static inline void load_ksp_mmu(struct task_struct *task) 94 { 95 unsigned long flags; 96 struct mm_struct *mm; 97 int asid; 98 pgd_t *pgd; 99 p4d_t *p4d; 100 pud_t *pud; 101 pmd_t *pmd; 102 pte_t *pte = NULL; 103 unsigned long mmuar; 104 105 local_irq_save(flags); 106 mmuar = task->thread.ksp; 107 108 /* Search for a valid TLB entry, if one is found, don't remap */ 109 mmu_write(MMUAR, mmuar); 110 mmu_write(MMUOR, MMUOR_STLB | MMUOR_ADR); 111 if (mmu_read(MMUSR) & MMUSR_HIT) 112 goto end; 113 114 if (mmuar >= PAGE_OFFSET) { 115 mm = &init_mm; 116 } else { 117 pr_info("load_ksp_mmu: non-kernel mm found: 0x%p\n", task->mm); 118 mm = task->mm; 119 } 120 121 if (!mm) 122 goto bug; 123 124 pgd = pgd_offset(mm, mmuar); 125 if (pgd_none(*pgd)) 126 goto bug; 127 128 p4d = p4d_offset(pgd, mmuar); 129 if (p4d_none(*p4d)) 130 goto bug; 131 132 pud = pud_offset(p4d, mmuar); 133 if (pud_none(*pud)) 134 goto bug; 135 136 pmd = pmd_offset(pud, mmuar); 137 if (pmd_none(*pmd)) 138 goto bug; 139 140 pte = (mmuar >= PAGE_OFFSET) ? pte_offset_kernel(pmd, mmuar) 141 : pte_offset_map(pmd, mmuar); 142 if (!pte || pte_none(*pte) || !pte_present(*pte)) 143 goto bug; 144 145 set_pte(pte, pte_mkyoung(*pte)); 146 asid = mm->context & 0xff; 147 if (!pte_dirty(*pte) && mmuar <= PAGE_OFFSET) 148 set_pte(pte, pte_wrprotect(*pte)); 149 150 mmu_write(MMUTR, (mmuar & PAGE_MASK) | (asid << MMUTR_IDN) | 151 (((int)(pte->pte) & (int)CF_PAGE_MMUTR_MASK) 152 >> CF_PAGE_MMUTR_SHIFT) | MMUTR_V); 153 154 mmu_write(MMUDR, (pte_val(*pte) & PAGE_MASK) | 155 ((pte->pte) & CF_PAGE_MMUDR_MASK) | MMUDR_SZ_8KB | MMUDR_X); 156 157 mmu_write(MMUOR, MMUOR_ACC | MMUOR_UAA); 158 159 goto end; 160 161 bug: 162 pr_info("ksp load failed: mm=0x%p ksp=0x08%lx\n", mm, mmuar); 163 end: > 164 if (pte && mmuar < PAGE_OFFSET) 165 pte_unmap(pte); 166 local_irq_restore(flags); 167 } 168 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki