From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDB8EB64D9 for ; Thu, 6 Jul 2023 09:03:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72BEA8D0002; Thu, 6 Jul 2023 05:03:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DBD58D0001; Thu, 6 Jul 2023 05:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A3E98D0002; Thu, 6 Jul 2023 05:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 48BF78D0001 for ; Thu, 6 Jul 2023 05:03:23 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1B944160C29 for ; Thu, 6 Jul 2023 09:03:23 +0000 (UTC) X-FDA: 80980598286.12.CC46751 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 0C69214001E for ; Thu, 6 Jul 2023 09:03:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rePQVRdZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688634200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aR7wzPTAeYXclNZiycSvdfYf/LLIfVq6+SCpN6+MKFo=; b=1J/DhredurzmYmvtQZdgzcP7wcq7/fLIa9W+pJ8LgukOh/k0o2Men3sdoyZRO4I2Gkepyb B/b/NGxiDNAkLPyz6XDYGAnkU2wIGxrRbi+TG7Yb/wjBkdwOvLEWaHM9U/8wLdwh72/7U5 jSYfpQ1BXmZAh5jUYyEJgER3jsa82M0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rePQVRdZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688634200; a=rsa-sha256; cv=none; b=Ln0n6iPxm1GCpi/uf24sDDEaZgGbWiEr5QdKElYUPZtiH4csWRuVrLHQkHgGuY+BaGtc// +s12dJvM8nVd9JxcRIOIsypf+1wvG+qTgtGBfSlOv+dcCuhMjLOdUFESR9ZaJXu/jIqP44 L6r5vSykGj0Q/jnS13Wrlqr2aBxaO/Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D963261458; Thu, 6 Jul 2023 09:03:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41383C433C7; Thu, 6 Jul 2023 09:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688634198; bh=bmwwx7MjhCs2MPk4U/hPy8kwH4tv1b3uF0aXE+oLbb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rePQVRdZmjcVnVcq1mHjiOroIGXiH3oYyuWThaMD2WQeB71LFBFpa2j4YfrDJPHEC h7z0g5Tz87cgyToAwg+w+Bcq1grii82C1d3LMdZcAiQ6yn6Q5Or2w1zzEJkZJrauHz Xjw2T+I18zZp47PdFGybzj3x9sDPVUYLHxKRIN7gSUm/CndlzDEPnrAWuHadXl017s TObQ3QLjYmNr8URSi17mrIPe9U0zhoPK3fBYb8/f0xANq78axUcRll6xLjwx5OqFVX s6IQlHfx+YgT9Y6xFjQD1WEDk4v34iW1bztiwpUAUHDxJFyXOv98Mqh2ukkgNWSh0v PCu6aRF4xOLxw== Date: Thu, 6 Jul 2023 10:03:10 +0100 From: Will Deacon To: Andrey Konovalov Cc: Marco Elver , andrey.konovalov@linux.dev, Mark Rutland , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Vincenzo Frascino , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Catalin Marinas , Peter Collingbourne , Feng Tang , stable@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH] kasan, slub: fix HW_TAGS zeroing with slub_debug Message-ID: <20230706090309.GA29243@willie-the-truck> References: <678ac92ab790dba9198f9ca14f405651b97c8502.1688561016.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Stat-Signature: s87drr7qaf39uewt47b5uno8p3d5hfpi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0C69214001E X-HE-Tag: 1688634199-187581 X-HE-Meta: U2FsdGVkX19h9etl/QTuT4Ven9egLrmDV5aIRX9dPagjiGmgObR5QccLIMFp8M98LgwtO0+JO/JKiBEP1RbZ35xg0jVXYvdUo4oI0a1n2VRuMmNkDmXG6JAwfnjsNmqfdRWrtqNPWwoJ4EYU9qODx31vF71IV0ctHYRSM9sHovxLYpT7EBCDimf0N9yVVQmOsjKkXIPdIYhvTDByKtULdhQ+D7Uu/gzktyc/A1livTCI2/2J22dmRPBv2BSsFwzeaNz57r03LczqzZChRVd3+abmAyGYismY9017qlgDzC8Fg89XQN9SgysZCdfvLgFVwG40gXCjmvb9w/IOiQ1+wmOIM2W4le7HEjI3utrIx7TY9hPEFgaAuxr/oL5YqHcM3dcr4OutuhRRVk25bqng7mhvraOAiAJV4IfxESqcqkwcxN67yIwcxVJiUCSKAp3XVrOW7JGYA9BXBr+1MMnC+cqyq3MVN7TwyHqGLOFViJs38wKZtXpASvoO1tRwkAIvew+YMHnejtCf2VSMuVLbeV/owqZ93xpYdMPqGIhgQZyGJusBVfoSfrnLsNJXmFM54RNqLSlhXTIGqO3iNgFm3zM6qFEN9lISXJbnrCkyrr+BDpEMPKDM9d3d86BueXPURiWwFYtYURzRT6GGhMRWgwA1yY4mMYgC7I6avQBlmmGqWDChRTldg/fafxg/tjagkjwJfjHQ0k3++zd3e0h0g6pVmtmgGla/Ed0n3k/eStqUl62QV7plCMx/Id6AVK0o8sf8gawpjGzKbNsYIZtSeRRBG9hwKvDrEKj0CNkJUk1vQmDCVDnsO1cg+gdlrBPNaRFfl8jOhcketuViYyPS8iPLmsfuBcSSDVTKkl3B4O9YQRKtS3StF+WtTaja7JAN8fwlnOOEhDNWDF0r1GC0rSkasSuQiZ3B/N74NfBOREguqzcRl37RmfAarWTbLfD1QmoQ9SnxEUCJ6eVGyMz ezSRbLz3 Trb/Z/rT6FxvTJga6BRKJhOngvKYT6pugBokUP+bPPHuYTKJCJJUm047V+r8L1RkZ5DRdyMf5+xv1/FvKPXMxU4vYNqtuJRs4oCuN7hUSfbsxLvrPVW2941xhs/JFOwjs55tSM4Ywqrb0DTvdgXIikotqPufZJGyBqzgNu061ThHjlg6nmVpSJFCZKSep7nXerkmNhKx5p4ErD818j9VRRNEy43jUxzVSO06PuO1VxCOtC4gDvHqQFht7XVHB+Hmccs88QJYfxo1lewsmueq8SYFsypBGhyvdMaCUtRfpgsIRVAUb7w5+Cj8YOBTazMNosehx47Qyk2GOtvOHmdRqsQYOmIuKw/5+FlNwHx7FNoWpvIoklbFkMZ/4xBh9vb7G7sCvCK62lrZ9lMKYQowVi/0+JH+O2byCfS1tfFlF3Cv40UZj+UIBrWsN4xkgO20XyKtnRomXn/S0ubkLX019nSZe87H72uVw7D+W0hDECWs6/zVADK+YPvIeMcCCL0MqHrd+/6B07lSmmiGYvg6N4Mt/JhwsxX/z6QwLrXEt3Op239E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 03:19:06PM +0200, Andrey Konovalov wrote: > On Wed, Jul 5, 2023 at 2:51 PM Marco Elver wrote: > > > > On Wed, 5 Jul 2023 at 14:44, wrote: > > > > > > From: Andrey Konovalov > > > > > > Commit 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated > > > kmalloc space than requested") added precise kmalloc redzone poisoning > > > to the slub_debug functionality. > > > > > > However, this commit didn't account for HW_TAGS KASAN fully initializing > > > the object via its built-in memory initialization feature. Even though > > > HW_TAGS KASAN memory initialization contains special memory initialization > > > handling for when slub_debug is enabled, it does not account for in-object > > > slub_debug redzones. As a result, HW_TAGS KASAN can overwrite these > > > redzones and cause false-positive slub_debug reports. > > > > > > To fix the issue, avoid HW_TAGS KASAN memory initialization when slub_debug > > > is enabled altogether. Implement this by moving the __slub_debug_enabled > > > check to slab_post_alloc_hook. Common slab code seems like a more > > > appropriate place for a slub_debug check anyway. > > > > > > Fixes: 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated kmalloc space than requested") > > > Cc: > > > Reported-by: Mark Rutland > > > > Is it fixing this issue: > > > > https://lore.kernel.org/all/20230628154714.GB22090@willie-the-truck/ > > Yes, my bad, messed up the Reported-by tag. The correct one should be: > > Reported-by: Will Deacon > > > Other than the question above, it looks sane: > > > > Acked-by: Marco Elver > > Thank you, Marco! Cheers, this seems to fix the splats for me: Tested-by: Will Deacon Will