From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6AAEB64DC for ; Thu, 6 Jul 2023 05:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 754AD8D0002; Thu, 6 Jul 2023 01:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DD418D0001; Thu, 6 Jul 2023 01:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57E708D0002; Thu, 6 Jul 2023 01:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 447A28D0001 for ; Thu, 6 Jul 2023 01:32:11 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DBCA1201D4 for ; Thu, 6 Jul 2023 05:32:11 +0000 (UTC) X-FDA: 80980066062.30.885BC85 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf10.hostedemail.com (Postfix) with ESMTP id 9435CC0010 for ; Thu, 6 Jul 2023 05:32:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bFl4yPpw; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of yuan.yao@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=yuan.yao@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688621529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ig7167W3LV6LpRLIUtP1+sSOf4eeNbNUA0HTsOx6mdg=; b=xfHyCeu/C0kvH6LyrylW12qHfApzkErV4V1hWfYt5WETlFzJAzBUZZq4Y1BQ2T29GH1IHv BlzroUDQ5lQptvQPCzhc5WjYJQmZKWy+2xZQ5sGsPANHeplSk53H8oXG3yWh+8kEqujP21 1lskFeOvg/ayopkVU+dpL3YUVgVbD8E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bFl4yPpw; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of yuan.yao@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=yuan.yao@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688621529; a=rsa-sha256; cv=none; b=eWtJ+fC9UDt08K+O/Cgr7xbt9UlcRb/Hf/3bPP+cLKePfkEUeodOOPW988/z593ltIIygu 3ubnMFghurXPv7GlNmVdcAywkEZIIP3FrgijBHI/QzSbmAZReHwpJyIj1eZJSPl0QXlc2f vdQFduvfXxvPjNKckB2hRLx/lMZ7a+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688621528; x=1720157528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KVUs4bhGOt3/uYXQH2AZkEfvp9H4c7HOkrp0u7M/8fQ=; b=bFl4yPpwH3fmDdlHr3/chCEOf1mOcyqApclM/gbvssWZOLGMINwhlUN9 HJ6JUHNtf2clN4AmSFLOAFWUPpurhN+WzJldPRayePUd3lJpA9KO+o2qa 9ZNxL8bJOv2C8AT228vMtK209fVQbOSIH5UGxJMLvENsMskxgWG1HYpHw 78RPHsRLgUkOh5m237iCJOFjg3j/6xLBtmPeAZJVKYFGiAS1BYJ23sseO BoWLq9RDtCovwvGD248FpXRa/vYK9r5KQ5quqqCCoEq7KmPsk7rbGANb0 WZ9Q3Abr5uBmHsIz/ofBOzJG9Lz9e1Q/VlyLptGTanT/GSTNfrfB+E+Qm Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="362379810" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="362379810" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 22:32:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="719477423" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="719477423" Received: from yy-desk-7060.sh.intel.com (HELO localhost) ([10.239.159.76]) by orsmga002.jf.intel.com with ESMTP; 05 Jul 2023 22:31:59 -0700 Date: Thu, 6 Jul 2023 13:31:58 +0800 From: Yuan Yao To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v12 16/22] x86/virt/tdx: Initialize all TDMRs Message-ID: <20230706053158.73plfugwqvwwkdeo@yy-desk-7060> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-Rspamd-Queue-Id: 9435CC0010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xydzzq3noeru3ekf159iubqswmna1dwq X-HE-Tag: 1688621528-950416 X-HE-Meta: U2FsdGVkX19briVlHAulhcGI1t0uXGasqBPgsPenHImqjA7K575/rj9ck4ifoKlUqoPJyv3xYaG0Tsyc/zo0AxHnwOIKY3S45oj70TDHFcz0laCDvzoQqi4WUHKOuijWJ9L2zoWnr9H/Xka05VF/43AU/q6pvf7RWIqFALmLlK5KEj0UGu0i9fAsvrUgPZl5TeSlFDpKXknkFlJpEh2CI6DnHfcTuprQDGjvXe86DtcpZbEo9ezuUZMFVmvk4fDhHWVuQkY4oFrWB7ETETrNv0hz7RtJDJHulY7HE0rEuc2YCIKdM8IHhfkC64E+5oMrxyIi4cIbwT7UZzvzilXA9JOT9UDbVg3a9Z/398kQ4IPJbP4aO8A0jGxXNbSZF7Z2DOU4kR/fuTDwMBysOuZ5a+zDUQaAC9O9pqwWw5I5ycaboJIcqk0lsd3uRluxy2VpY7405riMaj+2GAUVSBKNDolWHpmBiIguBf9JEaOgMJAWkZKJVxJ90HDa7PwdnfeS2RUST5tR6Nu0lFSm86bK1cb4vWsV2wgkbBClgzCU4aUYgofDmpFumyLJmaTxUwkV7LJrzt+13MRkL+Ca/jXN7Bc/M9IP6zRxxy28QeVkziZDwrpFTfJg8H6HCzb7tbgDNeeUWInLIiDzoImpdpYd21Xe/cm5O+JSvNuREOVIuZY7y1udi2/DxxiSwf0UYYEdtnMhylh/YR7qNmJeuWJzbh+c6p001UyBLwDxybw/K29CQSTsNuM2PO0GHXdqszzmjb1ezWH0X7xohkvwNFz4+DGMNtRQD0peiaYTL6jQYq4go0lfhwv3vZZrym/bg0R9D5UbyXhaPT03q92TbEwLwTYd5DU0LcrFdEqp7nOSw6GrU7qa2tnCWqE3qQHgMAVdEesfwRkQbSg/VdyuGbBnvquIL/Fwl4YGnKgilt2+00HFzx2Y9MCQmNlm1SsoO8/5Wtiuvrub8Fhg2Lqp3Z9 03Ei8W9e P/Bpz1bRMdSlKy8Emot+J4xPLgoo143+L5puA5oTHVvm+m4oERR6pvNGE5OH+Mr3czUuYy8InRVw7nG3JPYOa+bXCQs9ITFK9IaXGcc/dGiHaHwNK1h5GR+SLMyUvfX572lhx3tq/sTs0ZJrH0E9EMmrSwHluCJ11U0J6SEvL4bJ5iArBXuXmAy9o0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 02:12:46AM +1200, Kai Huang wrote: > After the global KeyID has been configured on all packages, initialize > all TDMRs to make all TDX-usable memory regions that are passed to the > TDX module become usable. > > This is the last step of initializing the TDX module. > > Initializing TDMRs can be time consuming on large memory systems as it > involves initializing all metadata entries for all pages that can be > used by TDX guests. Initializing different TDMRs can be parallelized. > For now to keep it simple, just initialize all TDMRs one by one. It can > be enhanced in the future. Reviewed-by: Yuan Yao > > Signed-off-by: Kai Huang > Reviewed-by: Isaku Yamahata > Reviewed-by: Kirill A. Shutemov > --- > > v11 -> v12: > - Added Kirill's tag > > v10 -> v11: > - No update > > v9 -> v10: > - Code change due to change static 'tdx_tdmr_list' to local 'tdmr_list'. > > v8 -> v9: > - Improved changlog to explain why initializing TDMRs can take long > time (Dave). > - Improved comments around 'next-to-initialize' address (Dave). > > v7 -> v8: (Dave) > - Changelog: > - explicitly call out this is the last step of TDX module initialization. > - Trimed down changelog by removing SEAMCALL name and details. > - Removed/trimmed down unnecessary comments. > - Other changes due to 'struct tdmr_info_list'. > > v6 -> v7: > - Removed need_resched() check. -- Andi. > > > --- > arch/x86/virt/vmx/tdx/tdx.c | 60 ++++++++++++++++++++++++++++++++----- > arch/x86/virt/vmx/tdx/tdx.h | 1 + > 2 files changed, 53 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index f5d4dbc11aee..52b7267ea226 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -994,6 +994,56 @@ static int config_global_keyid(void) > return ret; > } > > +static int init_tdmr(struct tdmr_info *tdmr) > +{ > + u64 next; > + > + /* > + * Initializing a TDMR can be time consuming. To avoid long > + * SEAMCALLs, the TDX module may only initialize a part of the > + * TDMR in each call. > + */ > + do { > + struct tdx_module_output out; > + int ret; > + > + /* All 0's are unused parameters, they mean nothing. */ > + ret = seamcall(TDH_SYS_TDMR_INIT, tdmr->base, 0, 0, 0, NULL, > + &out); > + if (ret) > + return ret; > + /* > + * RDX contains 'next-to-initialize' address if > + * TDH.SYS.TDMR.INIT did not fully complete and > + * should be retried. > + */ > + next = out.rdx; > + cond_resched(); > + /* Keep making SEAMCALLs until the TDMR is done */ > + } while (next < tdmr->base + tdmr->size); > + > + return 0; > +} > + > +static int init_tdmrs(struct tdmr_info_list *tdmr_list) > +{ > + int i; > + > + /* > + * This operation is costly. It can be parallelized, > + * but keep it simple for now. > + */ > + for (i = 0; i < tdmr_list->nr_consumed_tdmrs; i++) { > + int ret; > + > + ret = init_tdmr(tdmr_entry(tdmr_list, i)); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > static int init_tdx_module(void) > { > struct tdsysinfo_struct *sysinfo; > @@ -1067,14 +1117,8 @@ static int init_tdx_module(void) > if (ret) > goto out_reset_pamts; > > - /* > - * TODO: > - * > - * - Initialize all TDMRs. > - * > - * Return error before all steps are done. > - */ > - ret = -EINVAL; > + /* Initialize TDMRs to complete the TDX module initialization */ > + ret = init_tdmrs(&tdmr_list); > out_reset_pamts: > if (ret) { > /* > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index a0438513bec0..f6b4e153890d 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -25,6 +25,7 @@ > #define TDH_SYS_INFO 32 > #define TDH_SYS_INIT 33 > #define TDH_SYS_LP_INIT 35 > +#define TDH_SYS_TDMR_INIT 36 > #define TDH_SYS_CONFIG 45 > > struct cmr_info { > -- > 2.40.1 >