From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D9CEB64DA for ; Thu, 6 Jul 2023 00:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 356DB8D0002; Wed, 5 Jul 2023 20:44:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 306B18D0001; Wed, 5 Jul 2023 20:44:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D00B8D0002; Wed, 5 Jul 2023 20:44:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D1608D0001 for ; Wed, 5 Jul 2023 20:44:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CDA7C8045B for ; Thu, 6 Jul 2023 00:44:45 +0000 (UTC) X-FDA: 80979341730.02.D550177 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 0D6D9140004 for ; Thu, 6 Jul 2023 00:44:43 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZHoiWE6i; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688604284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cj9rmCeL+AZ6QHmSoAJxaorXqhnFAOK3Nz1VnC7AEt0=; b=RRAQcSSrfk2ZCQIlRjrt+NnCnk+h2HuViBfrlLK9fVrdweuxI6bt0ta3zk8cGLCECucyzn fxdxqRQSPi1t/xvZfrTNrfdKgCHJzlpC3CqsuHa4y/39PpnRoTYpuFT6kkPgeD1gbKQWBb EFL792j1LleC+KsyVzQ+MZSEheI9eUs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZHoiWE6i; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688604284; a=rsa-sha256; cv=none; b=jEdmVqvFKERsvmtxunq82ra8wPipaZGyMWTosJpR632Mp7ZKRoEe2XXwayeFT1J/nYtv8t m1RdyRbNSCn/KtYFHj2aMIMyqYCFeUvG2pG5Y3+AzMiZH3hZC8NmoLtCgcTJcTwQEOk1oH 86Yu+uoxLxXkJhJl0HcbvdRS6L2FW/Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2046B617D7; Thu, 6 Jul 2023 00:44:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAC35C433C7; Thu, 6 Jul 2023 00:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688604282; bh=aEC6PCPk3DBXeBBrvw5oME0/w9hJPSVa0CwOwDzK5eA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZHoiWE6ijdvrCAMom8HCoWZK5cb2gf0Tfw/24RivBzOPbokC20IXa0XpVfmEjlESo v1S4ZyPbcfhogeLVhTwMpVtIQxmEJRAzCVhwtL8qsIG17d9MqyIVNVzoc6D6HIxjeL EKQw1TOIKypxdrpKc9vqsOhVRC6DXGsMZBo0Hba0= Date: Wed, 5 Jul 2023 17:44:40 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: Peter Xu , David Hildenbrand , jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed Message-Id: <20230705174440.9adb53f2e362056867135b84@linux-foundation.org> In-Reply-To: References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> <20230705172424.e505f5013bfdf44543d9c6be@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0D6D9140004 X-Rspam-User: X-Stat-Signature: dkk79rts8bwugucobio5ach5477igz63 X-Rspamd-Server: rspam01 X-HE-Tag: 1688604283-306725 X-HE-Meta: U2FsdGVkX1+G1vs06cn1SCpizqqBPCLQM2z5sxDPMS6aQD/TpSo2/D+0lOxihQbybKdfczLQ9/EmQ5ruwZYgQYHs9TG/czNH71RVRX5vTeY3ra1+LAPtiT3UlWH7Mc0VySydQ1LLlnGc91WiWdgFissnDsWqU2RdV6uzfYZuDDda0bKXaVR5Ec9L1khV/q4dZSmYBya7ljQ2CTOl+MkgwSxKRg5NqKA2PSiyAXAtfTu6xfkh08bl0J4kz760EKdwVUKvRQbqMmezIa0lrdW/v3uygVY4rpt9TeEWjAW8lBBm3sCQWKfnlaFuYwtarfiZv1nZWa6/oYYw+krfiAGPZFyIIlj6MOQ7z/olTqL2qIVTQN9xcI/lIZhv+x2zeHSh66EdEcFK2ioif2T+gvkw1GefZmepYUHXS5x4/aHHl4ZMdDhxAQrBccx2Jzvv28ZBnMW/XRMwtX/W9Azs69XmqgbsPW7oB4OlqNzxpnBzT37th9WVPmKTpRFa9+XCJnm5ZvjL4T3vqovGXz2+PF2FHBpGCTKBLpkt0qTZUmGAkvi7oI/kale/m8rata+hwbbs82oLzFIBnPn0sLmQ6bekZgnou7b1sG8MOaFgSPC4oh9e44Fje5G4pogO6xNs2iTybL5XKBlLMsS+hZKidNt76Qn2A4Pon4SLOaqP7mCkZnU8bqZzV5hCWFGCETWP6PDj09TW22ZHIoOvNjLKS8SmTKRvUVy904OaMyHQ/u4X0asozSpL1qQRdUEN8QG3ERsWH+nX3mKA2LlzwKm8fTNq/c6546r3jFPw1p3lkblYDXQFgDYnXqgK0fuNuCg+R9SqJJG97FjJ8CCJx/PKAkNOMB489nfzuEP5s9QM2XDh5NUndljyB5rErxxK/zyDyItRAaYGzSL8sXHgvSTwev4Y+WAFQFn8OEcQOycEKFWBJ94vQ9aswP3x79yIrOCB7ySn+bJR/7vIKDNARmyeuO0 xB+0lm0O aFPHRUR4vhovdKz7h202PyFDwtnPRpKcfYcnRI46+pFI07ornxZqyB+e9PZhqMztW8hEvxdISHk2KYXz5dokNEUEDeoH492EGDTx+6tvEXjVgJ+FocY9qK9cdlVI9S5CVuDI2ka+OkI03gV/FbFM7QEga+vtRchqtzKMmAf984upe1Ejm5eKuSug6t8/nXGDpZle8Zv5046QugK3jVBtwQF/yU4M/e3UWgYTSPRmp+HFM3WR/GkkZ1RqW/R2IhVHZuc4iLeHYIgfYPZ5EMWguCcSu8P20NIRh3vcDuttv5yWbdY3aAHXU2a5RoBJtAeiK4+ju6YzV5fRdbXnDLHEhTw8gAV0gmdlfZ+qnwNKv+CzyXuKz/eQBtH5QXYUfGFfJCBBIsyZQN2IPdf6cEAMc0VxWZqE62ttXU9FPdP63vrUwJhrNh7lZDrrcUWk9ndV1CwNCoHc+bk2GQfGh8ZjCpIpjMVLDKLR1hUVJOaa2hYcQAdhrltb9in/F1737+c4cVkG+wlr9XqhLV/ZEDHtMQge+0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 5 Jul 2023 17:32:09 -0700 Suren Baghdasaryan wrote: > On Wed, Jul 5, 2023 at 5:30 PM Suren Baghdasaryan wrote: > > > > On Wed, Jul 5, 2023 at 5:24 PM Andrew Morton wrote: > > > > > > On Wed, 5 Jul 2023 13:33:26 -0700 Suren Baghdasaryan wrote: > > > > > > > I was hoping we could re-enable VMA locks in 6.4 once we get more > > > > confirmations that the problem is gone. Is that not possible once the > > > > BROKEN dependency is merged? > > > > > > I think "no". By doing this we're effectively backporting a minor > > > performance optimization, which isn't a thing we'd normally do. > > > > In that case, maybe for 6.4 we send the fix and only disable it by > > default without marking BROKEN? That way we still have a way to enable > > it if desired? > > I'm preparing the next version with Liam's corrections. If the above > option I suggested is acceptable I can send a modified second patch > which would not have BROKEN dependency. I think just mark it broken and move on. At some later time we can consider backporting the fixes into 6.4.x and reenabling, but I don't think it's likely that we'll do this.