From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Yin, Fengwei" <fengwei.yin@intel.com>, willy@infradead.org
Cc: akpm@linux-foundation.org, willy@infradead.org,
ackerleytng@google.com, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oliver.sang@intel.com
Subject: Re: [PATCH v2] readahead: Correct the start and size in ondemand_readahead()
Date: Wed, 5 Jul 2023 09:52:35 -0700 [thread overview]
Message-ID: <20230705165235.GA6575@monkey> (raw)
In-Reply-To: <d6957a20-db31-d6ac-8822-003bdb9cd747@intel.com>
On 07/04/23 09:41, Yin, Fengwei wrote:
> On 7/4/2023 2:49 AM, Mike Kravetz wrote:
> > On 06/28/23 12:43, Yin Fengwei wrote:
> >
> > Thank you for your detailed analysis!
> >
> > When the regression was initially discovered, I sent a patch to revert
> > commit 9425c591e06a. Andrew has picked up this change. And, Andrew has
> > also picked up this patch.
> Oh. I didn't notice that you sent revert patch. My understanding is that
> commit 9425c591e06a is a good change.
>
> >
> > I have not verified yet, but I suspect that this patch is going to cause
> > a regression because it depends on the behavior of page_cache_next_miss
> > in 9425c591e06a which has been reverted.
> Yes. If the 9425c591e06a was reverted, this patch could introduce regression.
> Which fixing do you prefer? reverting 9425c591e06a or this patch? Then we
> can suggest to Andrew to take it.
For now, I suggest we go with the revert. Why?
- The revert is already going into stable trees.
- I may not be remembering correctly, but I seem to recall Matthew
mentioning plans to redo/redesign the page cache and possibly
readahead code. If this is the case, then better to keep the legacy
behavior for now. But, I am not sure if this is actually part of any
plan or work in progress.
--
Mike Kravetz
next prev parent reply other threads:[~2023-07-05 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 4:43 Yin Fengwei
2023-07-03 18:49 ` Mike Kravetz
2023-07-04 1:41 ` Yin, Fengwei
2023-07-05 16:52 ` Mike Kravetz [this message]
2023-07-06 1:32 ` Yin Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705165235.GA6575@monkey \
--to=mike.kravetz@oracle.com \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengwei.yin@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oliver.sang@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox