From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642F4C001DF for ; Wed, 5 Jul 2023 18:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C170F8D0002; Wed, 5 Jul 2023 14:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9FC08D0001; Wed, 5 Jul 2023 14:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19448D0002; Wed, 5 Jul 2023 14:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8E00A8D0001 for ; Wed, 5 Jul 2023 14:54:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 528C08094A for ; Wed, 5 Jul 2023 18:54:38 +0000 (UTC) X-FDA: 80978459436.09.3F04827 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 8B8C7C0018 for ; Wed, 5 Jul 2023 18:54:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of "SRS0=voQb=CX=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=voQb=CX=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688583276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f6MJG4+NyEsopxT04NCNmDj2uJq8VT01m5qvDEkL7mE=; b=G/hMJJxWqMin/uxpf6avuFhAVgBZx/Nn5/dVXYECmPWkySoqHRkZYqwJY/pv7wFapx1prE f4Qo4bCEHDT2ztvV6/uec0uoZyRnmbJZXaML7vvEbqtVhckf0w/gHGq5xUgsXrfrDney9p TOUpQemR2VF5y1RWHfIZu2lTSLbc6nw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of "SRS0=voQb=CX=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=voQb=CX=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688583276; a=rsa-sha256; cv=none; b=CnVO6DgaMvFSgVrRnjodQ8BRi0t+bop6TqrR5U3BhO1SgCTea49vXRh3qidvrsa/pgwI+C bhRbxS6BcOXBFyIHDXIyVcW6Wj87Ae6IVxzTo4xEvfjPEnDlcNf+CQrHjfQ13eo6eLCZOc iV2Y+ABGb3XBGDGZfzjuLSfr0HwMh8A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DA40616CF; Wed, 5 Jul 2023 18:54:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22E68C433C7; Wed, 5 Jul 2023 18:54:21 +0000 (UTC) Date: Wed, 5 Jul 2023 14:54:11 -0400 From: Steven Rostedt To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH 02/14] tracing/filters: Enable filtering a cpumask field by another cpumask Message-ID: <20230705145411.33e1e173@gandalf.local.home> In-Reply-To: <20230705181256.3539027-3-vschneid@redhat.com> References: <20230705181256.3539027-1-vschneid@redhat.com> <20230705181256.3539027-3-vschneid@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8B8C7C0018 X-Stat-Signature: w3kyuh181scnyrzoqa6xidinf4sj53zr X-HE-Tag: 1688583276-681292 X-HE-Meta: U2FsdGVkX1/Wxdoc8pN/+8sijgoq0IF0RkFskip42hwSAJmiIA3Eebltk3hTLB2RnET2ZR/H8rSdHT36kSmux3vwIcu3KxFdgRYAl4HeCBiJVB7e7fVGo1RUsBq+aXglY5gj+ovDPJw6nv9MkpxKRAa+isGWPxHwaSxtqMfIm0cFFaHGITDUG68SZuNktwRBv9xQ9axLTHfAcO5Wpy5zvjgZ9Xdoily1Eg6P/t6rRPEBtyfasDTT2+cRabhEekK7EVQZLcNmhZWIyi2zIck/KTlytW7BT14jVm5cPu3T3jH5PKfp9IaEvkIAeKirnHpUUc1b+Hk4ITkHEhcreNChMbBRERRs4xgl3R8Tg5+rLL9LAI4sh7JKe/yiJhYP7Kal8xNWKBdLWC+A+hVMgh5az+fTxkvOm/X2hTzzyGuGgMHVwwyl+SV7k/s8sZbI6aQIJHUnJf0ygdsfVSTT7I0QroshhfVGrFQ8UjWfjywPMjWj7smcuJpTUesQpaFJs5ZZn54pdRyIJHXdRYEk5DlYwIzpW5eCPluQvIxDUx4dXhCTo9gy6a1Z3cbUyoNaSnHvu7LEGBEe7h7PSlkthdmvtHvgyxYMTGbfCPrsfzKXY3LuQw0qPFZMzHV60utBmvP4g9fqDf9SF20KhwYPTxTrF3HMbX4Ac7ds/TlRKqzwUnnQTrWrvlgClvacCdC4b2MtjfcBkJ5/6zxlbK2rpMFzPcG8QCoBDHbyLFqxSjiUnOYBRDQ40Mo0o4PykPNFbRdlIRqlWAbq4+ranuDh37M0gvPwLiFdgNcRyxrBRANTHswx0uICKH3IZ5lzy3Hx+HrmvTlzFrCehDCx6pCJEd1OU3tcVWKI9kZPgar3Bm6QP/JAV6n9/CdJ/TqzBIfyxT//rGm8Uuox/s89ges/nRRspDeHFpMa5OW494NETIGaQYVVBh2qcx0wREra0JrOfBq2kX2xxqaIpxSE7EhzCOq WQIey4wW FJNd89QR0og9ocEuUAA0Qv4+6VrsHOFmk51YDtr7LeSfMH+x4oeiunddn6A+b7OkzrKysW4dLmPIlCFzgM2d+joeQ+VEi4tL2n+yLWnlQXG0Rf/bpCnwkB0CxDJicO7asnkFTaNOR6LFA5q2Qw6I1YZ0a2UxIvJl52Bg2N+fylxePXx6CbPKHg5AxWGI3xVhczM22BTXuoacpt/wwyxNUsxG8AWd9OduxfgU6rlFnjxNkvLhmXb/iaME/FCpT6yIhCjYWND7hUR5CKSLxFjbCRo+YO8Ff72b3aoQQRleI9IwYLG7vfFQ62RQFJST6nzTdjp2acX5PonXSqe1uZY+pl3R7nB+yooFxx5pxzQ8rg7iRbrhliNnQW1kn9tHCrgDaezb4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 5 Jul 2023 19:12:44 +0100 Valentin Schneider wrote: > + /* Copy the cpulist between { and } */ > + tmp = kmalloc(i - maskstart + 1, GFP_KERNEL); > + strncpy(tmp, str + maskstart, i - maskstart); > + tmp[i - maskstart] = '\0'; > + You can replace the above with: tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL); strscpy(tmp, str + maskstart, (i - maskstart) + 1); As strscpy() adds the nul terminating character, not to mention that strncpy() is deprecated (see Documentation/process/deprecated.rst). -- Steve